From: Adrian Hunter Subject: Re: [PATCH 4/9] mmc: sdhci-sprd: Implement the get_max_timeout_count() interface Date: Mon, 3 Jun 2019 15:34:38 +0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Baolin Wang , ulf.hansson@linaro.org, zhang.lyra@gmail.com, orsonzhai@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, arnd@arndb.de, olof@lixom.net Cc: vincent.guittot@linaro.org, arm@kernel.org, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On 20/05/19 1:11 PM, Baolin Wang wrote: > Implement the get_max_timeout_count() interface to set the Spredtrum SD > host controller actual maximum timeout count. > > Signed-off-by: Baolin Wang Seems surprising that there isn't a custom ->set_timeout() as well. Nevertheless: Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-sprd.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c > index 31ba7d6..d91281d 100644 > --- a/drivers/mmc/host/sdhci-sprd.c > +++ b/drivers/mmc/host/sdhci-sprd.c > @@ -285,6 +285,12 @@ static void sdhci_sprd_hw_reset(struct sdhci_host *host) > usleep_range(300, 500); > } > > +static unsigned int sdhci_sprd_get_max_timeout_count(struct sdhci_host *host) > +{ > + /* The Spredtrum controller actual maximum timeout count is 1 << 31 */ > + return 1 << 31; > +} > + > static struct sdhci_ops sdhci_sprd_ops = { > .read_l = sdhci_sprd_readl, > .write_l = sdhci_sprd_writel, > @@ -296,6 +302,7 @@ static void sdhci_sprd_hw_reset(struct sdhci_host *host) > .reset = sdhci_reset, > .set_uhs_signaling = sdhci_sprd_set_uhs_signaling, > .hw_reset = sdhci_sprd_hw_reset, > + .get_max_timeout_count = sdhci_sprd_get_max_timeout_count, > }; > > static void sdhci_sprd_request(struct mmc_host *mmc, struct mmc_request *mrq) >