Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 554DFC61CE8 for ; Mon, 9 Jun 2025 12:03:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uObDj-0007yb-B2; Mon, 09 Jun 2025 08:03:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uObDh-0007yJ-6k for qemu-devel@nongnu.org; Mon, 09 Jun 2025 08:03:17 -0400 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uObDd-0005hB-9u for qemu-devel@nongnu.org; Mon, 09 Jun 2025 08:03:16 -0400 Received: by mail-pl1-x641.google.com with SMTP id d9443c01a7336-22c33677183so33841975ad.2 for ; Mon, 09 Jun 2025 05:03:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1749470590; x=1750075390; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=usPCwdu/bUNpbZgZnZVpiDvJ1pWA3Uq4f0/0dWe1wEY=; b=h6II8FDV2rMMSBlpXHbVMbR9dSiJXtU1nznYXeU6ojEbkpKMRIyyfwzxHgE7WFDJgb MVDPAkmaekO7KuHTpInEwzqJP0ua02m+j3uarZsZ1nQ2g9aq+Sbtkz7we5tKXvPKvKBI liDCMMkwObjtCGnP6EeqI19bqVlE4wZ9+7bFNN9UU5XVH8U3JOy7EYQ9PpJjgGFbxqs1 LxRE+X1HeEUt0i1WSiuQ8okH43x+bR5nOl/eDJooXCUVL7Red1B7CYBkaSYV2BGs62Ql a/QaAIh3ByMnqi7DKcXEcxoBrY/mT1JzlAIrdTRqfV60oRcDy8GfRoxHZuU0aub3hzG+ 0cSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749470590; x=1750075390; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=usPCwdu/bUNpbZgZnZVpiDvJ1pWA3Uq4f0/0dWe1wEY=; b=EaMa1VBWZVC/3dVeK7LoFoK1lOCC+uqiJNqf5oUiuDxPutt20dFuqRTewKy4A+yl+f i/ptfVy4Qa70Xzs7X6vAOSKXX7xbq3ghMjFr/JU6dZbTsW4S8CmYQCBmatk34FCRFP6s TUQwxwFkoGnKDqLqx/hAVgbYb5M8/gP4EkiAQnQ6Afp6mr+/uMHDu7ocRo/XPXFOWz2/ Hh0CCthYMf3juteB6udVXiuJpC7tM0L1d5iJcDOu1zFviaUEEuwS2ffIhUav/dyd3oSe rmSoLdeEJkKVyJXlGlX9gb5aCXp+HRK2tBsWI80s3o/o92LUd7+8dI1Mp1K9UizQB7q+ qLrg== X-Gm-Message-State: AOJu0YxSftKZ3Bi/ONRylZmcBBfrHLUDNvW47iS4R3pmsa9EhFlslcO2 9suBbvnzAy7dtyRdg2hz5aSPGde8HNdKDLPDDc8Ua/DozuqEB/JtL4rEFYWfO8eImrg= X-Gm-Gg: ASbGncvXN755WDSp+S5FfUoczfYVEXpV2XM9pYwuGP2xWc3UgMBtOR418eSLh7q7EAb eXP99pivyxj6ocr9OM8qsJI7S+GPyU+J6Zdwb1q4PYP5lBlKjsLTImwAdeOQxsr5HTAdAdfz4GQ UxV30LJfp7kg4miVbaaYZtLwLbt/tvytErUSzKp71WYJTH+9Q9IJ8qgk9EHUlHLa9Z+G/Lc9qQo nRBMT2ouVbsusXIfdQak2xn169Nz9z6ggsT2Z0CfXCOi12m51LOCqfYry0Qj2VzWbV5A6UQk7ZP 6qoAENTZxpS5OtbWhTEqk5wUupVFTsqsCOq4FrOysSJN9+RLYZ+cueh4Te4+S03J24D9Gn5lDZQ = X-Google-Smtp-Source: AGHT+IGXF7JPu0VMaW4oMjKdhH1qKPHKVeZns53qaJ1DEXGIBNxmJM33sYw+DJKwBsAQ/ysOP02wzg== X-Received: by 2002:a17:902:ce8e:b0:235:225d:3087 with SMTP id d9443c01a7336-23601d4ed7amr170531285ad.30.1749470589693; Mon, 09 Jun 2025 05:03:09 -0700 (PDT) Received: from [192.168.68.110] ([179.93.21.192]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-236032fcd40sm53240035ad.125.2025.06.09.05.03.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jun 2025 05:03:09 -0700 (PDT) Message-ID: Date: Mon, 9 Jun 2025 09:03:05 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] hw/riscv: add CVA6 machine To: Ben Dooks , nazar.kazakov@codethink.co.uk, joseph.baker@codethink.co.uk, fran.redondo@codethink.co.uk, lawrence.hunter@codethink.co.uk, liwei1518@gmail.com, zhiwei_liu@linux.alibaba.com, qemu-riscv@nongnu.org Cc: qemu-devel@nongnu.org References: <20250527112437.291445-1-ben.dooks@codethink.co.uk> <20250527112437.291445-2-ben.dooks@codethink.co.uk> <110336ae-4f0d-4e27-8bd4-5cd336c7fb4c@codethink.co.uk> Content-Language: en-US From: Daniel Henrique Barboza In-Reply-To: <110336ae-4f0d-4e27-8bd4-5cd336c7fb4c@codethink.co.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::641; envelope-from=dbarboza@ventanamicro.com; helo=mail-pl1-x641.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 6/9/25 8:32 AM, Ben Dooks wrote: > On 09/06/2025 12:24, Daniel Henrique Barboza wrote: >> >> >> On 5/27/25 8:24 AM, Ben Dooks wrote: >>> Add a (currently Genesy2 based) CVA6 machine. >>> >>> Has SPI and UART, the GPIO and Ethernet are currently black-holed >>> as there is no hardware model for them (lowRISC ethernet and Xilinx >>> GPIO) >>> >>> Signed-off-by: Ben Dooks >>> --- >>> v2: > > Apologie,s looks like it this got rebased out of the release > >>> +/* plic register interface in corev_apu/rv_plic/rtl/plic_regmap.sv */ >>> + >> >> I believe you've missed my comment in v1: >> > > would this be ok > > /* > * plic register interface in corev_apu/rv_plic/rtl/plic_regmap.sv > * https://github.com/pulp-platform/rv_plic/blob/master/rtl/plic_regmap.sv > */ LGTM. Thanks, Daniel >