Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A30D6EDF165 for ; Fri, 13 Feb 2026 14:17:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vqtz5-0000fR-V0; Fri, 13 Feb 2026 09:17:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqtz4-0000f4-5Q for qemu-devel@nongnu.org; Fri, 13 Feb 2026 09:17:26 -0500 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqtz1-0001Ao-VV for qemu-devel@nongnu.org; Fri, 13 Feb 2026 09:17:25 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1770992224; cv=none; d=zohomail.com; s=zohoarc; b=Xf8Su7h+sUAtsjgnJCreo1MMxUYfBE3xaa91iuvX7L8MLmhYxxw4O52xWLUyudVxG0h3e+6+OBGq62ExmPbLWQ7cmnn/TvN0jowucyGqRfn4kv9hbjaawpuqP0qkqnY9Qa/OCR6dWotc8RU8THW0Atx+rjzdQY45hFXThJm7h2o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770992224; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=pGCzceX4lJ/p37tlcF1WFYXrg6b/fRyzewo3YXWSlZI=; b=G9i8+CchEOfeoEJmRbJC9dYKTGyXOEnJWkgcB4qvWnZyQPJIa3HaBWhCxaY7Lb06S/F7VIapjB41pahR3AA2Y5bGJpGtCOQo+lfiLjWWy3HOxj3yfAMNWE0UZ5AoG/R90I49Cx16rzkdQ2I+PsA4/2DKHYetoqAU7VmVyqy7vJg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1770992224; s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:From:From:To:To:Cc:Cc:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=pGCzceX4lJ/p37tlcF1WFYXrg6b/fRyzewo3YXWSlZI=; b=TcNq8DxQ7jUlrhcYjEjP7qqKMDuCFvAUDkmWk7UGxU7Ud2x0+lyOSnH/PYLubuuH NXI/Oi0KkJeMPZLSDVA5vd4yvRNPIZxV7bjoE3qHnojivS4CUxBIJ3nxVBkQEl4BvcV +3JH+Y1lBowfc2rc763BVAxu81GypvfgFot5zUKk= Received: by mx.zohomail.com with SMTPS id 1770992221859741.5554895616083; Fri, 13 Feb 2026 06:17:01 -0800 (PST) Message-ID: Date: Fri, 13 Feb 2026 17:16:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PULL 41/51] virtio-gpu-virgl: correct parent for blob memory region From: Dmitry Osipenko To: Michael Tokarev , Joelle van Dyne Cc: "Michael S. Tsirkin" , "qemu-devel@nongnu.org" , Peter Maydell , Akihiko Odaki , =?UTF-8?Q?Alex_Benn=C3=A9e?= References: <81cb15cf3774140da7c17341018a3852f920acb5.1770231744.git.mst@redhat.com> <4eb93d7a-1fa9-4b3c-8ad7-a2eb64f025a0@collabora.com> <68223045-effa-4319-817b-1a31f227c081@collabora.com> <20260212020117-mutt-send-email-mst@kernel.org> <2fb2bae5-6c2c-45e0-adb8-96eb32bcc659@tls.msk.ru> <7ffe6db4-d43f-480b-8607-438baad412ab@collabora.com> Content-Language: en-US In-Reply-To: <7ffe6db4-d43f-480b-8607-438baad412ab@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.112; envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2/13/26 17:04, Dmitry Osipenko wrote: > On 2/13/26 16:30, Michael Tokarev wrote: >> 13.02.2026 02:57, Joelle van Dyne wrpte: >>> On Thu, Feb 12, 2026 at 3:00 AM Dmitry Osipenko >>> wrote:...>> Joelle, are you aware of >>> this problem with the version that got applied >>>> to the qemu/staging tree? If yes, could you please send patch fixing it? >> >>> Unfortunately, this means that the patch should not have been back >>> ported. It is possible that the crash which this patch was addressing >>> was introduced as a result of changes elsewhere. For example >>> https://lore.kernel.org/all/20250924-use-v4-0-07c6c598f53d@rsg.ci.i.u- >>> tokyo.ac.jp/ >>> changed some internal mechanics of finalize. I didn't raise any >>> objection to the back port because it seemed like the original code >>> where the object was its own parent was wrong but I guess it was >>> working fine somehow. I think in the meantime the best course of >>> action is to revert the patch in the stable branches. >> >> Ok, it was me who thought it's a good idea to apply it to stable branches. >> Sure thing, if it's wrong, I should revert it. >> >> Do I understand it correctly that in current master, this change is okay, >> due to other changes (maybe like the above-mentioned one), but in previous >> stable versions, it is not? >> >> Should I make another stable release to fix this one?  I mean, how serious >> it is? >> >> I'm sorry for the trouble. > > I tested master and stable 10.1.4 in addition to the staging branch, all > three are broken by this patch. Hence the patch is wrong in the first > place and not fixing anything. Once again, Joelle needs to explain how to reproduce the addressed problem as virgl and venus are known to work properly. I suggest to revert the patch from all branches and try again with another version later after clarifications from Joelle. -- Best regards, Dmitry