Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E187C4167B for ; Tue, 31 Oct 2023 03:47:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B1276B02B8; Mon, 30 Oct 2023 23:47:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 661866B02B9; Mon, 30 Oct 2023 23:47:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5504A6B02BA; Mon, 30 Oct 2023 23:47:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 41CB86B02B8 for ; Mon, 30 Oct 2023 23:47:10 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1247AC0A72 for ; Tue, 31 Oct 2023 03:47:10 +0000 (UTC) X-FDA: 81404371020.26.66784F2 Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf13.hostedemail.com (Postfix) with ESMTP id 5E4062000D for ; Tue, 31 Oct 2023 03:47:08 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=linux.com (policy=none); spf=softfail (imf13.hostedemail.com: 62.72.0.81 is neither permitted nor denied by domain of cl@linux.com) smtp.mailfrom=cl@linux.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698724028; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rv3mvEtAQZcWA/zWJ6Zf5uD/n/90RT/CICIfI/Hbxts=; b=fb4immLUmBCbPgVnzXLP6vooMVQWX12tXDNRlhTkH5/57ISHNeeE0UXy7LsJUCAcdbI07p n+qDRX11fVzkwpraQMjHpOyPSAOgmApS0OVFxNYCQVVKuxRBsU983v/ueWjuuQIc8BjVYE MUvP/f3ahfZpp4pTy8gFVz8HTJgFW3g= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=linux.com (policy=none); spf=softfail (imf13.hostedemail.com: 62.72.0.81 is neither permitted nor denied by domain of cl@linux.com) smtp.mailfrom=cl@linux.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698724028; a=rsa-sha256; cv=none; b=cjF5vtiEgZT5hQY3v8YhINmDn6ngYejyVGiE3w02AuDHX6LLnxDBWMJ8BJnys/vLgM6ZBG 2jpVF8/+x6cJMyUw06QIUNlgAAZvwHCNK2VPNBkzyDXHb2+V+7OurkqrBI7KDTLh3Hlbk9 EeL6BCWxalxz3fiWR+kdD8Ut+eBnRWs= Received: by gentwo.org (Postfix, from userid 1003) id CC31648CA2; Mon, 30 Oct 2023 20:47:06 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id CABB3489FB; Mon, 30 Oct 2023 20:47:06 -0700 (PDT) Date: Mon, 30 Oct 2023 20:47:06 -0700 (PDT) From: Christoph Lameter To: Chengming Zhou cc: vbabka@suse.cz, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chengming Zhou Subject: Re: [RFC PATCH v3 0/7] slub: Delay freezing of CPU partial slabs In-Reply-To: <1dcc9969-da5b-4384-96d8-d03c835f198e@linux.dev> Message-ID: References: <20231024093345.3676493-1-chengming.zhou@linux.dev> <1199315b-63ce-4be4-8cde-b8b2fd29f91a@linux.dev> <7f70d130-c05a-3cb7-9509-41c21c3014fb@linux.com> <1dcc9969-da5b-4384-96d8-d03c835f198e@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Rspamd-Queue-Id: 5E4062000D X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: cp1nubj7g8bzz1y79415me9dinae7yey X-HE-Tag: 1698724028-405107 X-HE-Meta: U2FsdGVkX1+bflrZRhkE7ETbhDAKagg839Ds0Obpfov9Tjwd7hNJLEVK5ynLnoI0AnGGC6xENCtDP/pnOIkuwFFH7RhvwGMYQI5ZLW9SNTZQV52VY+7L8uOsb9kgRRiUY8CdYQNAethUnGX6WYpxeVVKdM7f3w/m3RX6P9KC860x++th1mQuFr6AJcnIWDqSrGI6dAlJG6V3jnEG0uSrlmX/o/5koM5WMY50J1XWepTOA9O3bJoQWoZknMuuVreMRaeryMpAKqR+UQstgryFn11QPEOZxoqFqZgkYMDAvx9vBrG9VPQhR0FOC7XqwvcZSDDq9A+xhiAbAA7ULmuphICamMe8XSwLA0rs0/IYzqsPP55uEnGOOSf6QFIX5sb7Xbvxz1YJlvdRuet+wRNlor844mmqYz71GUxCEwvqg0A4hz1nkVY8eYS48gDAT1ETIFFxr7OPYF8LgmUKTLqQoH6EdNIkMpPDMhEeeECLN/7zlHtReJYLUdFFYg+eaKvwToSE7CsJqFMqbSyYjSWqzWcNErc7c0//YwRLbGMk2Uo4MoWclcVhjcdqZM80a8k7Njp0JU9OesKfz20vOQFEwFjDLWcuMYPWpLydSBEGicosWypmU05xqobEzkz8WWXf0a/MFo3BBv9lNS7Ml6qoGjTS2puB6KGZ/iKkHSa6NRzeaJPU6wdzfvFBRcPbHgjOEFrtc7WrEp4AIboKlZXeuGOV/fnidtBgysG0jAzC/SufInkecCgrtbx3Jv/3f0cwWYjIqfbTtPbp2cqwgzkeCrU1ky26BqjhZmPWUy+qVm9RcaFSMPDx/TMDTZu0/u6QTo5RUzZCRtyWbISyvP98dRTIzZ5DVRV9h2RNhpUO+KO2yZoV3zCEmB5Si59TBRqN9+1qIqG46rZi/1W6N20SoZwMBc2NlPoWEOte2uK6CcyA2zOmUK54oHBHQJQpkCtMW0s2fImUYrAYltfetvC UB3lPsIF SZi+I0pMJhuvSLDinx7oDBVf6voNL34E5fYg06b/nUzzdF6kPopBzkrm3vJhJFHlSUFXMrHcPHT1KWIUTmjzuIh5DvQzTJvg4olEgBrECOeAMf9o3CrkA21fIn5zNN1+yHyxAEEp2QOQPlvY/30nIuM6ra8W29ydqXBcx9IRWgmrBlKRI9KZw7Il0c84vcd9Y4DeN6lF0sXyNrKY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 31 Oct 2023, Chengming Zhou wrote: > The current scheme (which this series implemented) is: > > - node partial slabs: PG_Workingset (set or clear with per-node list_lock protection) > - cpu partial slabs: !PG_Workingset And then the frozen flag needs to be set. Otherwise slab_free() would conclude it is on a partial list? > - cpu slabs: !PG_Workingset && frozen (set or clear using cmpxchg together with freelist) > - full slabs: !PG_Workingset And frozen is clear? Otherwise it is the same as a cpu partial slab. > As Vlastimil noted, it's possible to drop "frozen" bit for cpu slabs, but > we keep it for performance, since we don't need to grab node list_lock to > check whether PG_Workingset is set or not if the "frozen" bit is set. > > Thanks! >