Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B023AC38A2A for ; Fri, 8 May 2020 07:46:23 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83C282070B for ; Fri, 8 May 2020 07:46:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83C282070B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jWxhi-0002R6-Q9; Fri, 08 May 2020 07:45:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jWxhh-0002R1-2V for xen-devel@lists.xenproject.org; Fri, 08 May 2020 07:45:53 +0000 X-Inumbo-ID: f088047e-90ff-11ea-9fcd-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f088047e-90ff-11ea-9fcd-12813bfff9fa; Fri, 08 May 2020 07:45:52 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 72260AFCF; Fri, 8 May 2020 07:45:53 +0000 (UTC) Subject: Re: [PATCH v2 1/4] x86/mm: no-one passes a NULL domain to init_xen_l4_slots() To: Andrew Cooper References: <9d4b738a-4487-6bfc-3076-597d074c7b47@suse.com> <8787b72e-c71e-b75d-2ca0-0c6fe7c8259f@suse.com> <20200421164055.GW28601@Air-de-Roger> <4779dde6-6582-1776-ea9b-a2cd46ac3bc3@suse.com> From: Jan Beulich Message-ID: Date: Fri, 8 May 2020 09:45:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , Tim Deegan , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07.05.2020 19:26, Andrew Cooper wrote: > On 05/05/2020 07:31, Jan Beulich wrote: >> On 21.04.2020 18:40, Roger Pau Monné wrote: >>> On Tue, Apr 21, 2020 at 11:11:03AM +0200, Jan Beulich wrote: >>>> Drop the NULL checks - they've been introduced by commit 8d7b633ada >>>> ("x86/mm: Consolidate all Xen L4 slot writing into >>>> init_xen_l4_slots()") for no apparent reason. >>>> >>>> Signed-off-by: Jan Beulich >>> Reviewed-by: Roger Pau Monné >> you weren't entirely happy with the change because of the >> possible (or, as you state, necessary) need to undo this. I >> still think in the current shape the NULL checks are >> pointless and hence would better go away. Re-introducing them >> (adjusted to whatever shape the function may be in by that >> time) is not that big of a problem. May I ask that you >> explicitly clarify whether you actively NAK the patch, accept >> it going in with Roger's R-b, or would be willing to ack it? > > I'm not going to nack it, because that would be petty, but I still don't > think it is a useful use of your time to be making more work for someone > in the future to revert. > > However, if you wish to take the patch with Roger's R-b, then please fix > the stale commit message, seeing as this is v2 and I explained exactly > why it was done like that. Is "... without giving a reason; I'm told this was done in anticipation of the function potentially getting called with a NULL argument" any better? I don't think the commit message here was stale, as said commit indeed gives no explanation, yet all call sites pass non-NULL. Jan