Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35464C4338F for ; Wed, 11 Aug 2021 10:20:48 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85BED60D07 for ; Wed, 11 Aug 2021 10:20:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 85BED60D07 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rock-chips.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7ABA582DB6; Wed, 11 Aug 2021 12:20:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id D78FF82D7C; Wed, 11 Aug 2021 12:20:28 +0200 (CEST) Received: from regular1.263xmail.com (regular1.263xmail.com [211.150.70.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4318582D90 for ; Wed, 11 Aug 2021 12:20:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=kever.yang@rock-chips.com Received: from localhost (unknown [192.168.167.235]) by regular1.263xmail.com (Postfix) with ESMTP id 01C5F1F47 for ; Wed, 11 Aug 2021 18:20:07 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-SKE-CHECKED: 1 X-ABS-CHECKED: 1 X-ANTISPAM-LEVEL: 2 Received: from [192.168.60.65] (unknown [103.29.142.67]) by smtp.263.net (postfix) whith ESMTP id P25123T140690424059648S1628677201736136_; Wed, 11 Aug 2021 18:20:07 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: <9bd423ecfede5fd0b2945f474f8147f7> X-RL-SENDER: kever.yang@rock-chips.com X-SENDER: yk@rock-chips.com X-LOGIN-NAME: kever.yang@rock-chips.com X-FST-TO: macromorgan@hotmail.com X-RCPT-COUNT: 8 X-SENDER-IP: 103.29.142.67 X-ATTACHMENT-NUM: 0 X-System-Flag: 0 Subject: Re: [PATCH v7 5/6] rockchip: px30: add support for SFC for Odroid Go Advance To: Jon Lin , u-boot@lists.denx.de Cc: heiko.stuebner@theobroma-systems.com, vigneshr@ti.com, jagan@amarulasolutions.com, philipp.tomsich@vrull.eu, sjg@chromium.org, macromorgan@hotmail.com References: <20210805082643.3324-1-jon.lin@rock-chips.com> <20210805162301.v7.5.Id7d2651c4d3564a1c72eeef29a01f6575259009d@changeid> From: Kever Yang Message-ID: Date: Wed, 11 Aug 2021 18:20:00 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210805162301.v7.5.Id7d2651c4d3564a1c72eeef29a01f6575259009d@changeid> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 2021/8/5 下午4:27, Jon Lin wrote: > From: Chris Morgan > > The Odroid Go Advance uses a Rockchip Serial Flash Controller with an > XT25F128B SPI NOR flash chip. This adds support for both. Note that > while both the controller and chip support quad mode, only two lines > are connected to the chip. Changing the pinctrl to bus2 and setting tx > and rx lines to 2 for this reason. > > Signed-off-by: Chris Morgan > Signed-off-by: Jon Lin Reviewed-by: Kever Yang Thanks, - Kever > --- > > (no changes since v1) > > arch/arm/dts/rk3326-odroid-go2-u-boot.dtsi | 17 +++++++++++++++++ > arch/arm/dts/rk3326-odroid-go2.dts | 16 ++++++++++++++++ > 2 files changed, 33 insertions(+) > > diff --git a/arch/arm/dts/rk3326-odroid-go2-u-boot.dtsi b/arch/arm/dts/rk3326-odroid-go2-u-boot.dtsi > index 00767d2abd..741e8dd935 100644 > --- a/arch/arm/dts/rk3326-odroid-go2-u-boot.dtsi > +++ b/arch/arm/dts/rk3326-odroid-go2-u-boot.dtsi > @@ -7,6 +7,15 @@ > chosen { > u-boot,spl-boot-order = &sdmmc; > }; > + > + aliases { > + i2c0 = &i2c0; > + i2c1 = &i2c1; > + mmc0 = &sdmmc; > + serial1 = &uart1; > + serial2 = &uart2; > + spi0 = &sfc; > + }; > }; > > &cru { > @@ -57,6 +66,14 @@ > u-boot,spl-fifo-mode; > }; > > +&sfc { > + u-boot,dm-pre-reloc; > +}; > + > +&spi_flash { > + u-boot,dm-pre-reloc; > +}; > + > &uart1 { > clock-frequency = <24000000>; > u-boot,dm-pre-reloc; > diff --git a/arch/arm/dts/rk3326-odroid-go2.dts b/arch/arm/dts/rk3326-odroid-go2.dts > index 8cd4688c49..6f91f5040b 100644 > --- a/arch/arm/dts/rk3326-odroid-go2.dts > +++ b/arch/arm/dts/rk3326-odroid-go2.dts > @@ -617,6 +617,22 @@ > status = "okay"; > }; > > +&sfc { > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&sfc_clk &sfc_cs &sfc_bus2>; > + status = "okay"; > + > + spi_flash: xt25f128b@0 { > + compatible = "jedec,spi-nor"; > + reg = <0>; > + spi-max-frequency = <108000000>; > + spi-rx-bus-width = <2>; > + spi-tx-bus-width = <2>; > + }; > +}; > + > &tsadc { > status = "okay"; > };