From: "its_Giaan (Code Review)" Date: Thu, 6 Jun 2024 11:33:32 +0000 In-Reply-To: References: Reply-To: gianmarco@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., gert@...1296... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="XOfDmrzpWDs="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: test_user_pass: Fix building with --enable-systemd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: cron2 , flichtenheld , plaisthos Cc: openvpn-devel --XOfDmrzpWDs= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, its_Giaan, plaisthos. its_Giaan has uploaded a new patch set (#2) to the change originally create= d by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/641?usp=3Demail ) Change subject: test_user_pass: Fix building with --enable-systemd ...................................................................... test_user_pass: Fix building with --enable-systemd Need to make sure that ENABLE_SYSTEMD is really disabled. Change-Id: Ic33c210f06e173a450534aa0969c57f140086655 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Message-Id: <20240605111012.3023-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28= 708.html Signed-off-by: Gert Doering --- M tests/unit_tests/openvpn/test_user_pass.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/41/641/2 diff --git a/tests/unit_tests/openvpn/test_user_pass.c b/tests/unit_tests/o= penvpn/test_user_pass.c index ac84654..b43e655 100644 --- a/tests/unit_tests/openvpn/test_user_pass.c +++ b/tests/unit_tests/openvpn/test_user_pass.c @@ -27,6 +27,8 @@ #endif #undef ENABLE_SYSTEMD +/* avoid redefining ENABLE_SYSTEMD in misc.c */ +#undef HAVE_CONFIG_H #include "syshead.h" #include "manage.h" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/641?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic33c210f06e173a450534aa0969c57f140086655 Gerrit-Change-Number: 641 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: its_Giaan Gerrit-Attention: cron2 Gerrit-MessageType: newpatchset --XOfDmrzpWDs= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, its_Giaan, plaisthos.

its_Giaan uploaded patch set #2 to the change originall= y created by flichtenheld.

View Change

test_user_pass: Fix building with -=
-enable-systemd

Need to make sure that ENABLE_SYSTEMD is really disa= bled.

Change-Id: Ic33c210f06e173a450534aa0969c57f140086655
Signed= -off-by: Frank Lichtenheld <frank@...2641...>
Acked-by: Gert Doeri= ng <gert@...1296...>
Message-Id: <20240605111012.3023-1-gert@...1186...= .1296...>
URL: https://www.mail-archive.com/openvpn-devel@...1011...= eforge.net/msg28708.html
Signed-off-by: Gert Doering <gert@...1296...= >
---
M tests/unit_tests/openvpn/test_user_pass.c
1 file change= d, 2 insertions(+), 0 deletions(-)

git pull ssh://gerrit.openvpn.=
net:29418/openvpn refs/changes/41/641/2
diff --git a/tests/unit_tes=
ts/openvpn/test_user_pass.c b/tests/unit_tests/openvpn/test_user_pass.c
index ac84654..b43e655 100644
--- a/tests/unit= _tests/openvpn/test_user_pass.c
+++ b/tests/unit_tests/open= vpn/test_user_pass.c
@@ -27,6 +27,8 @@
#en= dif

#undef ENABLE_SYSTEMD
+/* avoid redefining ENABLE_SYSTEMD= in misc.c */

+#undef= HAVE_CONFIG_H

#include "syshead.h&= quot;
#include "manage.h"

To view, visit change 641. To unsubscribe, or for help writing mai= l filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ic33c210f06e173a450534aa0969= c57f140086655
Gerrit-Change-Number: 641
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: its_Giaan <gianmarco@...1665...= 726...>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-MessageType: newpatchset
--XOfDmrzpWDs=--