From: Tvrtko Ursulin Subject: Re: [PATCH v3] drm/i915: Use memcpy_from_wc for GPU error capture Date: Tue, 6 Dec 2016 13:29:35 +0000 Message-ID: References: <20161206122203.8954-1-chris@chris-wilson.co.uk> <20161206124051.17040-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 568C66E386 for ; Tue, 6 Dec 2016 13:29:38 +0000 (UTC) In-Reply-To: <20161206124051.17040-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA2LzEyLzIwMTYgMTI6NDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBhbGwgcGxhdGZv cm1zIHdlIG5vdyBhbHdheXMgcmVhZCB0aGUgY29udGVudHMgb2YgYnVmZmVycyB2aWEgdGhlIEdU VCwKPiBpLmUuIHVzaW5nIFdDIGNwdSBhY2Nlc3MuIFJlYWRzIGFyZSBzbG93LCBidXQgdGhleSBj YW4gYmUgYWNjZWxlcmF0ZWQKPiB3aXRoIGFuIGludGVybmFsIHJlYWQgYnVmZmVyIHVzaW5nIHNz ZTQuMSAobW92bnRxZGEpLiBUaGlzIGlzIG91cgo+IGk5MTVfbWVtY3B5X2Zyb21fd2MoKSByb3V0 aW5lIHdoaWNoIGFsc28gY2hlY2tzIGZvciBzc2U0LjEgc3VwcG9ydCBhbmQKPiBzbyB3ZSBjYW4g ZmFsbGJhY2sgdG8gdXNpbmcgYSByZWd1bGFyIHNsb3cgbWVtY3B5IGlmIHdlIG5lZWQgdG8uCj4K PiBXaGVuIGNvbXByZXNzaW5nIHRoZSBwYWdlcywgdGhlIHJlYWRzIGFyZSBjdXJyZW50bHkgZG9u ZSBpbnNpZGUgemxpYidzCj4gZmlsbF93aW5kb3coKSByb3V0aW5lIGFuZCBzbyB3ZSBtdXN0IGNv cHkgdGhlIHBhZ2UgaW50byBhIHRlbXBvcmFyeQo+IHdoaWNoIGlzIHRoZW4gYWxyZWFkeSBpbnNp ZGUgdGhlIENQVSBjYWNoZSBhbmQgZmFzdCBmb3IgemxpYidzCj4gY29tcHJlc3Npb24uIFdoZW4g bm90IGNvbXByZXNzaW5nIHRoZSBwYWdlcywgd2UgZG9uJ3QgbmVlZCBhIHRlbXBvcmFyeQo+IGFu ZCBjYW4ganVzdCB1c2UgdGhlIGFjY2VsZXJhdGVkIHJlYWQgZnJvbSBXQyBpbnRvIHRoZSBkZXN0 aW5hdGlvbi4KPgo+IHYyOiBVc2UgenN0cmVhbSBsb2NhbHMgdG8gcmVkdWNlIGRpZmYgYW5kIGFs bG9jYXRlIHRoZSBhZGRpdGlvbmFsCj4gdGVtcG9yYXJ5IHN0b3JhZ2Ugb25seSBpZiBzc2U0LjEg aXMgc3VwcG9ydGVkLgo+IHYzOiBVc2UgbGVuZ3RoPTAgZm9yIHRoZSBzc2U0LjEgc3VwcG9ydCBj aGVjawo+Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24u Y28udWs+Cj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBsaW51eC5pbnRlbC5j b20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3B1X2Vycm9yLmMgfCA1MCAr KysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMzcg aW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9ncHVfZXJyb3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z3B1X2Vycm9yLmMKPiBpbmRleCBhMTRmN2JhZGMzMzcuLjMwNzk5OWI4NTJmZCAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dwdV9lcnJvci5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9ncHVfZXJyb3IuYwo+IEBAIC0xNzYsOSArMTc2LDE0IEBAIHN0 YXRpYyB2b2lkIGk5MTVfZXJyb3JfcHV0cyhzdHJ1Y3QgZHJtX2k5MTVfZXJyb3Jfc3RhdGVfYnVm ICplLAo+Cj4gICNpZmRlZiBDT05GSUdfRFJNX0k5MTVfQ09NUFJFU1NfRVJST1IKPgo+IC1zdGF0 aWMgYm9vbCBjb21wcmVzc19pbml0KHN0cnVjdCB6X3N0cmVhbV9zICp6c3RyZWFtKQo+ICtzdHJ1 Y3QgY29tcHJlc3Mgewo+ICsJc3RydWN0IHpfc3RyZWFtX3MgenN0cmVhbTsKPiArCXZvaWQgKnRt cDsKPiArfTsKPiArCj4gK3N0YXRpYyBib29sIGNvbXByZXNzX2luaXQoc3RydWN0IGNvbXByZXNz ICpjKQo+ICB7Cj4gLQltZW1zZXQoenN0cmVhbSwgMCwgc2l6ZW9mKCp6c3RyZWFtKSk7Cj4gKwlz dHJ1Y3Qgel9zdHJlYW1fcyAqenN0cmVhbSA9IG1lbXNldCgmYy0+enN0cmVhbSwgMCwgc2l6ZW9m KGMtPnpzdHJlYW0pKTsKPgo+ICAJenN0cmVhbS0+d29ya3NwYWNlID0KPiAgCQlrbWFsbG9jKHps aWJfZGVmbGF0ZV93b3Jrc3BhY2VzaXplKE1BWF9XQklUUywgTUFYX01FTV9MRVZFTCksCj4gQEAg LTE5MSwxNCArMTk2LDIyIEBAIHN0YXRpYyBib29sIGNvbXByZXNzX2luaXQoc3RydWN0IHpfc3Ry ZWFtX3MgKnpzdHJlYW0pCj4gIAkJcmV0dXJuIGZhbHNlOwo+ICAJfQo+Cj4gKwljLT50bXAgPSBO VUxMOwo+ICsJaWYgKGk5MTVfbWVtY3B5X2Zyb21fd2MoTlVMTCwgMCwgMCkpCj4gKwkJYy0+dG1w ID0gKHZvaWQgKilfX2dldF9mcmVlX3BhZ2UoR0ZQX0FUT01JQyB8IF9fR0ZQX05PV0FSTik7Cj4g Kwo+ICAJcmV0dXJuIHRydWU7Cj4gIH0KPgo+IC1zdGF0aWMgaW50IGNvbXByZXNzX3BhZ2Uoc3Ry dWN0IHpfc3RyZWFtX3MgKnpzdHJlYW0sCj4gK3N0YXRpYyBpbnQgY29tcHJlc3NfcGFnZShzdHJ1 Y3QgY29tcHJlc3MgKmMsCj4gIAkJCSB2b2lkICpzcmMsCj4gIAkJCSBzdHJ1Y3QgZHJtX2k5MTVf ZXJyb3Jfb2JqZWN0ICpkc3QpCj4gIHsKPiArCXN0cnVjdCB6X3N0cmVhbV9zICp6c3RyZWFtID0g JmMtPnpzdHJlYW07Cj4gKwo+ICAJenN0cmVhbS0+bmV4dF9pbiA9IHNyYzsKPiArCWlmIChjLT50 bXAgJiYgaTkxNV9tZW1jcHlfZnJvbV93YyhjLT50bXAsIHNyYywgUEFHRV9TSVpFKSkKPiArCQl6 c3RyZWFtLT5uZXh0X2luID0gYy0+dG1wOwo+ICAJenN0cmVhbS0+YXZhaWxfaW4gPSBQQUdFX1NJ WkU7Cj4KPiAgCWRvIHsKPiBAQCAtMjI2LDkgKzIzOSwxMSBAQCBzdGF0aWMgaW50IGNvbXByZXNz X3BhZ2Uoc3RydWN0IHpfc3RyZWFtX3MgKnpzdHJlYW0sCj4gIAlyZXR1cm4gMDsKPiAgfQo+Cj4g LXN0YXRpYyB2b2lkIGNvbXByZXNzX2Zpbmkoc3RydWN0IHpfc3RyZWFtX3MgKnpzdHJlYW0sCj4g K3N0YXRpYyB2b2lkIGNvbXByZXNzX2Zpbmkoc3RydWN0IGNvbXByZXNzICpjLAo+ICAJCQkgIHN0 cnVjdCBkcm1faTkxNV9lcnJvcl9vYmplY3QgKmRzdCkKPiAgewo+ICsJc3RydWN0IHpfc3RyZWFt X3MgKnpzdHJlYW0gPSAmYy0+enN0cmVhbTsKPiArCj4gIAlpZiAoZHN0KSB7Cj4gIAkJemxpYl9k ZWZsYXRlKHpzdHJlYW0sIFpfRklOSVNIKTsKPiAgCQlkc3QtPnVudXNlZCA9IHpzdHJlYW0tPmF2 YWlsX291dDsKPiBAQCAtMjM2LDYgKzI1MSw5IEBAIHN0YXRpYyB2b2lkIGNvbXByZXNzX2Zpbmko c3RydWN0IHpfc3RyZWFtX3MgKnpzdHJlYW0sCj4KPiAgCXpsaWJfZGVmbGF0ZUVuZCh6c3RyZWFt KTsKPiAgCWtmcmVlKHpzdHJlYW0tPndvcmtzcGFjZSk7Cj4gKwo+ICsJaWYgKGMtPnRtcCkKPiAr CQlmcmVlX3BhZ2UoKHVuc2lnbmVkIGxvbmcpYy0+dG1wKTsKPiAgfQo+Cj4gIHN0YXRpYyB2b2lk IGVycl9jb21wcmVzc2lvbl9tYXJrZXIoc3RydWN0IGRybV9pOTE1X2Vycm9yX3N0YXRlX2J1ZiAq bSkKPiBAQCAtMjQ1LDI4ICsyNjMsMzQgQEAgc3RhdGljIHZvaWQgZXJyX2NvbXByZXNzaW9uX21h cmtlcihzdHJ1Y3QgZHJtX2k5MTVfZXJyb3Jfc3RhdGVfYnVmICptKQo+Cj4gICNlbHNlCj4KPiAt c3RhdGljIGJvb2wgY29tcHJlc3NfaW5pdChzdHJ1Y3Qgel9zdHJlYW1fcyAqenN0cmVhbSkKPiAr c3RydWN0IGNvbXByZXNzIHsKPiArfTsKPiArCj4gK3N0YXRpYyBib29sIGNvbXByZXNzX2luaXQo c3RydWN0IGNvbXByZXNzICpjKQo+ICB7Cj4gIAlyZXR1cm4gdHJ1ZTsKPiAgfQo+Cj4gLXN0YXRp YyBpbnQgY29tcHJlc3NfcGFnZShzdHJ1Y3Qgel9zdHJlYW1fcyAqenN0cmVhbSwKPiArc3RhdGlj IGludCBjb21wcmVzc19wYWdlKHN0cnVjdCBjb21wcmVzcyAqYywKPiAgCQkJIHZvaWQgKnNyYywK PiAgCQkJIHN0cnVjdCBkcm1faTkxNV9lcnJvcl9vYmplY3QgKmRzdCkKPiAgewo+ICAJdW5zaWdu ZWQgbG9uZyBwYWdlOwo+ICsJdm9pZCAqcHRyOwo+Cj4gIAlwYWdlID0gX19nZXRfZnJlZV9wYWdl KEdGUF9BVE9NSUMgfCBfX0dGUF9OT1dBUk4pOwo+ICAJaWYgKCFwYWdlKQo+ICAJCXJldHVybiAt RU5PTUVNOwo+Cj4gLQlkc3QtPnBhZ2VzW2RzdC0+cGFnZV9jb3VudCsrXSA9Cj4gLQkJbWVtY3B5 KCh2b2lkICopcGFnZSwgc3JjLCBQQUdFX1NJWkUpOwo+ICsJcHRyID0gKHZvaWQgKilwYWdlOwo+ ICsJaWYgKCFpOTE1X21lbWNweV9mcm9tX3djKHB0ciwgc3JjLCBQQUdFX1NJWkUpKQo+ICsJCW1l bWNweShwdHIsIHNyYywgUEFHRV9TSVpFKTsKPiArCWRzdC0+cGFnZXNbZHN0LT5wYWdlX2NvdW50 KytdID0gcHRyOwo+Cj4gIAlyZXR1cm4gMDsKPiAgfQo+Cj4gLXN0YXRpYyB2b2lkIGNvbXByZXNz X2Zpbmkoc3RydWN0IHpfc3RyZWFtX3MgKnpzdHJlYW0sCj4gK3N0YXRpYyB2b2lkIGNvbXByZXNz X2Zpbmkoc3RydWN0IGNvbXByZXNzICpjLAo+ICAJCQkgIHN0cnVjdCBkcm1faTkxNV9lcnJvcl9v YmplY3QgKmRzdCkKPiAgewo+ICB9Cj4gQEAgLTc4NCw3ICs4MDgsNyBAQCBpOTE1X2Vycm9yX29i amVjdF9jcmVhdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsCj4gIAlzdHJ1Y3QgaTkx NV9nZ3R0ICpnZ3R0ID0gJmk5MTUtPmdndHQ7Cj4gIAljb25zdCB1NjQgc2xvdCA9IGdndHQtPmVy cm9yX2NhcHR1cmUuc3RhcnQ7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfZXJyb3Jfb2JqZWN0ICpkc3Q7 Cj4gLQlzdHJ1Y3Qgel9zdHJlYW1fcyB6c3RyZWFtOwo+ICsJc3RydWN0IGNvbXByZXNzIGNvbXBy ZXNzOwo+ICAJdW5zaWduZWQgbG9uZyBudW1fcGFnZXM7Cj4gIAlzdHJ1Y3Qgc2d0X2l0ZXIgaXRl cjsKPiAgCWRtYV9hZGRyX3QgZG1hOwo+IEBAIC04MDQsNyArODI4LDcgQEAgaTkxNV9lcnJvcl9v YmplY3RfY3JlYXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LAo+ICAJZHN0LT5wYWdl X2NvdW50ID0gMDsKPiAgCWRzdC0+dW51c2VkID0gMDsKPgo+IC0JaWYgKCFjb21wcmVzc19pbml0 KCZ6c3RyZWFtKSkgewo+ICsJaWYgKCFjb21wcmVzc19pbml0KCZjb21wcmVzcykpIHsKPiAgCQlr ZnJlZShkc3QpOwo+ICAJCXJldHVybiBOVUxMOwo+ICAJfQo+IEBAIC04MTcsNyArODQxLDcgQEAg aTkxNV9lcnJvcl9vYmplY3RfY3JlYXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LAo+ ICAJCQkJICAgICAgIEk5MTVfQ0FDSEVfTk9ORSwgMCk7Cj4KPiAgCQlzID0gaW9fbWFwcGluZ19t YXBfYXRvbWljX3djKCZnZ3R0LT5tYXBwYWJsZSwgc2xvdCk7Cj4gLQkJcmV0ID0gY29tcHJlc3Nf cGFnZSgmenN0cmVhbSwgKHZvaWQgIF9fZm9yY2UgKilzLCBkc3QpOwo+ICsJCXJldCA9IGNvbXBy ZXNzX3BhZ2UoJmNvbXByZXNzLCAodm9pZCAgX19mb3JjZSAqKXMsIGRzdCk7Cj4gIAkJaW9fbWFw cGluZ191bm1hcF9hdG9taWMocyk7Cj4KPiAgCQlpZiAocmV0KQo+IEBAIC04MzIsNyArODU2LDcg QEAgaTkxNV9lcnJvcl9vYmplY3RfY3JlYXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1 LAo+ICAJZHN0ID0gTlVMTDsKPgo+ICBvdXQ6Cj4gLQljb21wcmVzc19maW5pKCZ6c3RyZWFtLCBk c3QpOwo+ICsJY29tcHJlc3NfZmluaSgmY29tcHJlc3MsIGRzdCk7Cj4gIAlnZ3R0LT5iYXNlLmNs ZWFyX3JhbmdlKCZnZ3R0LT5iYXNlLCBzbG90LCBQQUdFX1NJWkUpOwo+ICAJcmV0dXJuIGRzdDsK PiAgfQo+CgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVs LmNvbT4KClJlZ2FyZHMsCgpUdnJ0a28KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAo=