Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59AE9C2BA1E for ; Mon, 6 Apr 2020 16:07:30 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D685A24930 for ; Mon, 6 Apr 2020 16:07:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="DRu1qyN8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D685A24930 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 34CAA167C; Mon, 6 Apr 2020 18:06:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 34CAA167C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1586189248; bh=E2ZF6ePEb4ZuZka/H0BZRMmepuDSGAYc8dOFjjoErVg=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=DRu1qyN89PiZgFBaTfP2vbLOUI/JUgdmqKZVM9Ul+jh/rDEtIXRrM3VsGk1AHYznP EFpKbFKDAGpMev/TwiH+/pX1Wa2HdVBbH+MBeXzpM9wtqWzcvO/PG471uu+4NCy9mN 4y2C+U5unui5swbIYyXzu3Oigd+9RwkpQrTCGQEw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 05270F8015D; Mon, 6 Apr 2020 18:05:48 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8D690F8015D; Mon, 6 Apr 2020 18:05:42 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5AB79F800CC for ; Mon, 6 Apr 2020 18:05:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5AB79F800CC IronPort-SDR: IszRwbxzHnoT45Qlofc+LApK9dxVE5RZIAXZRpTIS1Dby1oFFDANs5VVLBtnJmCMQKaqFDUS4f on5rX3eHmaEg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2020 09:05:31 -0700 IronPort-SDR: uz3vHQb5nBj8PaopWVqGPmPAa7VzFYcvgVEZ1Nwf3Mb6qWt0SjZ7JOiKwHOQRhb25WEru3JSIG 8KoO6tsPTrSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,351,1580803200"; d="scan'208";a="361256308" Received: from mmarathe-mobl1.amr.corp.intel.com (HELO [10.212.38.219]) ([10.212.38.219]) by fmsmga001.fm.intel.com with ESMTP; 06 Apr 2020 09:05:31 -0700 Subject: Re: [PATCH] ASoC: Intel: haswell: Power transition refactor To: Cezary Rojewski , alsa-devel@alsa-project.org References: <20200330194520.13253-1-cezary.rojewski@intel.com> <293372ae-5270-a1d4-2577-04991c08e33f@intel.com> From: Pierre-Louis Bossart Message-ID: Date: Mon, 6 Apr 2020 10:02:50 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <293372ae-5270-a1d4-2577-04991c08e33f@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: vkoul@kernel.org, broonie@kernel.org, Ross Zwisler , lgirdwood@gmail.com, tiwai@suse.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 4/6/20 3:48 AM, Cezary Rojewski wrote: > On 2020-03-30 21:45, Cezary Rojewski wrote: >> Update D0 <-> D3 sequence to correctly transition hardware and DSP core >> from and to D3. On top of that, set SHIM registers to their recommended >> defaults during D0 and D3 proceduces as HW does not reset registers for >> us. >> >> Connected to: >> [alsa-devel][BUG] bdw-rt5650 DSP boot timeout >> https://mailman.alsa-project.org/pipermail/alsa-devel/2019-July/153098.html >> >> >> Github issue ticket reference: >> https://github.com/thesofproject/linux/pull/1842 >> >> Tested on: >> - BDW-Y RVP with rt286 >> - SAMUS with rt5677 >> >> Proposed solution (both in July 2019 and on github): >> 'Revert "ASoC: Intel: Work around to fix HW d3 potential crash issue"' >> is NAKed as it only covers the problem up and actually brings back the >> undefined behavior: some registers (e.g.: APLLSE) are describing LPT >> offsets rather than WPT ones. In consequence, during power-transitions >> driver issues incorrect writes and leaves the regs of interest alone. >> >> Existing patch - the non-revert - does not resolve the HW D3 issue at >> all as it ignores the recommended sequence and does not initialize >> hardware registers as expected. And thus, leaving things as are is also >> unacceptable. >> >> Signed-off-by: Cezary Rojewski >> --- > > Pierre, your thoughts on this? This has already been confirmed working. I don't have any specific knowledge on Broadwell to comment. I also haven't had time to test this patch, I was expecting Ross to provide his Tested-by tag?