Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E983BC2B9F4 for ; Thu, 17 Jun 2021 10:07:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A3E3A61185 for ; Thu, 17 Jun 2021 10:07:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3E3A61185 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 03B8B6E8D6; Thu, 17 Jun 2021 10:07:37 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0BC146E8D6; Thu, 17 Jun 2021 10:07:35 +0000 (UTC) IronPort-SDR: iP3uqxULu0vd8Nwh47IwzaxDC6yOIap6cUnzwOgVs7ZpQCJFB6MtGT1c0GAIbprWfYEpX/FzLr 7Zio126ShvMw== X-IronPort-AV: E=McAfee;i="6200,9189,10017"; a="186718326" X-IronPort-AV: E=Sophos;i="5.83,280,1616482800"; d="scan'208";a="186718326" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2021 03:07:35 -0700 IronPort-SDR: yv6V61+V0GiwDP6Y60tb+NhiQ3lS34yWi8CuEBGdk8gqSQCKUaeEPCF2HAIQnwwVwkSoqYkujF dTd5PDEz3ciQ== X-IronPort-AV: E=Sophos;i="5.83,280,1616482800"; d="scan'208";a="404892497" Received: from vanderss-mobl.ger.corp.intel.com (HELO [10.249.254.193]) ([10.249.254.193]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2021 03:07:34 -0700 Subject: Re: [PATCH] drm/i915: Perform execbuffer object locking as a separate step To: Ramalingam C References: <20210615113600.30660-1-thomas.hellstrom@linux.intel.com> <20210617095620.GA15664@intel.com> From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= Message-ID: Date: Thu, 17 Jun 2021 12:07:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210617095620.GA15664@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, matthew.auld@intel.com, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 6/17/21 11:56 AM, Ramalingam C wrote: > On 2021-06-15 at 13:36:00 +0200, Thomas Hellström wrote: >> To help avoid evicting already resident buffers from the batch we're >> processing, perform locking as a separate step. >> > Looks reasonable to me. > > Reviewed-by: Ramalingam C > > Thanks for reviewing! /Thomas