From: "cron2 (Code Review)"
Date: Mon, 27 Jan 2025 11:30:31 +0000
In-Reply-To:
References:
Reply-To: gert@...1296..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="//+hguM3/xM="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: Print
warnings/errors when numerical parameters cannot be parsed
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: plaisthos
Cc: flichtenheld , openvpn-devel
--//+hguM3/xM=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos.
cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/873?usp=3Demail )
Change subject: Print warnings/errors when numerical parameters cannot be p=
arsed
......................................................................
Patch Set 6: Code-Review+2
(2 comments)
Patchset:
PS6:
fine with me, passes all my tests and stare-at-code finds no more mis-index=
es.
File src/openvpn/options.c:
http://gerrit.openvpn.net/c/openvpn/+/873/comment/c3edb0c3_b04a8431 :
PS5, Line 7643: virtual =3D atoi_warn(p[1], msglevel);
> wrong array element
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/873?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie1e2eb54d516b3ae87c5ca56fe8edd77ee2be4de
Gerrit-Change-Number: 873
Gerrit-PatchSet: 6
Gerrit-Owner: plaisthos
Gerrit-Reviewer: cron2
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Comment-Date: Mon, 27 Jan 2025 11:30:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: cron2
Gerrit-MessageType: comment
--//+hguM3/xM=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos.
Patch set 6:Code-Review +2=
Vi=
ew Change
2 comments:
Done
To=
view, visit change 873. To unsubscribe, or for help writing mail filters, visit=
settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie1e2eb54d516b3ae87c5ca56fe8=
edd77ee2be4de
Gerrit-Change-Number: 873
Gerrit-PatchSet: 6
Gerrit-Owner: plaisthos <arne-openvpn@...1711...=
27...>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Comment-Date: Mon, 27 Jan 2025 11:30:31=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: cron2 <gert@...1296...=
>
Gerrit-MessageType: comment
--//+hguM3/xM=--