From: "ordex (Code Review)" Date: Tue, 21 Apr 2026 14:57:45 +0000 In-Reply-To: References: Reply-To: antonio@...2726..., arne-openvpn@...1227..., gianmarco@...2726..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="il4s5GELyvQ="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Multisocket: use event engine rwflags for UDP I/O List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: its_Giaan Cc: plaisthos , openvpn-devel --il4s5GELyvQ= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: its_Giaan, plaisthos. ordex has posted comments on this change by its_Giaan. ( http://gerrit.open= vpn.net/c/openvpn/+/1635?usp=3Demail ) Change subject: Multisocket: use event engine rwflags for UDP I/O ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/1635/comment/4b1334a4_3f3cffbb?usp=3D= email : PS1, Line 341: const unsigned int status =3D rwflags; I think we can remove `status` and directly use `rwflags` throughout the fu= nction body? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1635?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6b303805a3688b6f6363140c76853a58badecd8f Gerrit-Change-Number: 1635 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan Gerrit-Reviewer: ordex Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: its_Giaan Gerrit-Comment-Date: Tue, 21 Apr 2026 14:57:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes --il4s5GELyvQ= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: its_Giaan, plaisthos.

Patch set 1:Code-Review -1=

V= iew Change

1 comment:

  • File src/openvpn/mudp.c:

  • Patch Set #1= , Line 341: const u= nsigned int status =3D rwflags;

    I think we can remove `status` a= nd directly use `rwflags` throughout the function body?

<= /ul>

To view, visit change 1635. To unsubscribe, or for help writing mail fil= ters, visit sett= ings.

<= link itemprop=3D"url" href=3D"http://gerrit.openvpn.net/c/openvpn/+/1635?us= p=3Demail"/>
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6b303805a3688b6f6363140c768= 53a58badecd8f
Gerrit-Change-Number: 1635
Gerrit-PatchSet: 1
Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
Gerrit-Reviewer: ordex <antonio@...2726...&= gt;
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: its_Giaan <gianmarco@...1665...= 726...>
Gerrit-Comment-Date: Tue, 21 Apr 2026 14:57:45= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
= --il4s5GELyvQ=--