Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCA63C7EE43 for ; Mon, 12 Jun 2023 09:23:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A61C28206E; Mon, 12 Jun 2023 11:23:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1686561795; bh=JJ86zkS2Cj6HhL1IzDfTKRVyvCWabZSKDNYw1X2dat8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=XCvtXsXoWb5/Elnyh80dYKFhJNvIOmNnEnPzF2LbnxmjiGFiV+qhvpxngupNSjZk0 R7rKDY+IjvcvF6Vf02/3T5ISabckzrnEaLK7I7gevfOd4xSbfvCns6cRbgmItdBv9Q FCWtA1NPHmEWmjWyTS8vpxst67YRiquOeR5J9DDvh5RTCowvUOYBs28x5GF3Jg9tUO 1rQnOHbyYVeElPl/UuPg3nz/rgb3s6dpt3/4pddTke9do7ASdIVVWA5UUQ8up9pzrX dgpw2Ch1Yn73ixOXZJYbZFN68o+urjnN6igUxjCQAGYiCI3gnBgVldX3HVV0OdguGw tbNFhmPqwEUww== Received: by phobos.denx.de (Postfix, from userid 109) id 8C38F846F9; Mon, 12 Jun 2023 11:23:13 +0200 (CEST) Received: from mout-u-107.mailbox.org (mout-u-107.mailbox.org [80.241.59.207]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1F5DE80F53 for ; Mon, 12 Jun 2023 11:23:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-107.mailbox.org (Postfix) with ESMTPS id 4QfmSY0tSJz9sRj; Mon, 12 Jun 2023 11:23:09 +0200 (CEST) Message-ID: Date: Mon, 12 Jun 2023 11:23:08 +0200 MIME-Version: 1.0 Subject: Re: [PATCH] arm: mvebu: Clean up Thecus N2350 board DTS Content-Language: en-US To: Tony Dinh , U-Boot Mailing List Cc: =?UTF-8?B?UGFsaSBSb2jvv71y?= , Tom Rini References: <20230606214539.4229-1-mibodhi@gmail.com> From: Stefan Roese In-Reply-To: <20230606214539.4229-1-mibodhi@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 6/6/23 23:45, Tony Dinh wrote: > - Update the Thecus N2350 DTS to conform with latest device-tree binding > and styles. > - Correct typo in mdio node. > > Signed-off-by: Tony Dinh Reviewed-by: Stefan Roese Thanks, Stefan > --- > > arch/arm/dts/armada-385-thecus-n2350.dts | 210 +++++++++++------------ > 1 file changed, 98 insertions(+), 112 deletions(-) > > diff --git a/arch/arm/dts/armada-385-thecus-n2350.dts b/arch/arm/dts/armada-385-thecus-n2350.dts > index fc29c4d25a..2ad5158c0c 100644 > --- a/arch/arm/dts/armada-385-thecus-n2350.dts > +++ b/arch/arm/dts/armada-385-thecus-n2350.dts > @@ -23,7 +23,7 @@ > stdout-path = "serial0:115200n8"; > }; > > - memory { > + memory@0 { > device_type = "memory"; > reg = <0x00000000 0x40000000>; /* 1GB */ > }; > @@ -37,43 +37,43 @@ > > }; > > - usb3_0_phy: usb3_0_phy { > + usb3_0_phy: usb-phy { > compatible = "usb-nop-xceiv"; > vcc-supply = <&usb3_0_power>; > + #phy-cells = <0>; > }; > > - usb3_1_phy: usb3_1_phy { > + usb3_1_phy: usb-phy { > compatible = "usb-nop-xceiv"; > vcc-supply = <&usb3_1_power>; > + #phy-cells = <0>; > }; > > - gpio-keys { > + keys { > compatible = "gpio-keys"; > - #address-cells = <1>; > - #size-cells = <0>; > pinctrl-0 = <&pmx_power_button &pmx_copy_button &pmx_reset_button>; > pinctrl-names = "default"; > > - button@1 { > + button-1 { > label = "Power Button"; > linux,code = ; > gpios = <&gpio1 17 GPIO_ACTIVE_HIGH>; > }; > > - button@2 { > + button-2 { > label = "Copy Button"; > linux,code = ; > gpios = <&gpio1 20 GPIO_ACTIVE_HIGH>; > }; > > - button@3 { > + button-3 { > label = "Reset Button"; > linux,code = ; > gpios = <&gpio1 18 GPIO_ACTIVE_HIGH>; > }; > }; > > - gpio-leds { > + leds { > compatible = "gpio-leds"; > pinctrl-0 = <&pmx_sata1_white_led > &pmx_sata1_red_led > @@ -88,142 +88,132 @@ > > pinctrl-names = "default"; > > - white_sata1 { > + led-1 { > label = "n2350:white:sata1"; > gpios = <&gpio0 20 GPIO_ACTIVE_HIGH>; > - linux,default-trigger = "ide-disk1"; > }; > > - red_sata1 { > + led-2 { > label = "n2350:red:sata1"; > gpios = <&gpio1 14 GPIO_ACTIVE_HIGH>; > }; > > - white-sata2 { > + led-3 { > label = "n2350:white:sata2"; > gpios = <&gpio0 19 GPIO_ACTIVE_HIGH>; > }; > > - red-sata2 { > + led-4 { > label = "n2350:red:sata2"; > gpios = <&gpio1 15 GPIO_ACTIVE_HIGH>; > }; > > - white-sys { > + led-5 { > label = "n2350:white:sys"; > gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "default-on"; > }; > > - red-sys { > + led-6 { > label = "n2350:red:sys"; > gpios = <&gpio0 15 GPIO_ACTIVE_HIGH>; > }; > > - blue-pwr { > + led-7 { > label = "n2350:blue:pwr"; > gpios = <&gpio1 11 GPIO_ACTIVE_HIGH>; > }; > > - red-pwr { > + led-8 { > label = "n2350:red:pwr"; > gpios = <&gpio0 18 GPIO_ACTIVE_HIGH>; > }; > > - white-usb { > + led-9 { > label = "n2350:white:usb"; > gpios = <&gpio0 16 GPIO_ACTIVE_HIGH>; > }; > > - red-usb { > + led-10 { > label = "n2350:red:usb"; > gpios = <&gpio0 17 GPIO_ACTIVE_HIGH>; > }; > }; > > - regulators { > - compatible = "simple-bus"; > - #address-cells = <1>; > - #size-cells = <0>; > - > - usb3_0_power: regulator@1 { > - compatible = "regulator-fixed"; > - reg = <1>; > - regulator-name = "USB3_0_Power"; > - regulator-min-microvolt = <5000000>; > - regulator-max-microvolt = <5000000>; > - enable-active-high; > - regulator-always-on; > - regulator-boot-on; > - gpio = <&gpio0 21 GPIO_ACTIVE_HIGH>; > - }; > - > - usb3_1_power: regulator@2 { > - compatible = "regulator-fixed"; > - reg = <1>; > - regulator-name = "USB3_1_Power"; > - regulator-min-microvolt = <5000000>; > - regulator-max-microvolt = <5000000>; > - enable-active-high; > - regulator-always-on; > - regulator-boot-on; > - gpio = <&gpio0 24 GPIO_ACTIVE_HIGH>; > - }; > + usb3_0_power: v5-vbus0 { > + compatible = "regulator-fixed"; > + regulator-name = "USB3_0_Power"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + enable-active-high; > + regulator-always-on; > + regulator-boot-on; > + gpio = <&gpio0 21 GPIO_ACTIVE_HIGH>; > + }; > > - reg_sata0: regulator@3 { > - compatible = "regulator-fixed"; > - regulator-name = "pwr_en_sata0"; > - regulator-min-microvolt = <12000000>; > - regulator-max-microvolt = <12000000>; > - enable-active-high; > - regulator-always-on; > - regulator-boot-on; > - gpio = <&gpio1 12 GPIO_ACTIVE_HIGH>; > - }; > + usb3_1_power: v5-vbus1 { > + compatible = "regulator-fixed"; > + regulator-name = "USB3_1_Power"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + enable-active-high; > + regulator-always-on; > + regulator-boot-on; > + gpio = <&gpio0 24 GPIO_ACTIVE_HIGH>; > + }; > > - reg_5v_sata0: v5-sata0 { > - compatible = "regulator-fixed"; > - regulator-name = "v5.0-sata0"; > - regulator-min-microvolt = <5000000>; > - regulator-max-microvolt = <5000000>; > - vin-supply = <®_sata0>; > - }; > + reg_sata0: pwr-sata0 { > + compatible = "regulator-fixed"; > + regulator-name = "pwr_en_sata0"; > + regulator-min-microvolt = <12000000>; > + regulator-max-microvolt = <12000000>; > + enable-active-high; > + regulator-always-on; > + regulator-boot-on; > + gpio = <&gpio1 12 GPIO_ACTIVE_HIGH>; > + }; > > - reg_12v_sata0: v12-sata0 { > - compatible = "regulator-fixed"; > - regulator-name = "v12.0-sata0"; > - regulator-min-microvolt = <12000000>; > - regulator-max-microvolt = <12000000>; > - vin-supply = <®_sata0>; > - }; > + reg_5v_sata0: v5-sata0 { > + compatible = "regulator-fixed"; > + regulator-name = "v5.0-sata0"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + vin-supply = <®_sata0>; > + }; > > - reg_sata1: regulator@4 { > - regulator-name = "pwr_en_sata1"; > - compatible = "regulator-fixed"; > - regulator-min-microvolt = <12000000>; > - regulator-max-microvolt = <12000000>; > - enable-active-high; > - regulator-always-on; > - regulator-boot-on; > - gpio = <&gpio1 13 GPIO_ACTIVE_HIGH>; > - }; > + reg_12v_sata0: v12-sata0 { > + compatible = "regulator-fixed"; > + regulator-name = "v12.0-sata0"; > + regulator-min-microvolt = <12000000>; > + regulator-max-microvolt = <12000000>; > + vin-supply = <®_sata0>; > + }; > > - reg_5v_sata1: v5-sata1 { > - compatible = "regulator-fixed"; > - regulator-name = "v5.0-sata1"; > - regulator-min-microvolt = <5000000>; > - regulator-max-microvolt = <5000000>; > - vin-supply = <®_sata1>; > - }; > + reg_sata1: pwr-sata0 { > + regulator-name = "pwr_en_sata1"; > + compatible = "regulator-fixed"; > + regulator-min-microvolt = <12000000>; > + regulator-max-microvolt = <12000000>; > + enable-active-high; > + regulator-always-on; > + regulator-boot-on; > + gpio = <&gpio1 13 GPIO_ACTIVE_HIGH>; > + }; > > - reg_12v_sata1: v12-sata1 { > - compatible = "regulator-fixed"; > - regulator-name = "v12.0-sata1"; > - regulator-min-microvolt = <12000000>; > - regulator-max-microvolt = <12000000>; > - vin-supply = <®_sata1>; > - }; > + reg_5v_sata1: v5-sata1 { > + compatible = "regulator-fixed"; > + regulator-name = "v5.0-sata1"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + vin-supply = <®_sata1>; > + }; > > + reg_12v_sata1: v12-sata1 { > + compatible = "regulator-fixed"; > + regulator-name = "v12.0-sata1"; > + regulator-min-microvolt = <12000000>; > + regulator-max-microvolt = <12000000>; > + vin-supply = <®_sata1>; > }; > > gpio-poweroff { > @@ -267,7 +257,7 @@ > }; > > &mdio { > - phy0: ethernet-phy@0 { > + phy0: ethernet-phy@1 { > reg = <1>; > }; > }; > @@ -301,18 +291,14 @@ > > &pciec { > status = "okay"; > - /* > - * The two PCIe units are accessible through > - * standard PCIe slots on the board. > - */ > - pcie@1,0 { > - /* Port 0, Lane 0 */ > - status = "okay"; > - }; > - pcie@2,0 { > - /* Port 1, Lane 0 */ > - status = "okay"; > - }; > +}; > + > +&pcie1 { > + status = "okay"; > +}; > + > +&pcie2 { > + status = "okay"; > }; > > &pinctrl { > @@ -408,10 +394,10 @@ > status = "okay"; > > /* spi: 4M Flash Macronix MX25L3205D */ > - spi-flash@0 { > + flash@0 { > #address-cells = <1>; > #size-cells = <0>; > - compatible = "macronix,mx25l3205d", "jedec,spi-nor"; > + compatible = "jedec,spi-nor"; > reg = <0>; > > spi-max-frequency = <108000000>; Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de