From: "flichtenheld (Code Review)"
Date: Wed, 16 Apr 2025 11:47:43 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, antonio@...2726...
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="AdtAq7s96qk="; charset=UTF-8
Subject: [Openvpn-devel] [XL] Change in openvpn[master]: Reformat the whole
project with clang-format
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: plaisthos , openvpn-devel
--AdtAq7s96qk=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: ordex, plaisthos.
flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne=
t/c/openvpn/+/791?usp=3Demail )
Change subject: Reformat the whole project with clang-format
......................................................................
Patch Set 14:
(6 comments)
File sample/sample-plugins/client-connect/sample-client-connect.c:
http://gerrit.openvpn.net/c/openvpn/+/791/comment/1bf6c87b_4e6169ab :
PS14, Line 135: stderr,
> this hurts me a bit, for two reasons: [=E2=80=A6]
Not quite sure why it doesn't align to "(", it does for almost all other oc=
curences. I think it might have a trade-off here between trying to align an=
d trying to get the string in the colum limit.
http://gerrit.openvpn.net/c/openvpn/+/791/comment/4cf494a4_79f7b8ce :
PS14, Line 251: MODULE,
> same as above, I expected MODULE to be on the line above [=E2=80=A6]
So basically what you want is "BinPackArguments: true", will apply that.
http://gerrit.openvpn.net/c/openvpn/+/791/comment/d9dba330_b8c72914 :
PS14, Line 252: "env has UV_WANT_CC_ASYNC=3D%d, but "
> here there is a more generic question to answer: do we want to keep strin=
g on the same line, even if [=E2=80=A6]
Has nothing to do with this patch though, AFAICT
File sample/sample-plugins/defer/multi-auth.c:
http://gerrit.openvpn.net/c/openvpn/+/791/comment/8b72fd16_d619cd73 :
PS14, Line 294: const char *envp[])
> ratio behind this change? one arg per line?
yes. This is BinPackParameters. Do you also want that set to "true"?
http://gerrit.openvpn.net/c/openvpn/+/791/comment/d94e4661_457ff043 :
PS14, Line 418: plog(context, PLOG_NOTE, "FUNC: openvpn_plugin_client_c=
onstructor_v1");
> how about forcing a new line after variables declaration?
Doesn't seem to be supported. There is a feature request for it: https://gi=
thub.com/llvm/llvm-project/issues/97303
File sample/sample-plugins/log/log_v3.c:
http://gerrit.openvpn.net/c/openvpn/+/791/comment/c9c800e4_6ecdeccd :
PS14, Line 87: "log_v3: ** ERROR ** Incompatible plug-in interf=
ace between this plug-in and OpenVPN\n");
> this is probably another instance of the same situation as before.
yes
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/791?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2566ad493629e1f5fdfa6f6483b8973463404e3e
Gerrit-Change-Number: 791
Gerrit-PatchSet: 14
Gerrit-Owner: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-CC: ordex
Gerrit-Attention: plaisthos
Gerrit-Attention: ordex
Gerrit-Comment-Date: Wed, 16 Apr 2025 11:47:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ordex
Gerrit-MessageType: comment
--AdtAq7s96qk=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: ordex, plaisthos.
View C=
hange
6 comments:
Not quite sure why it doesn't align to =
"(", it does for almost all other occurences. I think it might ha=
ve a trade-off here between trying to align and trying to get the string in=
the colum limit.
Patch Set #14, Line 251: MODULE,
<=
p>same as above, I expected MODULE to be on the line above [=E2=80=
=A6]
So basically what you want is "BinPackArguments: true", will=
apply that.
Patch Set #14, Line 252: "env has UV_WANT_CC=
_ASYNC=3D%d, but "
here there is a more generic =
question to answer: do we want to keep string on the same line, even if [=
=E2=80=A6]
Has nothing to do with this patch though, AFAICT
=
li>File sample/sample-plugins/defer=
/multi-auth.c:
Pa=
tch Set #14, Line 294: =
const char *envp[])
ratio behin=
d this change? one arg per line?
yes. This is BinPackParameters. Do you als=
o want that set to "true"?
Patch Set #14, Line 4=
18: plog(context, P=
LOG_NOTE, "FUNC: openvpn_plugin_client_constructor_v1");=
p>
how about forcing a new line after variables declaration?Doe=
sn't seem to be supported. There is a feature request for it: https://g=
ithub.com/llvm/llvm-project/issues/97303
File sample/sample-plugins/log/log_v3.c:
To view, visit change 791. =
To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2566ad493629e1f5fdfa6f6483b=
8973463404e3e
Gerrit-Change-Number: 791
Gerrit-PatchSet: 14
Gerrit-Owner: flichtenheld <frank@...2723...=
.>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-CC: ordex <antonio@...2726...> =
div>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: ordex <antonio@...2726...=
>
Gerrit-Comment-Date: Wed, 16 Apr 2025 11:47:43=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ordex <antonio@...2787...=
...>
Gerrit-MessageType: comment
--AdtAq7s96qk=--