Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAE542C684; Fri, 5 Jan 2024 10:46:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from [192.168.1.104] (178.176.73.147) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Fri, 5 Jan 2024 13:46:33 +0300 Subject: Re: [PATCH net] MAINTAINERS: I don't want to review Renesas Ethernet Switch driver To: Yoshihiro Shimoda , Simon Horman CC: "netdev@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" References: <6498e2dd-7960-daeb-acce-a8d2207f3404@omp.ru> <20240103212822.GA48301@kernel.org> <8f9b5376-647a-7b59-886c-142990b8c9e4@omp.ru> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Fri, 5 Jan 2024 13:46:32 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 01/05/2024 10:35:16 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 182464 [Jan 04 2024] X-KSE-AntiSpam-Info: Version: 6.1.0.3 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 7 0.3.7 6d6bf5bd8eea7373134f756a2fd73e9456bb7d1a X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 178.176.73.147 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: {Found in DNSBL: 178.176.73.147 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: 127.0.0.199:7.1.2;omp.ru:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;178.176.73.147:7.1.2 X-KSE-AntiSpam-Info: ApMailHostAddress: 178.176.73.147 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 01/05/2024 10:40:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 1/5/2024 9:01:00 AM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit On 1/5/24 5:42 AM, Yoshihiro Shimoda wrote: [...] >>>> I don't know this hardware, I don't have the manuals for it, so I can't >>>> provide a good review. Let's exclude the Ethernet Switch related files. >>>> >>>> Signed-off-by: Sergey Shtylyov >>> >>> Hi Sergey, >> >> Hi Simon, long time, no see... :-) >> >>> I don't know the back story to this, if there is one. >> >> Not much of a history: I got a lot of the rswitch patches in my >> inbox and I mostly ignored them... but kept deferring this patch due >> to a high load with fixing Svace's reports at work... >> >>> But could I suggest that: >>> >>> 1. The patch also updates the title MAINTAINERS section to cover the >>> remaining two drivers. >>> >>> e.g.: RENESAS ETHERNET DRIVERS -> >>> RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS >>> >>> Or alternatively, create separate sections for each driver. >> >> Yeah, this 2nd option seems cleaner. Still not sure about Kconfig/ >> Makefile though... > > How about adding "COMMON PARTS" section? > > - RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS : For ravb and sh_eth > - RENESAS ETHERNET DRIVERS (COMMON PARTS) : For Kconfig/Makefile in drivers/net/ethernet/renesas > - RENESAS ETHERNET SWITCH DRIVER : For rswitch No, this seems too much for these poor little couple files. :-) Listing them in each new MAINTAINERS entry should achieve the same goal and seems a biut cleaner... >>> n.b.: This may involve moving sections to maintain alphabetical order >>> by section title >>> >>> 2. Reaching out to Shimoda-san (CCed) or other relevant parties >>> to see if an appropriate maintainer or maintainers for the >>> Renesas Ethernet Switch driver can be found. > > I'm happy if I'm a maintainer for Renesas Ethernet Switch driver. Do you want to be a maintainer or just a reviewer (like me)? > So, if my idea above is acceptable, perhaps the maintainers can be: > > - RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS : Sergey There will be separate entries for those... > - RENESAS ETHERNET DRIVERS (COMMON PARTS) : Sergey and Shimoda I'd like to avoid that... :-) > - RENESAS ETHERNET SWITCH DRIVER : Shimoda >>> n.b.: It may still be a holiday period in Japan for the rest of the week. >> >> It's a holiday period here in Russia as well, till the 8th of Jaunary. :-) > > I'm back from today, but next Monday (8th) is a holiday in Japan :) You're back for 1 day? :-) > Best regards, > Yoshihiro Shimoda > >>> 3. Rephrase the subject and patch description as splitting out maintenance of >>> the Renesas Ethernet Switch driver . The question that remains still unaddressed: should I do the MAINTAINERS "directory split" with a single patch? [...] MBR, Sergey