Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7EAAC47089 for ; Thu, 27 May 2021 06:21:16 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0121D613DA for ; Thu, 27 May 2021 06:21:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0121D613DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 51F7482EBA; Thu, 27 May 2021 08:21:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1622096474; bh=eWFcjht60YliquRRdyXmNOfNYrxHvCN2xA7RyO/BDvU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=UkGck7pMpoxGdjkz0mQ+bPtbhs+GZP7Q1Qw8eMue/pcWug38+cBdxjJl6XligHwyd lk51zt/+aW/JLMafttskw4Sk1BoYvzNVQOe5dngThbuyMUvzTsTB0g0RiV2z7mXJLL wk2h4ITaKdfIbL1K24e1GT8rEP4U93sK+53g/h1YC6TRgdQXCRFKMXlqu1B5ukA1yO RdrOb49ziR+kDzeEDxI0WPiIdx0KNOczi6qurxmpvpKjMzJYwbiZRFfbuTtzO0G5IG r0rmcJlZ+pO9c+8Fcc12mMah9yOoWXZQC22GenP0iLGzC2cLaj3Ml8c8t9NBAJa4wC 8afKUMnadOuHg== Received: by phobos.denx.de (Postfix, from userid 109) id 3F92A82EDB; Thu, 27 May 2021 08:21:13 +0200 (CEST) Received: from mout-u-107.mailbox.org (mout-u-107.mailbox.org [IPv6:2001:67c:2050:1::465:107]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C946582E7B for ; Thu, 27 May 2021 08:21:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-107.mailbox.org (Postfix) with ESMTPS id 4FrHkt4YkGzQjBM; Thu, 27 May 2021 08:21:10 +0200 (CEST) Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter05.heinlein-hosting.de (spamfilter05.heinlein-hosting.de [80.241.56.123]) (amavisd-new, port 10030) with ESMTP id 0sBCoRTInHCZ; Thu, 27 May 2021 08:21:07 +0200 (CEST) Subject: Re: [PATCH v2 4/7] arm: a37xx: pci: Find PCIe controller node by compatible instead of path To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Konstantin Porotchkin Cc: =?UTF-8?Q?Marek_Beh=c3=ban?= , u-boot@lists.denx.de References: <20210517063956.30905-1-pali@kernel.org> <20210526155940.26141-1-pali@kernel.org> <20210526155940.26141-4-pali@kernel.org> From: Stefan Roese Message-ID: Date: Thu, 27 May 2021 08:21:06 +0200 MIME-Version: 1.0 In-Reply-To: <20210526155940.26141-4-pali@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit X-MBO-SPAM-Probability: X-Rspamd-Score: -6.68 / 15.00 / 15.00 X-Rspamd-Queue-Id: ACF471887 X-Rspamd-UID: d3a32b X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean On 26.05.21 17:59, Pali Rohár wrote: > Find PCIe DT node by compatible string instead of retrieving it by using > hardcoded DT path. > > Signed-off-by: Pali Rohár > Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan > --- > arch/arm/mach-mvebu/armada3700/cpu.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/arm/mach-mvebu/armada3700/cpu.c b/arch/arm/mach-mvebu/armada3700/cpu.c > index 0cf60d7cdd7d..1abac7c9a47a 100644 > --- a/arch/arm/mach-mvebu/armada3700/cpu.c > +++ b/arch/arm/mach-mvebu/armada3700/cpu.c > @@ -53,8 +53,6 @@ > #define A3700_PTE_BLOCK_DEVICE \ > (PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) | PTE_BLOCK_NON_SHARE) > > -#define PCIE_PATH "/soc/pcie@d0070000" > - > DECLARE_GLOBAL_DATA_PTR; > > static struct mm_region mvebu_mem_map[MAX_MEM_MAP_REGIONS] = { > @@ -288,7 +286,7 @@ int a3700_fdt_fix_pcie_regions(void *blob) > const u32 *ranges; > int node, len; > > - node = fdt_path_offset(blob, PCIE_PATH); > + node = fdt_node_offset_by_compatible(blob, -1, "marvell,armada-3700-pcie"); > if (node < 0) > return node; > > Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de