Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D211C3DA61 for ; Wed, 24 Jul 2024 11:32:47 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.764125.1174456 (Exim 4.92) (envelope-from ) id 1sWaEV-00086b-A0; Wed, 24 Jul 2024 11:32:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 764125.1174456; Wed, 24 Jul 2024 11:32:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sWaEV-00086U-6U; Wed, 24 Jul 2024 11:32:35 +0000 Received: by outflank-mailman (input) for mailman id 764125; Wed, 24 Jul 2024 11:32:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sWaEU-00086O-Gu for xen-devel@lists.xenproject.org; Wed, 24 Jul 2024 11:32:34 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6b26e532-49b0-11ef-bbfe-fd08da9f4363; Wed, 24 Jul 2024 13:32:33 +0200 (CEST) Received: from [10.176.0.4] (unknown [160.78.253.149]) by support.bugseng.com (Postfix) with ESMTPSA id 44BF94EE0738; Wed, 24 Jul 2024 13:32:32 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b26e532-49b0-11ef-bbfe-fd08da9f4363 Message-ID: Date: Wed, 24 Jul 2024 13:32:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [XEN PATCH v4 1/9] automation/eclair: fix deviation of MISRA C Rule 16.3 To: Jan Beulich Cc: consulting@bugseng.com, Simone Ballarin , Doug Goldstein , Stefano Stabellini , xen-devel@lists.xenproject.org References: <490e1a84b1b4b8d983dc41af147191f79506cdbd.1721050709.git.federico.serafini@bugseng.com> Content-Language: en-US, it From: Federico Serafini Organization: BUGSENG In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 24/07/24 11:45, Jan Beulich wrote: > On 15.07.2024 18:48, Federico Serafini wrote: >> --- a/automation/eclair_analysis/ECLAIR/deviations.ecl >> +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl >> @@ -499,7 +499,7 @@ safe." >> -doc_end >> >> -doc_begin="Switch clauses ending with an explicit comment indicating the fallthrough intention are safe." >> --config=MC3R1.R16.3,reports+={safe, "any_area(end_loc(any_exp(text(^(?s).*/\\* [fF]all ?through.? \\*/.*$,0..1))))"} >> +-config=MC3R1.R16.3,reports+={safe, "any_area(end_loc(any_exp(text(^(?s).*/\\* [fF]all ?through\\.? \\*/.*$,0..2))))"} >> -doc_end >> >> -doc_begin="Switch statements having a controlling expression of enum type deliberately do not have a default case: gcc -Wall enables -Wswitch which warns (and breaks the build as we use -Werror) if one of the enum labels is missing from the switch." > > This patch doesn't apply. There's a somewhat similar entry, but its doc_begin > line is sufficiently different. I have no idea what's going on here; there's > no dependency stated anywhere. Right, this patch depends on [1] which has not been committed yet. [1] https://lists.xenproject.org/archives/html/xen-devel/2024-06/msg01347.html -- Federico Serafini, M.Sc. Software Engineer, BUGSENG (http://bugseng.com)