From: "flichtenheld (Code Review)" Date: Mon, 27 Jan 2025 12:27:43 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="j6UYCkV3jLk="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Fix doxygen warnings in crypto_epoch.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --j6UYCkV3jLk= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/877?usp=3Demail to review the following change. Change subject: Fix doxygen warnings in crypto_epoch.h ...................................................................... Fix doxygen warnings in crypto_epoch.h Introduced by commit 92adbc88b1b37095cebde2a1c5b6ae242f382678. Change-Id: I0133085ac68f7b0db574b88276f6d5e1d3ad62d5 Signed-off-by: Frank Lichtenheld --- M src/openvpn/crypto_epoch.h 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/77/877/1 diff --git a/src/openvpn/crypto_epoch.h b/src/openvpn/crypto_epoch.h index b2f3d86..9290482 100644 --- a/src/openvpn/crypto_epoch.h +++ b/src/openvpn/crypto_epoch.h @@ -71,7 +71,7 @@ * Generate a data channel key pair from the epoch key * @param key Destination for the generated data key * @param epoch_key Epoch key to be used - * @parm kt Cipher information to generate the data channel ke= y for + * @param kt Cipher information to generate the data channel ke= y for */ void epoch_data_key_derive(struct key_parameters *key, @@ -100,6 +100,7 @@ * - recv key matches the epoch index provided * - send key epoch is equal or higher than recv_key epoch * + * @param co crypto_options to update * @param new_epoch the new epoch to use for the receive key */ void -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/877?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I0133085ac68f7b0db574b88276f6d5e1d3ad62d5 Gerrit-Change-Number: 877 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-MessageType: newchange --j6UYCkV3jLk= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

Vi= ew Change

Fix doxygen warnings in crypto_epoch.h

Introduced by c= ommit 92adbc88b1b37095cebde2a1c5b6ae242f382678.

Change-Id: I0133085a= c68f7b0db574b88276f6d5e1d3ad62d5
Signed-off-by: Frank Lichtenheld <fr= ank@...2641...>
---
M src/openvpn/crypto_epoch.h
1 file changed= , 2 insertions(+), 1 deletion(-)

git pull ssh://gerrit.openvpn.ne=
t:29418/openvpn refs/changes/77/877/1
diff --git a/src/openvpn/cryp=
to_epoch.h b/src/openvpn/crypto_epoch.h
index b2f3d86..9290= 482 100644
--- a/src/openvpn/crypto_epoch.h
+++ b/src/openvpn/crypto_epoch.h
@@ -71,7 +71,7 @@<= br> * Generate a data channel key pair from the epoch key
= * @param key Destination for the generated data key

* @param epoch_key Epoch key to be used
- * @parm kt Cipher informati= on to generate the data channel key for
+ * @param kt Cipher information to generate = the data channel key for
*/
void<= br> epoch_data_key_derive(struct key_parameters *key,
@@ -100,6 +100,7 @@
* - recv key matches the epoch index= provided
* - send key epoch is equal or higher than recv= _key epoch
*
+ * @param co crypto_options to update
*= @param new_epoch the new epoch to use for the receive key
= */
void

To view, vis= it change= 877. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0133085ac68f7b0db574b88276f= 6d5e1d3ad62d5
Gerrit-Change-Number: 877
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-MessageType: newchange
--j6UYCkV3jLk=--