From: "flichtenheld (Code Review)" Date: Wed, 9 Jul 2025 15:02:49 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="UXQBqOkqzjo="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Do not compile mbed key helper with MBEDTLS_SSL_KEYING_MATERIAL_EXPORT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --UXQBqOkqzjo= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/1081?usp=3Demail ) Change subject: Do not compile mbed key helper with MBEDTLS_SSL_KEYING_MATE= RIAL_EXPORT ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/openvpn/ssl_mbedtls.c: http://gerrit.openvpn.net/c/openvpn/+/1081/comment/eaa93c85_55785638 : PS1, Line 177: #if HAVE_MBEDTLS_SSL_CONF_EXPORT_KEYS_EXT_CB && !defined(MBE= DTLS_SSL_KEYING_MATERIAL_EXPORT) Change makes sense, but now every clause of the #if .. #elif .. #elif has a= `!defined(MBEDTLS_SSL_KEYING_MATERIAL_EXPORT)`. So I think it would be eas= ier to understand wrapping the whole thing into a separate `#if !defined(MB= EDTLS_SSL_KEYING_MATERIAL_EXPORT`. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1081?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I0f325800ebeb20bd5ef3ff78e5c5fcf0f6f74efd Gerrit-Change-Number: 1081 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Wed, 09 Jul 2025 15:02:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --UXQBqOkqzjo= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

Patch set 1:Code-Review -1=

V= iew Change

1 comment:

  • File src/openvpn/ssl_mbedtls.c:=

    • Patch Set #1, Lin= e 177: #if HAVE_MBEDTLS= _SSL_CONF_EXPORT_KEYS_EXT_CB && !defined(MBEDTLS_SSL_KEYING_MATERIA= L_EXPORT)

      Change makes sense, but now every clause of the #if .. #elif .. #elif h= as a `!defined(MBEDTLS_SSL_KEYING_MATERIAL_EXPORT)`. So I think it would be= easier to understand wrapping the whole thing into a separate `#if !define= d(MBEDTLS_SSL_KEYING_MATERIAL_EXPORT`.

To view, v= isit cha= nge 1081. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0f325800ebeb20bd5ef3ff78e5c= 5fcf0f6f74efd
Gerrit-Change-Number: 1081
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Comment-Date: Wed, 09 Jul 2025 15:02:49= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--UXQBqOkqzjo=--