From: "kallisti5 (Code Review)" Date: Tue, 28 Jan 2025 01:50:27 +0000 References: Reply-To: alex@...2837..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="r6OMEUqLwYA="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Haiku: Fix short interface path length List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos , flichtenheld Cc: openvpn-devel --r6OMEUqLwYA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/689?usp=3Demail to review the following change. Change subject: Haiku: Fix short interface path length ...................................................................... Haiku: Fix short interface path length * Haiku uses full paths for interface names, 16 characters isn't enough. Change-Id: I6de60ed5c03ea45e1d7a3f7777bfc8ed5075e84d --- M src/openvpn/route.h 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/89/689/1 diff --git a/src/openvpn/route.h b/src/openvpn/route.h index 421e7d2..69b06b8 100644 --- a/src/openvpn/route.h +++ b/src/openvpn/route.h @@ -155,6 +155,8 @@ /* gateway interface */ #ifdef _WIN32 DWORD adapter_index; /* interface or ~0 if undefined */ +#elif defined(TARGET_HAIKU) + char iface[PATH_MAX]; /* iface names are full /dev path with driver na= me */ #else char iface[16]; /* interface name (null terminated), may be empty */ #endif @@ -186,8 +188,13 @@ #else /* non linux platform don't have this constant defined */ #ifndef IFNAMSIZ +#if defined(TARGET_HAIKU) +/* iface names are full /dev path with driver name */ +#define IFNAMSIZ PATH_MAX +#else #define IFNAMSIZ 16 #endif +#endif char iface[IFNAMSIZ]; /* interface name (null terminated), may be empt= y */ #endif -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/689?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6de60ed5c03ea45e1d7a3f7777bfc8ed5075e84d Gerrit-Change-Number: 689 Gerrit-PatchSet: 1 Gerrit-Owner: kallisti5 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-MessageType: newchange --r6OMEUqLwYA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

kallisti5 would like plaisthos and flichtenheld to review this change.

Vi= ew Change

Haiku: Fix short interface path length

* Haiku uses fu= ll paths for interface names, 16 characters
isn't enough.

C= hange-Id: I6de60ed5c03ea45e1d7a3f7777bfc8ed5075e84d
---
M src/openvpn= /route.h
1 file changed, 7 insertions(+), 0 deletions(-)

git p= ull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/89/689/1
di=
ff --git a/src/openvpn/route.h b/src/openvpn/route.h
index = 421e7d2..69b06b8 100644
--- a/src/openvpn/route.h+++ b/src/openvpn/route.h
@@ -155,6 +155,8 @@=
/* gateway interface */
#ifdef _WIN32
DWORD adapter_index; /* interface or ~0 if undefined */
+#elif defined(TARGET_HA= IKU)
+ char iface[= PATH_MAX]; /* iface names are full /dev path with driver name */
= #else
char iface[16]; /* interface name (null t= erminated), may be empty */
#endif
@@ -186= ,8 +188,13 @@
#else
/* non linux plat= form don't have this constant defined */
#ifndef IFNAM= SIZ
+#if defined(TARG= ET_HAIKU)
+/* iface n= ames are full /dev path with driver name */
+#define IFNAMSIZ PATH_MAX
+#else
#define IFNAMSIZ 16
#endif
+#endif
char iface[IFNAMSIZ]; /* interface name (null= terminated), may be empty */
#endif


To view, visit change 689. To unsubscribe, or f= or help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6de60ed5c03ea45e1d7a3f7777b= fc8ed5075e84d
Gerrit-Change-Number: 689
Gerrit-PatchSet: 1
Gerrit-Owner: kallisti5 <alex@...2837...>= ;
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-MessageType: newchange
--r6OMEUqLwYA=--