From: Dmitry Osipenko Subject: Re: [PATCH v9 1/7] ARM: trusted_foundations: Support L2 cache maintenance Date: Mon, 4 Mar 2019 19:40:20 +0300 Message-ID: References: <20190303171214.24821-1-digetx@gmail.com> <20190303171214.24821-2-digetx@gmail.com> <20190304154729.GA13794@qmqm.qmqm.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20190304154729.GA13794@qmqm.qmqm.pl> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Cc: Russell King , Thierry Reding , Jonathan Hunter , Robert Yang , linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-tegra@vger.kernel.org 04.03.2019 18:47, Michał Mirosław пишет: > On Sun, Mar 03, 2019 at 08:12:08PM +0300, Dmitry Osipenko wrote: >> Implement L2 cache initialization firmware callback that should be >> invoked early during boot in order to set up the required outer cache >> driver's callbacks and add the callback required for L2X0 maintenance. > [...] >> @@ -43,6 +46,11 @@ void register_trusted_foundations(struct trusted_foundations_platform_data *pd); >> void of_register_trusted_foundations(void); >> >> #else /* CONFIG_TRUSTED_FOUNDATIONS */ >> +static inline void tf_dummy_write_sec(unsigned long val, unsigned int reg) >> +{ >> + if (reg == L2X0_CTRL && val == L2X0_CTRL_EN) >> + pr_err("Trusted Foundations unavailable, ignoring request to enable L2C\n"); >> +} >> >> static inline void register_trusted_foundations( >> struct trusted_foundations_platform_data *pd) >> @@ -53,6 +61,10 @@ static inline void register_trusted_foundations( >> */ >> pr_err("No support for Trusted Foundations, continuing in degraded mode.\n"); >> pr_err("Secondary processors as well as CPU PM will be disabled.\n"); >> +#if IS_ENABLED(CONFIG_CACHE_L2X0) >> + pr_err("L2X0 cache will be disabled.\n"); > [...] > > I guess this is redundant since tf_dummy_write_sec() will say the same > thing when trying to enable the cache. Yes, thanks. I'll change that in the next iteration, for now will wait for awhile for more comments.