Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74D60C77B71 for ; Tue, 11 Apr 2023 07:40:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0B00585D74; Tue, 11 Apr 2023 09:40:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=quarantine dis=none) header.from=kernel-space.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=kernel-space.org header.i=@kernel-space.org header.b="EnppWlC2"; dkim=fail reason="key not found in DNS" (0-bit key; unprotected) header.d=kernel-space.org header.i=@kernel-space.org header.b="ksw8hs2f"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 20D5685D37; Tue, 11 Apr 2023 09:40:23 +0200 (CEST) Received: from mail.kernel-space.org (unknown [IPv6:2a01:4f8:c2c:5a84::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9A83785DDA for ; Tue, 11 Apr 2023 09:40:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=kernel-space.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=angelo@kernel-space.org Received: from ziongate (localhost [127.0.0.1]) by ziongate (OpenSMTPD) with ESMTP id bebf35e1; Tue, 11 Apr 2023 07:40:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=simple; d=kernel-space.org; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s=default; bh=l47ZAM5/d1leOI4m4sUrWDqwlJ4=; b=EnppWlC2RIC0360d75pKfjYMKLsT ZWvOA6KSi4S6jbxE+NAPGwfQYz2/wkPfcu48ow/JBfASnr/gaDHPtjprY1W63kfs Pb1ox4innKxLZ92eao2k6pqJxUMdqMNfRRXNr0w7zyYpXzRUT9jK3beGuDmvot4o vB/WVds4pzACoy8= DomainKey-Signature: a=rsa-sha1; c=simple; d=kernel-space.org; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; q=dns; s= default; b=tM6WXQcL122rh+5xaDoJqiE7mgw6/Qamf0VyrCJN7LiF9oORncjxY xbrMsX0nj+3YJMYGoyYRXsYgd4r3KmMWYzX5v1EcuuVcyp16aYN6U1i6kSjmu8I5 0Mw9yh1ea2frs9hbtQidYx5WpJkcKUFxwEtTAI4jyA8tIwyNFK32Vg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-space.org; s=20190913; t=1681198817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2aT+TnNkZli0f2/aYD4kq4rKGCfjML1G70kB+sp0MII=; b=ksw8hs2fKxeXiHC4bQcAcjp6vtnrlCGqkC9wbtkfljE8xGYuQKmEq1QXVYmXscMJax8AL7 cgmdNsjwOL8fuihujTFYYU2ZXUbwJLPNCBVKaSa29TDZ/3z4EtbOv29Vp4H3kx9sludsZW qcKJvBj2Vx5zj/I/OpzH4Awx5+bwpiQ= Received: from [192.168.0.2] (host-79-21-232-20.retail.telecomitalia.it [79.21.232.20]) by ziongate (OpenSMTPD) with ESMTPSA id 9118b5c2 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 11 Apr 2023 07:40:17 +0000 (UTC) Message-ID: Date: Tue, 11 Apr 2023 09:40:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 6/6] m68k: upgrading all boards to dm i2c Content-Language: en-US To: hs@denx.de, trini@konsulko.com Cc: u-boot@lists.denx.de, mario.six@gdsys.cc References: <20230404225928.3032456-1-angelo@kernel-space.org> <20230404225928.3032456-6-angelo@kernel-space.org> From: Angelo Dureghello In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Helko, On 11/04/23 6:41 AM, Heiko Schocher wrote: > Hello Angelo, > > On 05.04.23 00:59, Angelo Dureghello wrote: >> Upgrading all board configs where i2c is involved to DM i2c. >> >> Signed-off-by: Angelo Dureghello >> --- >> configs/M5208EVBE_defconfig | 5 +---- >> configs/M5235EVB_Flash32_defconfig | 1 + >> configs/M5235EVB_defconfig | 1 + >> configs/M5253DEMO_defconfig | 5 +---- >> configs/M5275EVB_defconfig | 5 +---- >> configs/M53017EVB_defconfig | 6 ++---- >> configs/M5329AFEE_defconfig | 6 ++---- >> configs/M5329BFEE_defconfig | 6 ++---- >> configs/M5373EVB_defconfig | 3 ++- >> configs/astro_mcf5373l_defconfig | 6 ++---- >> configs/eb_cpu5282_defconfig | 5 ++--- >> configs/eb_cpu5282_internal_defconfig | 5 ++--- >> configs/stmark2_defconfig | 4 ++++ >> 13 files changed, 23 insertions(+), 35 deletions(-) > > Thanks for this series, I did not find a cover letter Email, > so I have here a common question: > > You rename in patch 1/6 > > CONFIG_SYS_I2C_0 -> CFG_SYS_I2C_0 > > but only add in patch 2/6 for the stmark2 this renamed define, > and add DTS nodes for other boards in patch 5/6 and here the > defconfig changes... may I oversee something obvious, but do > the other boards not also need some CFG_SYS_I2C_0 define? > CFG_SYS_I2C_0 (0 to 5) it's a define to setup pads pinmux to i2c, but only for coldfire mcf5441x family that requires this. m68k/cpu/mcf5445x/cpu_init.c:#ifdef CFG_SYS_I2C_0 Involved board is only stmark2, that is the board i am using here for test. I found this define to be set because i2c was not working, so i moved in the more proper CFG_ namespace. I cannot test other boards actually, but i don't find any similar define/need in their start code, so i am supposing other cpu families are not needing it, or using other definitions for pinmux. I would like one day to add pinmux setup from fdt, but not trivial, linux does not have fdt implementation for coldfire, so need to invent it from scratch. > Thanks! > > bye, > Heiko Thanks, Regards, angelo