Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B64F3C4332F for ; Tue, 1 Nov 2022 17:49:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230003AbiKARtg (ORCPT ); Tue, 1 Nov 2022 13:49:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229562AbiKARtf (ORCPT ); Tue, 1 Nov 2022 13:49:35 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 460FD1CFF5 for ; Tue, 1 Nov 2022 10:49:34 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id bs21so21202694wrb.4 for ; Tue, 01 Nov 2022 10:49:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Vuz2/1e8Z4TDpyEriCyACpZF+nY+VKelYmyQZgIB5As=; b=lUmOn5Z/KIfZ1LT8QCy9ETrXaNlr+x0WGEpfbKb0GxPuxpeX2LFDrAOCbBg4Rp6lMF JsNhxW9uMJHmW0c1n68aye8TqAHpO6g60LedXKuHWQsh/W11LZpnsP6ZFfiQ+8pzYUF3 3RyDyGOAtNE0v9bqtcmAgFezxFygYGP+59Zwx6oTjH7KJHOiV4bezhhwsMDeU1eFIqlj tLZX7NsMMOnc3IirPf+mh31w8N8ZmIIuvlxcAgZ5iJ0dVxAfjkNu0z2+M0Rwdc7p4EVb hcMAuUXCKeQdKVm2kTpL1Bv2my69Oo8uv+nI/5T20HgNe3GRPc/JEbCVFwOdF4i0ZLZL g9HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vuz2/1e8Z4TDpyEriCyACpZF+nY+VKelYmyQZgIB5As=; b=EREnoQz2RE5vW3peHUVOF9M3yEMvSQPp9BzxZN0e2uyUIVdAQ4nOvJ4n5A5/A5KGOv UJ35Hl5pIuXSbEJkaLzDhHF74nU3hqGujNPF1iEKOEPSa6rZmuqFaNhx4HblxxdxyAxA VE+GB2C0mz1PG0NWu18O9nlF5sb505t0q+clX7G4sutF47Bv4dLZUYY1On1SdVH2su65 3Mm1qe/B9hrpEpG/btlJb/vfN68xEiojw3CKV376WJ+AMYk08j51TI+yiGCzGvJHGPhJ Z3SnwBRrbbNLm8b8bqefk6txWYZgellvhdT3cuODZcvoo4ZXG7vq3q7xOL+ReA7SDyLl 7PJQ== X-Gm-Message-State: ACrzQf1gMOGbE6glibLGozb1447t9jWxaQCqRERFxTqEH6SbAki9Uvcy 6s6smJoWCmmwv6vsXlgmw8OP+JA2x/w= X-Google-Smtp-Source: AMsMyM7NZWWGAKqK/AUpXZO5TCQC4KC8pnEEikYKmVmuM9LYoDLMDfAfro0f6aqJfwSHjtNdX5b74g== X-Received: by 2002:adf:e6c3:0:b0:236:acdb:4d9b with SMTP id y3-20020adfe6c3000000b00236acdb4d9bmr12078185wrm.528.1667324972733; Tue, 01 Nov 2022 10:49:32 -0700 (PDT) Received: from [192.168.1.50] ([81.196.40.23]) by smtp.gmail.com with ESMTPSA id y10-20020a5d620a000000b0023657e1b97esm10758916wru.11.2022.11.01.10.49.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Nov 2022 10:49:32 -0700 (PDT) Message-ID: Date: Tue, 1 Nov 2022 19:49:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v3 5/5] wifi: rtl8xxxu: Use dev_info instead of pr_info To: Kalle Valo Cc: "linux-wireless@vger.kernel.org" , Jes Sorensen References: <87iljzudxl.fsf@kernel.org> Content-Language: en-US From: Bitterblue Smith In-Reply-To: <87iljzudxl.fsf@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 01/11/2022 13:11, Kalle Valo wrote: > Bitterblue Smith writes: > >> Replace two instances of bare pr_info with dev_info. >> >> Also make their messages a little more informative. >> >> Signed-off-by: Bitterblue Smith > > [...] > >> @@ -5420,7 +5421,8 @@ static void rtl8xxxu_rx_urb_work(struct work_struct *work) >> rtl8xxxu_queue_rx_urb(priv, rx_urb); >> break; >> default: >> - pr_info("failed to requeue urb %i\n", ret); >> + dev_info(&priv->udev->dev, >> + "failed to requeue urb with error %i\n", ret); > > Should this be dev_warn()? It looks like a warning. > Probably yes. I'll do that and also rebase everything.