From: "plaisthos (Code Review)"
Date: Mon, 8 Jul 2024 16:16:19 +0000
In-Reply-To:
References:
Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net,
frank@...2641...
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="G40oo1iJv48="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[master]: Allow trailing \r
and \n in control channel message
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: flichtenheld , openvpn-devel
--G40oo1iJv48=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c=
/openvpn/+/672?usp=3Demail )
Change subject: Allow trailing \r and \n in control channel message
......................................................................
Patch Set 1:
(1 comment)
File src/openvpn/forward.c:
http://gerrit.openvpn.net/c/openvpn/+/672/comment/ab73eb7e_71ef24b3 :
PS1, Line 309: /* Remove \r and \n at the end of the buffer=
to avoid
> Why can't you use buf_chomp?
I can. I missed that there is a buf_chomp. I looked for buf_trim buf_rtrim =
or similar.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/672?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I47c992b6b73b1475cbff8a28f720cf50dc1fbe3e
Gerrit-Change-Number: 672
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos
Gerrit-Reviewer: flichtenheld
Gerrit-CC: openvpn-devel
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Mon, 08 Jul 2024 16:16:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld
Gerrit-MessageType: comment
--G40oo1iJv48=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld.
View C=
hange
1 comment:
I can. I missed that there is a buf_chomp. I looke=
d for buf_trim buf_rtrim or similar.
To view, vis=
it change=
672. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I47c992b6b73b1475cbff8a28f72=
0cf50dc1fbe3e
Gerrit-Change-Number: 672
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arne-openvpn@...1711...=
27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Comment-Date: Mon, 08 Jul 2024 16:16:19=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
Gerrit-MessageType: comment
--G40oo1iJv48=--