From: "selvanair (Code Review)"
Date: Mon, 13 Apr 2026 17:23:52 +0000
In-Reply-To:
References:
Reply-To: selva.nair@...277..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, antonio@...2726...
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="WJELiLopwYo="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[master]: verify_x509_name:
Improve the error message on failure
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: plaisthos , openvpn-devel
--WJELiLopwYo=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: ordex, plaisthos.
selvanair has posted comments on this change by selvanair. ( http://gerrit.=
openvpn.net/c/openvpn/+/1624?usp=3Demail )
Change subject: verify_x509_name: Improve the error message on failure
......................................................................
Patch Set 1:
(1 comment)
File src/openvpn/ssl_verify.c:
http://gerrit.openvpn.net/c/openvpn/+/1624/comment/b73b8520_97809e57?usp=3D=
email :
PS1, Line 397: msg(D_HANDSHAKE, "VERIFY X509NAME OK: %s", subject);
> by applying the same logic, shouldn't we just print the string we have ma=
tched against, instead of t [=E2=80=A6]
Here is my thought on this:
On success, its just a gratuitous message and its not confusing. We are jus=
t printing what the subject (DN) of the certificate is.
On error, its a critical message that says what was expected and what was f=
ound. The current code tries to match something and prints something else.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1624?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings?usp=3Demail
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6e7947ab81cf229f0d27714dd563a07ace6bd38a
Gerrit-Change-Number: 1624
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-CC: ordex
Gerrit-Attention: plaisthos
Gerrit-Attention: ordex
Gerrit-Comment-Date: Mon, 13 Apr 2026 17:23:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ordex
--WJELiLopwYo=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is cur=
rently required from: ordex, plaisthos.
View =
Change
1 comment:
=
File src/openvpn/ssl_verify.c:
<=
ul style=3D"list-style: none; padding: 0;">Patch Set =
#1, Line 397: m=
sg(D_HANDSHAKE, "VERIFY X509NAME OK: %s", subject);
=
by applying the same logic, shouldn't we just print the string=
we have matched against, instead of t [=E2=80=A6]
Here is=
my thought on this:
On success, its just a gratuitous message and its n=
ot confusing. We are just printing what the subject (DN) of the certificate=
is.
On error, its a critical message that says what was expected and wh=
at was found. The current code tries to match something and prints somethin=
g else.
To view, visit change 1624. To unsubscribe, o=
r for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6e7947ab81cf229f0d27714dd56=
3a07ace6bd38a
Gerrit-Change-Number: 1624
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <selva.nair@...1354...=
..>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-CC: ordex <antonio@...2726...> =
div>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: ordex <antonio@...2726...=
>
Gerrit-Comment-Date: Mon, 13 Apr 2026 17:23:52=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ordex <antonio@...2787...=
...>
=
--WJELiLopwYo=--