Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 765B5C433E2 for ; Fri, 28 Aug 2020 08:45:52 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3DE3B20665 for ; Fri, 28 Aug 2020 08:45:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3DE3B20665 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kBa0y-0002iM-Ku; Fri, 28 Aug 2020 08:45:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kBa0x-0002iH-HZ for xen-devel@lists.xenproject.org; Fri, 28 Aug 2020 08:45:39 +0000 X-Inumbo-ID: dc72f9a1-3340-4c9f-a900-5729be04c880 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id dc72f9a1-3340-4c9f-a900-5729be04c880; Fri, 28 Aug 2020 08:45:38 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A95D6AC37; Fri, 28 Aug 2020 08:46:10 +0000 (UTC) Subject: Re: [PATCH v2 6/8] x86/pv: disallow access to unknown MSRs To: Roger Pau Monne Cc: xen-devel@lists.xenproject.org, Andrew Cooper , Wei Liu References: <20200820150835.27440-1-roger.pau@citrix.com> <20200820150835.27440-7-roger.pau@citrix.com> From: Jan Beulich Message-ID: Date: Fri, 28 Aug 2020 10:45:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200820150835.27440-7-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 20.08.2020 17:08, Roger Pau Monne wrote: > --- a/xen/arch/x86/pv/emul-priv-op.c > +++ b/xen/arch/x86/pv/emul-priv-op.c > @@ -972,9 +972,10 @@ static int read_msr(unsigned int reg, uint64_t *val, > } > /* fall through */ > default: > + gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", reg); > + break; > + > normal: > - /* Everyone can read the MSR space. */ > - /* gdprintk(XENLOG_WARNING, "Domain attempted RDMSR %08x\n", reg); */ > if ( rdmsr_safe(reg, *val) ) > break; > return X86EMUL_OKAY; > @@ -1141,14 +1142,15 @@ static int write_msr(unsigned int reg, uint64_t val, > } > /* fall through */ > default: > - if ( rdmsr_safe(reg, temp) ) > - break; > + gdprintk(XENLOG_WARNING, > + "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", > + reg, val); > + break; > > - if ( val != temp ) > invalid: > - gdprintk(XENLOG_WARNING, > - "Domain attempted WRMSR %08x from 0x%016"PRIx64" to 0x%016"PRIx64"\n", > - reg, temp, val); > + gdprintk(XENLOG_WARNING, > + "Domain attempted WRMSR %08x from 0x%016"PRIx64" to 0x%016"PRIx64"\n", > + reg, temp, val); > return X86EMUL_OKAY; > } There some odd mix of whether or no 0x prefixes get logged. I'd advocate for dropping all of them, but imo at the very least all three messages should be consistent in this regard. Jan