From: "cron2 (Code Review)" Date: Mon, 23 Jun 2025 11:53:11 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., rein.vanbaaren@...1435..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="7bbN1PeWrqM="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Added PQE to WolfSSL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: comododragon Cc: plaisthos , flichtenheld , openvpn-devel --7bbN1PeWrqM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: comododragon, flichtenheld. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/1046?usp=3Demail ) Change subject: Added PQE to WolfSSL ...................................................................... Patch Set 3: Code-Review-1 (3 comments) Patchset: PS3: getting closer ;-) File README.wolfssl: http://gerrit.openvpn.net/c/openvpn/+/1046/comment/7ec159a7_61317087 : PS3, Line 40: option in a config. the textual logic is weird here - "to build with these PQE...", while "thes= e PQE" are only defined in the next paragraph...? File src/openvpn/ssl_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/1046/comment/e1a1e35c_b06c65eb : PS3, Line 564: if (!SSL_CTX_set1_groups_list(ctx->ctx, groups)) please do not do that - that is, move code blocks around, just to have an e= asier time in the #ifdef As far as I can see all the patch really does is "change the #ifdef", but w= ith a larger diff due to swapping the if/else parts this is harder to see, = and will also mess up "git blame" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1046?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie0529c2074964b3be034f01e0ef53090a6edbd35 Gerrit-Change-Number: 1046 Gerrit-PatchSet: 3 Gerrit-Owner: comododragon Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Attention: comododragon Gerrit-Comment-Date: Mon, 23 Jun 2025 11:53:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --7bbN1PeWrqM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: comododragon, flichtenheld.

Patch set 3:Code-Review -1=

V= iew Change

3 comments:

  • Patchset:

  • File README.wolfssl:

    • Patch Set #3, Line 40: option in a config.

      the textual logic is wei= rd here - "to build with these PQE...", while "these PQE&quo= t; are only defined in the next paragraph...?

  • File src/openvpn/ssl_openssl.c:

    • Patch Set #3, Line 564: if (!SSL_CTX_set1_groups_= list(ctx->ctx, groups))

      please do not do that - that is, move code blocks arou= nd, just to have an easier time in the #ifdef

      As far as I can see all the patch really d= oes is "change the #ifdef", but with a larger diff due to swappin= g the if/else parts this is harder to see, and will also mess up "git = blame"

To view, visit change 1046. To unsubscrib= e, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie0529c2074964b3be034f01e0ef= 53090a6edbd35
Gerrit-Change-Number: 1046
Gerrit-PatchSet: 3
Gerrit-Owner: comododragon <rein.vanbaaren@= ...1435...>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: comododragon <rein.vanbaa= ren@...1435...>
Gerrit-Comment-Date: Mon, 23 Jun 2025 11:53:11= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--7bbN1PeWrqM=--