Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B29A9C43217 for ; Mon, 22 Nov 2021 10:33:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CA6766EB80; Mon, 22 Nov 2021 10:33:40 +0000 (UTC) Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by gabe.freedesktop.org (Postfix) with ESMTPS id 752736EB80 for ; Mon, 22 Nov 2021 10:33:39 +0000 (UTC) Received: by mail-lf1-x135.google.com with SMTP id bu18so78700031lfb.0 for ; Mon, 22 Nov 2021 02:33:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nrxZZZTUaK5PX2ySh0+vBqyiZXpekCDZnPCBfoLVNj8=; b=PBRfkEeYxsKR7JApIAGoA9f/5z9fI/wiXjTBCL/PUUL1M2yf5L99Ocjs/ID34wmvxa ccVyhqkPjMrZv4YC2K9g8y0Kl2IwE2TDrDfFwuKfwdYzl03rFrnAtp0KdET7oL4woquF ya5NXRIbVvBsW6inbrBMwE2COQ5KdwVw7H+8QvYJrKtyZLgPm2weo4ZK1YkCxrL1qFgZ g7TRwzqICHBaHaCME6zIkKdp59ENCOXAeiL/SyD0GjqLDrkNS4HPOQY71Qeuf5OZxcs/ YXF6rI5t9FtGjjObSRj3mJ+MkWoQa+8wwxDn3fDsNmNj9e+vUt9IrL0w9IsjoNGc1Lf3 6plw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nrxZZZTUaK5PX2ySh0+vBqyiZXpekCDZnPCBfoLVNj8=; b=tI4X/qqQ+GR2jYSY+FVQmDTsoHFs7MSMTzH2NGK6nPGw/GkBdADzLjbNPBCqaRh8jX d9XUrDw/e00LGphCoNdz4+NCtQ91+dJ+oz9o6+F7xRgIgKdepE16m6OsloVY8ZSQCa6S qEABX0lBRKStJGzUA4C4KOKQ5AQBFNGA12eHDGxnD9A6FJaxVWRAAT4l/oDdehKCx7xB B/9KbTwMiuR40LldsfTb8/EAnMsgD9VgS9zVciW4Kz9iRFI6QZqkY4N8Wusm7WN/cI9p HlS5qUObd6pb6IsOKhX8oLdvA7hJ2blEv2Ff+H1J9vg+PwdFHf7wBC84WUC1YZxOy9JJ TP/Q== X-Gm-Message-State: AOAM532XpN4RTBjxWxHOFA2xrL3+TDVC51KQgnkemsr2fjsiT3D2tgV8 wGwB546RKMATgmxQSjzDUv8= X-Google-Smtp-Source: ABdhPJzZ/qm5LLGImo0I/3G8kIkfGaa7D9I8/JdE3U3vap72N3xDDHAzVRpK4BfX2bx0KTP6BS+BIA== X-Received: by 2002:a2e:6a11:: with SMTP id f17mr49823727ljc.206.1637577217813; Mon, 22 Nov 2021 02:33:37 -0800 (PST) Received: from [192.168.2.145] (94-29-48-99.dynamic.spd-mgts.ru. [94.29.48.99]) by smtp.googlemail.com with ESMTPSA id x4sm898633ljd.1.2021.11.22.02.33.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Nov 2021 02:33:36 -0800 (PST) Subject: Re: [PATCH] i2c: tegra: Add ACPI support To: Andy Shevchenko , Akhil R References: <1637328734-20576-1-git-send-email-akhilrajeev@nvidia.com> From: Dmitry Osipenko Message-ID: Date: Mon, 22 Nov 2021 13:33:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Kernel Mailing List , dri-devel , linaro-mm-sig@lists.linaro.org, Laxman Dewangan , Thierry Reding , linux-i2c , linux-tegra , Jon Hunter , Christian Koenig , Linux Media Mailing List Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" 19.11.2021 17:48, Andy Shevchenko пишет: >> + if (i2c_dev->nclocks == 0) >> + return; > Why? Make clocks optional. This check shouldn't be needed because both clk_disable() and clk_bulk_unprepare() should handle NULL/zero clocks without problems.