From: Abdiel Janulgue Subject: Re: [PATCH i-g-t 2/2] igt_core: Rework igt_system() Date: Mon, 25 Sep 2017 11:33:51 +0300 Message-ID: References: <1505998348-3444-1-git-send-email-petri.latvala@intel.com> <1505998348-3444-2-git-send-email-petri.latvala@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id E87946E27E for ; Mon, 25 Sep 2017 08:33:53 +0000 (UTC) In-Reply-To: <1505998348-3444-2-git-send-email-petri.latvala@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Petri Latvala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAwOS8yMS8yMDE3IDAzOjUyIFBNLCBQZXRyaSBMYXR2YWxhIHdyb3RlOgo+IEluc3RlYWQg b2YgcmVkaXJlY3Rpbmcgb3V0cHV0IHRvIHBpcGVzIGFuZCBmb3JraW5nLCByZWRpcmVjdCBhZnRl cgo+IGZvcmtpbmcgdG8gYXZvaWQgaGF2aW5nIHRvIGNhcmVmdWxseSB1bnJlZGlyZWN0IGJlZm9y ZSBsb2dnaW5nCj4gYW55dGhpbmcuCj4gCj4gaWd0QHRvb2xzX3Rlc3RAc3lzZnNfbDNfcGFyaXR5 IGhhZCBhIHJhY3kgY29uZGl0aW9uIHdoZXJlIGl0IHByaW50cwo+IHRoZSBvdXRwdXQgb2YgaW50 ZWxfbDNfcGFyaXR5IHByZXBlbmRlZCBieSBbY21kXSwgYnV0IHRoYXQgZW5kZWQgdXAKPiBiZWlu ZyBwcmludGVkIGFnYWluIHByZXBlbmRlZCBieSBbY21kXSBiZWNhdXNlIG91dHB1dCB3YXMgcmVk aXJlY3RlZCwKPiBjYXVzaW5nIG91dHB1dHMgdG8gYXBwZWFyIG11bHRpcGxlIHRpbWVzLiBUaGlz IHBhdGNoIGZpeGVzIHRoYXQuCj4gCj4gQ0M6IEFiZGllbCBKYW51bGd1ZSA8YWJkaWVsLmphbnVs Z3VlQGxpbnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBQZXRyaSBMYXR2YWxhIDxwZXRy aS5sYXR2YWxhQGludGVsLmNvbT4KClRoYW5rcyBmb3IgZml4aW5nIHRoaXMuIFNlcmllcyBpcwpS ZXZpZXdlZC1ieTogQWJkaWVsIEphbnVsZ3VlIDxhYmRpZWwuamFudWxndWVAbGludXguaW50ZWwu Y29tPgoKPiAtLS0KPiAgbGliL2lndF9jb3JlLmMgfCAxMTUgKysrKysrKysrKysrKysrKysrKyst LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0 MCBpbnNlcnRpb25zKCspLCA3NSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvbGliL2ln dF9jb3JlLmMgYi9saWIvaWd0X2NvcmUuYwo+IGluZGV4IDlmNGVlNjhiLi40N2I0NjgyZCAxMDA2 NDQKPiAtLS0gYS9saWIvaWd0X2NvcmUuYwo+ICsrKyBiL2xpYi9pZ3RfY29yZS5jCj4gQEAgLTIy MzcsNTggKzIyMzcsMjMgQEAgRklMRSAqX19pZ3RfZm9wZW5fZGF0YShjb25zdCBjaGFyKiBpZ3Rf c3JjZGlyLCBjb25zdCBjaGFyKiBpZ3RfZGF0YWRpciwKPiAgCXJldHVybiBmcDsKPiAgfQo+ICAK PiAtc3RydWN0IG91dHB1dF9waXBlIHsKPiAtCWludCBvdXRwdXRfZmQ7Cj4gLQlpbnQgc2F2ZV9m ZDsKPiAtCWludCByZWFkX2ZkOwo+IC0JaW50IHdyaXRlX2ZkOwo+IC0JYm9vbCByZWRpcmVjdGVk Owo+IC0JZW51bSBpZ3RfbG9nX2xldmVsIGxvZ19sZXZlbDsKPiAtfTsKPiAtCj4gLXN0YXRpYyBi b29sIHJlZGlyZWN0X291dHB1dChzdHJ1Y3Qgb3V0cHV0X3BpcGUgKnAsIGludCBvdXRwdXRfZmQs Cj4gLQkJCSAgICBlbnVtIGlndF9sb2dfbGV2ZWwgbGV2ZWwpCj4gK3N0YXRpYyB2b2lkIGxvZ19v dXRwdXQoaW50ICpmZCwgZW51bSBpZ3RfbG9nX2xldmVsIGxldmVsKQo+ICB7Cj4gLQlpbnQgZmRz WzJdOwo+IC0KPiAtCWlmIChwaXBlKGZkcykgPT0gLTEpCj4gLQkJZ290byBlcnI7Cj4gLQo+IC0J Lyogc2F2ZSBvdXRwdXQgKi8KPiAtCWlmICgocC0+c2F2ZV9mZCA9IGR1cChvdXRwdXRfZmQpKSA9 PSAtMSkKPiAtCQlnb3RvIGVycjsKPiAtCj4gLQkvKiBSZWRpcmVjdCBvdXRwdXQgdG8gb3VyIGJ1 ZmZlciAqLwo+IC0JaWYgKGR1cDIoZmRzWzFdLCBvdXRwdXRfZmQpID09IC0xKQo+IC0JCWdvdG8g ZXJyOwo+IC0KPiAtCXAtPm91dHB1dF9mZCA9IG91dHB1dF9mZDsKPiAtCXAtPnJlYWRfZmQgPSBm ZHNbMF07Cj4gLQlwLT53cml0ZV9mZCA9IGZkc1sxXTsKPiAtCXAtPnJlZGlyZWN0ZWQgPSB0cnVl Owo+IC0JcC0+bG9nX2xldmVsID0gbGV2ZWw7Cj4gLQo+IC0JcmV0dXJuIHRydWU7Cj4gLWVycjoK PiAtCWNsb3NlKGZkc1swXSk7Cj4gLQljbG9zZShmZHNbMV0pOwo+IC0JY2xvc2UocC0+c2F2ZV9m ZCk7Cj4gKwlzc2l6ZV90IGxlbjsKPiArCWNoYXIgYnVmW1BJUEVfQlVGXTsKPiAgCj4gLQlyZXR1 cm4gZmFsc2U7Cj4gLX0KPiArCWlmICgqZmQgPCAwKQo+ICsJCXJldHVybjsKPiAgCj4gLXN0YXRp YyB2b2lkIHVucmVkaXJlY3Rfb3V0cHV0KHN0cnVjdCBvdXRwdXRfcGlwZSAqcCkKPiAtewo+IC0J aWYgKCFwLT5yZWRpcmVjdGVkKQo+ICsJbWVtc2V0KGJ1ZiwgMCwgc2l6ZW9mKGJ1ZikpOwo+ICsJ bGVuID0gcmVhZCgqZmQsIGJ1Ziwgc2l6ZW9mKGJ1ZikpOwo+ICsJaWYgKGxlbiA8PSAwKSB7Cj4g KwkJY2xvc2UoKmZkKTsKPiArCQkqZmQgPSAtMTsKPiAgCQlyZXR1cm47Cj4gKwl9Cj4gIAo+IC0J LyogcmVhZF9mZCBpcyBjbG9zZWQgc2VwYXJhdGVseS4gV2Ugc3RpbGwgbmVlZCB0byByZWFkIGl0 cwo+IC0JICogYnVmZmVyZWQgY29udGVudHMgYWZ0ZXIgdW4tcmVkaXJlY3RpbmcgdGhlIHN0cmVh bS4KPiAtCSAqLwo+IC0JY2xvc2UocC0+d3JpdGVfZmQpOwo+IC0JZHVwMihwLT5zYXZlX2ZkLCBw LT5vdXRwdXRfZmQpOwo+IC0JY2xvc2UocC0+c2F2ZV9mZCk7Cj4gLQlwLT5yZWRpcmVjdGVkID0g ZmFsc2U7Cj4gKwlpZ3RfbG9nKElHVF9MT0dfRE9NQUlOLCBsZXZlbCwgIltjbWRdICVzIiwgYnVm KTsKPiAgfQo+ICAKPiAgLyoqCj4gQEAgLTIzMDQsNDggKzIyNjksNDggQEAgc3RhdGljIHZvaWQg dW5yZWRpcmVjdF9vdXRwdXQoc3RydWN0IG91dHB1dF9waXBlICpwKQo+ICAgKi8KPiAgaW50IGln dF9zeXN0ZW0oY29uc3QgY2hhciAqY29tbWFuZCkKPiAgewo+IC0jZGVmaW5lIE9VVCAwCj4gLSNk ZWZpbmUgRVJSIDEKPiAtCXN0cnVjdCBvdXRwdXRfcGlwZSBvcFsyXTsKPiAtCWludCBpLCBzdGF0 dXM7Cj4gKwlpbnQgb3V0cGlwZVsyXSA9IHsgLTEsIC0xIH07Cj4gKwlpbnQgZXJycGlwZVsyXSA9 IHsgLTEsIC0xIH07Cj4gKwlpbnQgc3RhdHVzOwo+ICAJc3RydWN0IGlndF9oZWxwZXJfcHJvY2Vz cyBwcm9jZXNzID0ge307Cj4gLQljaGFyIGJ1ZltQSVBFX0JVRl07Cj4gIAo+IC0JaWYgKCFyZWRp cmVjdF9vdXRwdXQoJm9wW09VVF0sIFNURE9VVF9GSUxFTk8sIElHVF9MT0dfSU5GTykpCj4gKwlp ZiAocGlwZShvdXRwaXBlKSA8IDApCj4gIAkJZ290byBlcnI7Cj4gLQlpZiAoIXJlZGlyZWN0X291 dHB1dCgmb3BbRVJSXSwgU1RERVJSX0ZJTEVOTywgSUdUX0xPR19XQVJOKSkKPiArCWlmIChwaXBl KGVycnBpcGUpIDwgMCkKPiAgCQlnb3RvIGVycjsKPiAgCj4gIAlpZ3RfZm9ya19oZWxwZXIoJnBy b2Nlc3MpIHsKPiAtCQlpZ3RfYXNzZXJ0KGV4ZWNsKCIvYmluL3NoIiwgInNoIiwgIi1jIiwgY29t bWFuZCwKPiAtCQkJCSAoY2hhciAqKSBOVUxMKSAhPSAtMSk7Cj4gKwkJY2xvc2Uob3V0cGlwZVsw XSk7Cj4gKwkJY2xvc2UoZXJycGlwZVswXSk7Cj4gKwo+ICsJCWlmIChkdXAyKG91dHBpcGVbMV0s IFNURE9VVF9GSUxFTk8pIDwgMCkKPiArCQkJZ290byBjaGlsZF9lcnI7Cj4gKwkJaWYgKGR1cDIo ZXJycGlwZVsxXSwgU1RERVJSX0ZJTEVOTykgPCAwKQo+ICsJCQlnb3RvIGNoaWxkX2VycjsKPiAr Cj4gKwkJZXhlY2woIi9iaW4vc2giLCAic2giLCAiLWMiLCBjb21tYW5kLAo+ICsJCSAgICAgIChj aGFyICopIE5VTEwpOwo+ICsKPiArCWNoaWxkX2VycjoKPiArCQlleGl0KEVYSVRfRkFJTFVSRSk7 Cj4gIAl9Cj4gIAo+IC0JZm9yIChpID0gMDsgaSA8IEFSUkFZX1NJWkUob3ApOyBpKyspIHsKPiAt CQlzdHJ1Y3Qgb3V0cHV0X3BpcGUgKmN1cnJlbnQgPSAmb3BbaV07Cj4gKwljbG9zZShvdXRwaXBl WzFdKTsKPiArCWNsb3NlKGVycnBpcGVbMV0pOwo+ICAKPiAtCQkvKiBVbnJlZGlyZWN0IHNvIGln dF9sb2coKSB3b3JrcyAqLwo+IC0JCXVucmVkaXJlY3Rfb3V0cHV0KGN1cnJlbnQpOwo+IC0JCW1l bXNldChidWYsIDAsIHNpemVvZihidWYpKTsKPiAtCQl3aGlsZSAocmVhZChjdXJyZW50LT5yZWFk X2ZkLCBidWYsIHNpemVvZihidWYpKSA+IDApIHsKPiAtCQkJaWd0X2xvZyhJR1RfTE9HX0RPTUFJ TiwgY3VycmVudC0+bG9nX2xldmVsLAo+IC0JCQkJIltjbWRdICVzIiwgYnVmKTsKPiAtCQkJbWVt c2V0KGJ1ZiwgMCwgc2l6ZW9mKGJ1ZikpOwo+IC0JCX0KPiAtCQljbG9zZShjdXJyZW50LT5yZWFk X2ZkKTsKPiArCXdoaWxlIChvdXRwaXBlWzBdID49IDAgfHwgZXJycGlwZVswXSA+PSAwKSB7Cj4g KwkJbG9nX291dHB1dCgmb3V0cGlwZVswXSwgSUdUX0xPR19JTkZPKTsKPiArCQlsb2dfb3V0cHV0 KCZlcnJwaXBlWzBdLCBJR1RfTE9HX1dBUk4pOwo+ICAJfQo+ICsKPiAgCXN0YXR1cyA9IGlndF93 YWl0X2hlbHBlcigmcHJvY2Vzcyk7Cj4gIAo+ICAJcmV0dXJuIFdFWElUU1RBVFVTKHN0YXR1cyk7 Cj4gIGVycjoKPiAtCS8qIEZhaWxlZCB0byByZWRpcmVjdCBvbmUgb3IgYm90aCBzdHJlYW1zLiBS b2xsIGJhY2sgY2hhbmdlcy4gKi8KPiAtCWZvciAoaSA9IDA7IGkgPCBBUlJBWV9TSVpFKG9wKTsg aSsrKSB7Cj4gLQkJaWYgKCFvcFtpXS5yZWRpcmVjdGVkKQo+IC0JCQljb250aW51ZTsKPiAtCQlj bG9zZShvcFtpXS5yZWFkX2ZkKTsKPiAtCQl1bnJlZGlyZWN0X291dHB1dCgmb3BbaV0pOwo+IC0J fQo+IC0KPiArCWNsb3NlKG91dHBpcGVbMF0pOwo+ICsJY2xvc2Uob3V0cGlwZVsxXSk7Cj4gKwlj bG9zZShlcnJwaXBlWzBdKTsKPiArCWNsb3NlKGVycnBpcGVbMV0pOwo+ICAJcmV0dXJuIC0xOwo+ ICB9Cj4gIAo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK