From: "cron2 (Code Review)" Date: Mon, 29 Jan 2024 15:05:28 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="zvwpv5SEXpg="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: gerrit-send-mail: Make output consistent across systems List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --zvwpv5SEXpg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/508?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: gerrit-send-mail: Make output consistent across systems ...................................................................... gerrit-send-mail: Make output consistent across systems When writing the file specify encoding and newline, so that the local settings (like locale) do not change the output. Change-Id: Id7b4bda38adfbb446bdac635ac5d5207ef3f2f40 Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Message-Id: <20240129145756.769-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28= 153.html Signed-off-by: Gert Doering --- M dev-tools/gerrit-send-mail.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/08/508/2 diff --git a/dev-tools/gerrit-send-mail.py b/dev-tools/gerrit-send-mail.py index 5429aef..67a2cf1 100755 --- a/dev-tools/gerrit-send-mail.py +++ b/dev-tools/gerrit-send-mail.py @@ -109,7 +109,7 @@ ) filename =3D f"gerrit-{args.changeid}-{details['revision']}.patch" patch_text_final =3D patch_text_mod.replace("Subject: [PATCH]", f"Subj= ect: [PATCH v{details['revision']}]") - with open(filename, "w") as patch_file: + with open(filename, "w", encoding=3D"utf-8", newline=3D"\n") as patch_= file: patch_file.write(patch_text_final) print("send with:") print(f"git send-email --in-reply-to {details['msg_id']} {filename}") -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/508?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id7b4bda38adfbb446bdac635ac5d5207ef3f2f40 Gerrit-Change-Number: 508 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --zvwpv5SEXpg= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #2 to the change originally cr= eated by flichtenheld.

View Change

The following approvals got outda= ted and were removed: Code-Review+2 by plaisthos

gerrit-send-mail: Make output consistent across =
systems

When writing the file specify encoding and newline, so that<= br>the local settings (like locale) do not change the output.

Change= -Id: Id7b4bda38adfbb446bdac635ac5d5207ef3f2f40
Signed-off-by: Frank Lich= tenheld <frank@...2641...>
Acked-by: Arne Schwabe <arne-openvpn= @...1227...>
Message-Id: <20240129145756.769-1-gert@...1296...>=
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/m= sg28153.html
Signed-off-by: Gert Doering <gert@...1296...>
---<= br>M dev-tools/gerrit-send-mail.py
1 file changed, 1 insertion(+), 1 del= etion(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/cha=
nges/08/508/2
diff --git a/dev-tools/gerrit-send-mail.py b/dev-tool=
s/gerrit-send-mail.py
index 5429aef..67a2cf1 100755<= br>--- a/dev-tools/gerrit-send-mail.py
+++ b/dev-tool= s/gerrit-send-mail.py
@@ -109,7 +109,7 @@
= )
filename =3D f"gerrit-{args.changeid}-{deta= ils['revision']}.patch"
patch_text_final = =3D patch_text_mod.replace("Subject: [PATCH]", f"Subject: [P= ATCH v{details['revision']}]")
- with open(filename, "w") as patch_file:=
+ with open(filen= ame, "w", encoding=3D"utf-8", newline=3D"\n")= as patch_file:
patch_file.write(patch_text_final)=
print("send with:")
pr= int(f"git send-email --in-reply-to {details['msg_id']} {filena= me}")

To view, visit change 508. To uns= ubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id7b4bda38adfbb446bdac635ac5= d5207ef3f2f40
Gerrit-Change-Number: 508
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--zvwpv5SEXpg=--