From: Markus Reichl Subject: Re: [PATCH 3/3] arm64: dts: rk3399: Add init voltage for vdd_log Date: Tue, 12 Nov 2019 12:06:36 +0100 Message-ID: References: <20191111005158.25070-1-kever.yang@rock-chips.com> <20191111005158.25070-3-kever.yang@rock-chips.com> <1eaef5d5-c923-da56-b9c4-48d517b3c969@rock-chips.com> <17e14b30-02ee-2379-8891-088677924479@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: de-DE Sender: linux-kernel-owner@vger.kernel.org To: Soeren Moch , Kever Yang , heiko@sntech.de Cc: Mark Rutland , =?UTF-8?Q?Andrius_=c5=a0tikonas?= , Vivek Unune , Alexis Ballier , devicetree@vger.kernel.org, Katsuhiro Suzuki , Robin Murphy , Elaine Zhang , linux-kernel@vger.kernel.org, Vicente Bergas , Ezequiel Garcia , linux-rockchip@lists.infradead.org, Rob Herring , Pragnesh Patel , Oskari Lemmela , Akash Gajjar , Nick Xie , Peter Robinson , Hugh Cole-Baker , linux-arm-kernel@lists.infradead.orgAnd List-Id: linux-rockchip.vger.kernel.org Dear Sore, Kever, Am 12.11.19 um 11:19 schrieb Soeren Moch: > > > On 12.11.19 11:02, Kever Yang wrote: >> Markus, >> >> >> On 2019/11/12 下午4:16, Markus Reichl wrote: >>> Hi Kever, >>> >>> have a rk3399-roc-pc running mainline U-Boot and kernel and vdd_log is >>> showing 1118 mV. >> >> The rk3399-roc-pc have the same vdd_log circuit in schematic, so it >> should like the patch 1/3 of >> >> this patch set. >> >> I don't understand who is setting this value, maybe the default value >> without pwm regulator enabled? >> >>> Is this a danger for the board? >>> How to fix it? >> >> The best way is to set correct min/max microvolt of the >> regulator(measure with PWM output low and high), > I didn't look into the schematic of this board, but if it is similar to > RockPro64, setting the pwm regulator to the max voltage of 1.7V will > probably kill the rk3399 immediately. So I recommend not to do this... > It has to be set to 450mV - 1400mV to give 953mV. I will come out with a patch that fixes this. > Regards, > Soeren >> >> (note that if  no driver touch the regulator, the PWM is default >> input, not output;) >> to >> and set a init-microvolt for U-Boot driver, and I think no kernel >> driver touch this regulator now. >> >> >> Thanks, >> >> - Kever >> >>> Btw. vin-supply for this pwm-regulator is ignored and I could not >>> find it >>> in bindings doc. >>> >>> Gruß, >> >> > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip > Gruß, -- Markus Reichl