Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CAEDEB64D9 for ; Wed, 14 Jun 2023 12:20:10 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.548731.856832 (Exim 4.92) (envelope-from ) id 1q9PTX-0003EP-8c; Wed, 14 Jun 2023 12:19:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 548731.856832; Wed, 14 Jun 2023 12:19:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q9PTX-0003EI-59; Wed, 14 Jun 2023 12:19:47 +0000 Received: by outflank-mailman (input) for mailman id 548731; Wed, 14 Jun 2023 12:19:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q9PTV-0003EC-Kr for xen-devel@lists.xenproject.org; Wed, 14 Jun 2023 12:19:45 +0000 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [2a00:1450:4864:20::232]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bd9982d2-0aad-11ee-8611-37d641c3527e; Wed, 14 Jun 2023 14:19:42 +0200 (CEST) Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2b34ac4b6e8so6080971fa.3 for ; Wed, 14 Jun 2023 05:19:42 -0700 (PDT) Received: from [192.168.202.197] ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id k15-20020a2e240f000000b002b1a872c826sm2300003ljk.61.2023.06.14.05.19.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 05:19:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bd9982d2-0aad-11ee-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686745182; x=1689337182; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=JBk7QGPl/k3z6xWNLAjbrNSZYMJ3wpeG6M6K17GGWhQ=; b=V8oBM79jiCNl9y8vK+zsQ1B0aZdFgiWiWXduV86wYWuNgJasulJUQ+IImeQthKUQMr Qhs9qNmd+P9hGVqiCXOzFrB0ILYpW8qreYXn+hhlNF3sj21Viepgxw7ySs5R54THGmBS aAu8ZeG7FiDUVolrhMgGE0sfM7akUKzngEvG7U/VkSSP9OmDa4/WmgtB01YJgcbiQ1Cl EsHXfZJHN5pG7F/BRpwy54EE2gvEdfOQqitbwFveDul5+Y8ubLzd6p/FlTZh/xHMxWjM IVJUrT5zG6XbZQaF61osnhsmWxWOCi+NmuFHtKRg73IrgAj+ZovConmAu80FCE3fkLIY zFgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686745182; x=1689337182; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=JBk7QGPl/k3z6xWNLAjbrNSZYMJ3wpeG6M6K17GGWhQ=; b=IX2TuHVx4sCD9wwch9seABdRBb5SODsVlCgjl0+6ZBp9B30jdTgjYElaYYMk3Hp/6Z ykMqEyKaFaoYKsE8MeFT2rxQLOfez/lDbGbMDfHB0H9ZFtkXanWRrtjhfKr/OvN3Wf5J iB7JmvwK9qXIctTmCyDKoAD+lvLIHP8NTxOVn0zFSPcHmRA2frKugp4paiY5GHvhW7m5 w0ythc7DaEwt2m8/sr33Xd5m+nzEGCTcKcAhEyMoCCYcTFuIFakE6zgaXfNDqIPpT5K1 SvHdjECscOuT8QF54eVxKhonNHWKQ3Hv+YBEK622soTXtpytw+7G0oNa7rIM07dFtd8g bKVw== X-Gm-Message-State: AC+VfDycQus9Pw6BaVDpWDfSvVP/rcLTGfwC4Nv5aoQ0KPjQI1iZn0hQ 0Vx1lvXBSJRwnKLQiY0rP5g= X-Google-Smtp-Source: ACHHUZ7KIM6IPBOrkXoXTUM/sa5j4rTNSIvuJ78ygkqwyXvhdJUmmMTVTeXpn1XcwXKZWWVhYBWiJQ== X-Received: by 2002:a2e:850d:0:b0:2b1:c0f8:9b95 with SMTP id j13-20020a2e850d000000b002b1c0f89b95mr6717422lji.19.1686745181295; Wed, 14 Jun 2023 05:19:41 -0700 (PDT) Message-ID: Subject: Re: [PATCH v1 3/8] xen/riscv: introduce reset_stack() function From: Oleksii To: Jan Beulich Cc: Andrew Cooper , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org Date: Wed, 14 Jun 2023 15:19:40 +0300 In-Reply-To: <92fab0b8-647a-b9c1-d15b-1217a4420715@suse.com> References: <92fab0b8-647a-b9c1-d15b-1217a4420715@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) MIME-Version: 1.0 On Mon, 2023-06-12 at 09:12 +0200, Jan Beulich wrote: > On 06.06.2023 21:55, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko >=20 > This wants addressing the "Why?" aspect in the description. Is the > present > code wrong in some perhaps subtle way? Are you meaning to re-use the > code? > If so, in which way (which is relevant to determine whether the new > function may actually continue to live in .text.header)? >=20 As I mentioned in previous e-mail there is no such requirement for reset_stack() function to live in .text.header. I think such requirement exists only for _start() function as we would like to see it at the start of image as a bootloader jumps to it and it is expected to be the first instructions. Even though I don't see any issue for reset_stack() to live in .text.header section, should it be moved to .text section? If yes, I would appreciate hearing why it would be better. ~ Oleksii