Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D255EC48BDF for ; Fri, 18 Jun 2021 06:04:48 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 447CB6109D for ; Fri, 18 Jun 2021 06:04:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 447CB6109D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E85F882B1C; Fri, 18 Jun 2021 08:04:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1623996286; bh=kGL91E4itbjRMRqMIaPmy3iyI4NU52aHP3vNKD36DbE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=MLk7Hafcy5hKGgtxCBXpgX/IMTghk6pI7gzn+AFDoxmvShJFW1njekpPp4gFHWt6v DnKWvEaz1aNmLrewZqJCh6akwwwmNNAYTw5p//r0ycM+Omprxb21uvrstiAMfgeVRP sVGW5OmykzZaHOgH82YpG1vJ7ah4M6dAc/THcM0aLLx7mAAJXJ3T0UU1N3i2HtfJww Bf1XTRNMI+EMX3VMYtlTuveR6IGpSHOay8zUL5bv8N5t7iUt7Sxah+asCYJy6JgXll 5rZ+PU8QRh/M2rVFSATzqxJPY26JZaSVcN5AsHLd9Xn6SlnGlCpUnzIJlWhsDzWRI8 5uvKiJ9dGQbsg== Received: by phobos.denx.de (Postfix, from userid 109) id 4FB7382B48; Fri, 18 Jun 2021 08:04:44 +0200 (CEST) Received: from mout-u-204.mailbox.org (mout-u-204.mailbox.org [IPv6:2001:67c:2050:1::465:204]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 86C6881DB3 for ; Fri, 18 Jun 2021 08:04:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:105:465:1:2:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4G5pKj2BdmzQjYX; Fri, 18 Jun 2021 08:04:41 +0200 (CEST) Received: from smtp2.mailbox.org ([80.241.60.241]) by hefe.heinlein-support.de (hefe.heinlein-support.de [91.198.250.172]) (amavisd-new, port 10030) with ESMTP id J96myxrnlelX; Fri, 18 Jun 2021 08:04:38 +0200 (CEST) Subject: Re: [PATCH] octeontx: do not require cavium BDK node to be present To: Tim Harvey , Aaron Williams Cc: Suneel Garapati , u-boot@lists.denx.de References: <20210617233107.14169-1-tharvey@gateworks.com> From: Stefan Roese Message-ID: Date: Fri, 18 Jun 2021 08:04:37 +0200 MIME-Version: 1.0 In-Reply-To: <20210617233107.14169-1-tharvey@gateworks.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit X-MBO-SPAM-Probability: X-Rspamd-Score: -5.16 / 15.00 / 15.00 X-Rspamd-Queue-Id: 44AFF1818 X-Rspamd-UID: 04b15f X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 18.06.21 01:31, Tim Harvey wrote: > The cavium,bdk node is a non-standard dt node used by the BDK and > therefore it is removed from the dt before booting Linux. Do not > require this node to exist as it won't for standard dt's. > > Signed-off-by: Tim Harvey Reviewed-by: Stefan Roese Thanks, Stefan > --- > board/Marvell/octeontx/board-fdt.c | 20 ++++++++------------ > 1 file changed, 8 insertions(+), 12 deletions(-) > > diff --git a/board/Marvell/octeontx/board-fdt.c b/board/Marvell/octeontx/board-fdt.c > index 0b05ef11e9..1db2a4a267 100644 > --- a/board/Marvell/octeontx/board-fdt.c > +++ b/board/Marvell/octeontx/board-fdt.c > @@ -281,20 +281,16 @@ int ft_board_setup(void *blob, struct bd_info *bd) > } > > if (blob) { > + /* delete cavium,bdk node if it exists */ > offset = fdt_path_offset(blob, "/cavium,bdk"); > - if (offset < 0) { > - printf("ERROR: FDT BDK node not found\n"); > - return offset; > - } > - > - /* delete node */ > - ret = fdt_del_node(blob, offset); > - if (ret < 0) { > - printf("WARNING : could not remove bdk node\n"); > - return ret; > + if (offset >= 0) { > + ret = fdt_del_node(blob, offset); > + if (ret < 0) { > + printf("WARNING : could not remove bdk node\n"); > + return ret; > + } > + debug("%s deleted bdk node\n", __func__); > } > - > - debug("%s deleted bdk node\n", __func__); > } > > return 0; > Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de