From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH v2 1/2] drm/amdgpu: Remove the sriov checking and add firmware checking Date: Fri, 17 Aug 2018 09:23:27 +0200 Message-ID: References: <1534484401-1805-1-git-send-email-Emily.Deng@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1534484401-1805-1-git-send-email-Emily.Deng-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Emily Deng , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org QW0gMTcuMDguMjAxOCB1bSAwNzo0MCBzY2hyaWViIEVtaWx5IERlbmc6Cj4gUmVmaW5lIHRoZSBw YXRjaCAxLCBhbmQgdGhlIGxvY2sgYWJvdXQgaW52YWxpZGF0ZV9sb2NrLgo+Cj4gVW5pZnkgYmFy ZSBtZXRhbCBhbmQgc3Jpb3YsIGFuZCBhZGQgZmlybXdhcmUgY2hlY2tpbmcgZm9yCj4gcmVnIHdy aXRlIGFuZCByZWcgd2FpdCB1bmlmeSBjb21tYW5kLgo+Cj4gU2lnbmVkLW9mZi1ieTogRW1pbHkg RGVuZyA8RW1pbHkuRGVuZ0BhbWQuY29tPgoKQWNrZWQtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNo cmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4gZm9yIHRoaXMgb25lIApiZWNhdXNlIEkgY2FuJ3QgdmVy aWZ5IHRoZSBmaXJtd2FyZSBudW1iZXJzLgoKUmV2aWV3ZWQtYnk6IENocmlzdGlhbiBLw7ZuaWcg PGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4gZm9yIHBhdGNoICMyLgoKSSBjYW4gZ2l2ZSB0aGUg dHdvIHBhdGNoZXMgYSB0ZXN0aW5nIG9uIGJhcmUgbWV0YWwgVmVnYTEwIGFuZCBSYXZlbiAKbGF0 ZXIgdG9kYXkgaWYgbm9ib2R5IGJlYXRzIG1lIG9uIHRoaXMuCgpUaGFua3MgZm9yIHRoZSBwYXRp ZW5jZSwgdGhhdCBsb29rcyAqbXVjaCogYmV0dGVyIG5vdyB0aGF0IHdlIGhhdmUgYW4gCnVuaWZp ZWQgY29kZSBwYXRoLApDaHJpc3RpYW4uCgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X2dmeC5oIHwgIDIgKysKPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1 L2dmeF92OV8wLmMgICB8IDU5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLQo+ICAg MiBmaWxlcyBjaGFuZ2VkLCA2MCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4KPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2dmeC5oIGIvZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2dmeC5oCj4gaW5kZXggNTNlOWUyYS4uZjE3MmU5 MiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ2Z4LmgK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ2Z4LmgKPiBAQCAtMjc0 LDYgKzI3NCw4IEBAIHN0cnVjdCBhbWRncHVfZ2Z4IHsKPiAgIAl1aW50MzJfdAkJCXJsY19zcmxz X2ZlYXR1cmVfdmVyc2lvbjsKPiAgIAl1aW50MzJfdAkJCW1lY19mZWF0dXJlX3ZlcnNpb247Cj4g ICAJdWludDMyX3QJCQltZWMyX2ZlYXR1cmVfdmVyc2lvbjsKPiArCWJvb2wJCQkJbWVjX2Z3X3dy aXRlX3dhaXQ7Cj4gKwlib29sCQkJCW1lX2Z3X3dyaXRlX3dhaXQ7Cj4gICAJc3RydWN0IGFtZGdw dV9yaW5nCQlnZnhfcmluZ1tBTURHUFVfTUFYX0dGWF9SSU5HU107Cj4gICAJdW5zaWduZWQJCQlu dW1fZ2Z4X3JpbmdzOwo+ICAgCXN0cnVjdCBhbWRncHVfcmluZwkJY29tcHV0ZV9yaW5nW0FNREdQ VV9NQVhfQ09NUFVURV9SSU5HU107Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2dmeF92OV8wLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nZnhfdjlfMC5j Cj4gaW5kZXggNGUxZTFhMC4uMGNiYTQzMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9nZnhfdjlfMC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUv Z2Z4X3Y5XzAuYwo+IEBAIC00ODIsNiArNDgyLDU5IEBAIHN0YXRpYyB2b2lkIGdmeF92OV8wX2lu aXRfcmxjX2V4dF9taWNyb2NvZGUoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4gICAJCQls ZTMyX3RvX2NwdShybGNfaGRyLT5yZWdfbGlzdF9mb3JtYXRfZGlyZWN0X3JlZ19saXN0X2xlbmd0 aCk7Cj4gICB9Cj4gICAKPiArc3RhdGljIHZvaWQgZ2Z4X3Y5XzBfY2hlY2tfZndfd3JpdGVfd2Fp dChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldikKPiArewo+ICsJYWRldi0+Z2Z4Lm1lX2Z3X3dy aXRlX3dhaXQgPSBmYWxzZTsKPiArCWFkZXYtPmdmeC5tZWNfZndfd3JpdGVfd2FpdCA9IGZhbHNl Owo+ICsKPiArCXN3aXRjaCAoYWRldi0+YXNpY190eXBlKSB7Cj4gKwljYXNlIENISVBfVkVHQTEw Ogo+ICsJCWlmICgoYWRldi0+Z2Z4Lm1lX2Z3X3ZlcnNpb24gPj0gMHgwMDAwMDA5YykgJiYKPiAr CQkgICAgKGFkZXYtPmdmeC5tZV9mZWF0dXJlX3ZlcnNpb24gPj0gNDIpICYmCj4gKwkJICAgIChh ZGV2LT5nZngucGZwX2Z3X3ZlcnNpb24gPj0gIDB4MDAwMDAwYjEpICYmCj4gKwkJICAgIChhZGV2 LT5nZngucGZwX2ZlYXR1cmVfdmVyc2lvbiA+PSA0MikpCj4gKwkJCWFkZXYtPmdmeC5tZV9md193 cml0ZV93YWl0ID0gdHJ1ZTsKPiArCj4gKwkJaWYgKChhZGV2LT5nZngubWVjX2Z3X3ZlcnNpb24g Pj0gIDB4MDAwMDAxOTMpICYmCj4gKwkJICAgIChhZGV2LT5nZngubWVjX2ZlYXR1cmVfdmVyc2lv biA+PSA0MikpCj4gKwkJCWFkZXYtPmdmeC5tZWNfZndfd3JpdGVfd2FpdCA9IHRydWU7Cj4gKwkJ YnJlYWs7Cj4gKwljYXNlIENISVBfVkVHQTEyOgo+ICsJCWlmICgoYWRldi0+Z2Z4Lm1lX2Z3X3Zl cnNpb24gPj0gMHgwMDAwMDA5YykgJiYKPiArCQkgICAgKGFkZXYtPmdmeC5tZV9mZWF0dXJlX3Zl cnNpb24gPj0gNDQpICYmCj4gKwkJICAgIChhZGV2LT5nZngucGZwX2Z3X3ZlcnNpb24gPj0gIDB4 MDAwMDAwYjIpICYmCj4gKwkJICAgIChhZGV2LT5nZngucGZwX2ZlYXR1cmVfdmVyc2lvbiA+PSA0 NCkpCj4gKwkJCWFkZXYtPmdmeC5tZV9md193cml0ZV93YWl0ID0gdHJ1ZTsKPiArCj4gKwkJaWYg KChhZGV2LT5nZngubWVjX2Z3X3ZlcnNpb24gPj0gIDB4MDAwMDAxOTYpICYmCj4gKwkJICAgIChh ZGV2LT5nZngubWVjX2ZlYXR1cmVfdmVyc2lvbiA+PSA0NCkpCj4gKwkJCWFkZXYtPmdmeC5tZWNf Zndfd3JpdGVfd2FpdCA9IHRydWU7Cj4gKwkJYnJlYWs7Cj4gKwljYXNlIENISVBfVkVHQTIwOgo+ ICsJCWlmICgoYWRldi0+Z2Z4Lm1lX2Z3X3ZlcnNpb24gPj0gMHgwMDAwMDA5YykgJiYKPiArCQkg ICAgKGFkZXYtPmdmeC5tZV9mZWF0dXJlX3ZlcnNpb24gPj0gNDQpICYmCj4gKwkJICAgIChhZGV2 LT5nZngucGZwX2Z3X3ZlcnNpb24gPj0gIDB4MDAwMDAwYjIpICYmCj4gKwkJICAgIChhZGV2LT5n ZngucGZwX2ZlYXR1cmVfdmVyc2lvbiA+PSA0NCkpCj4gKwkJCWFkZXYtPmdmeC5tZV9md193cml0 ZV93YWl0ID0gdHJ1ZTsKPiArCj4gKwkJaWYgKChhZGV2LT5nZngubWVjX2Z3X3ZlcnNpb24gPj0g IDB4MDAwMDAxOTcpICYmCj4gKwkJICAgIChhZGV2LT5nZngubWVjX2ZlYXR1cmVfdmVyc2lvbiA+ PSA0NCkpCj4gKwkJCWFkZXYtPmdmeC5tZWNfZndfd3JpdGVfd2FpdCA9IHRydWU7Cj4gKwkJYnJl YWs7Cj4gKwljYXNlIENISVBfUkFWRU46Cj4gKwkJaWYgKChhZGV2LT5nZngubWVfZndfdmVyc2lv biA+PSAweDAwMDAwMDljKSAmJgo+ICsJCSAgICAoYWRldi0+Z2Z4Lm1lX2ZlYXR1cmVfdmVyc2lv biA+PSA0MikgJiYKPiArCQkgICAgKGFkZXYtPmdmeC5wZnBfZndfdmVyc2lvbiA+PSAgMHgwMDAw MDBiMSkgJiYKPiArCQkgICAgKGFkZXYtPmdmeC5wZnBfZmVhdHVyZV92ZXJzaW9uID49IDQyKSkK PiArCQkJYWRldi0+Z2Z4Lm1lX2Z3X3dyaXRlX3dhaXQgPSB0cnVlOwo+ICsKPiArCQlpZiAoKGFk ZXYtPmdmeC5tZWNfZndfdmVyc2lvbiA+PSAgMHgwMDAwMDE5MikgJiYKPiArCQkgICAgKGFkZXYt PmdmeC5tZWNfZmVhdHVyZV92ZXJzaW9uID49IDQyKSkKPiArCQkJYWRldi0+Z2Z4Lm1lY19md193 cml0ZV93YWl0ID0gdHJ1ZTsKPiArCQlicmVhazsKPiArCX0KPiArfQo+ICsKPiAgIHN0YXRpYyBp bnQgZ2Z4X3Y5XzBfaW5pdF9taWNyb2NvZGUoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4g ICB7Cj4gICAJY29uc3QgY2hhciAqY2hpcF9uYW1lOwo+IEBAIC03MTYsNiArNzY5LDcgQEAgc3Rh dGljIGludCBnZnhfdjlfMF9pbml0X21pY3JvY29kZShzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRl dikKPiAgIAl9Cj4gICAKPiAgIG91dDoKPiArCWdmeF92OV8wX2NoZWNrX2Z3X3dyaXRlX3dhaXQo YWRldik7Cj4gICAJaWYgKGVycikgewo+ICAgCQlkZXZfZXJyKGFkZXYtPmRldiwKPiAgIAkJCSJn Zng5OiBGYWlsZWQgdG8gbG9hZCBmaXJtd2FyZSBcIiVzXCJcbiIsCj4gQEAgLTQzNTMsOCArNDQw NywxMSBAQCBzdGF0aWMgdm9pZCBnZnhfdjlfMF9yaW5nX2VtaXRfcmVnX3dyaXRlX3JlZ193YWl0 KHN0cnVjdCBhbWRncHVfcmluZyAqcmluZywKPiAgIAkJCQkJCSAgdWludDMyX3QgcmVmLCB1aW50 MzJfdCBtYXNrKQo+ICAgewo+ICAgCWludCB1c2VwZnAgPSAocmluZy0+ZnVuY3MtPnR5cGUgPT0g QU1ER1BVX1JJTkdfVFlQRV9HRlgpOwo+ICsJc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYgPSBy aW5nLT5hZGV2Owo+ICsJYm9vbCBmd192ZXJzaW9uX29rID0gKHJpbmctPmZ1bmNzLT50eXBlID09 IEFNREdQVV9SSU5HX1RZUEVfR0ZYKSA/Cj4gKwkJYWRldi0+Z2Z4Lm1lX2Z3X3dyaXRlX3dhaXQg OiBhZGV2LT5nZngubWVjX2Z3X3dyaXRlX3dhaXQ7Cj4gICAKPiAtCWlmIChhbWRncHVfc3Jpb3Zf dmYocmluZy0+YWRldikpCj4gKwlpZiAoZndfdmVyc2lvbl9vaykKPiAgIAkJZ2Z4X3Y5XzBfd2Fp dF9yZWdfbWVtKHJpbmcsIHVzZXBmcCwgMCwgMSwgcmVnMCwgcmVnMSwKPiAgIAkJCQkgICAgICBy ZWYsIG1hc2ssIDB4MjApOwo+ICAgCWVsc2UKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vYW1kLWdmeAo=