Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C793C433EF for ; Tue, 26 Jul 2022 00:51:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230112AbiGZAvM (ORCPT ); Mon, 25 Jul 2022 20:51:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230247AbiGZAvL (ORCPT ); Mon, 25 Jul 2022 20:51:11 -0400 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF34C140FD for ; Mon, 25 Jul 2022 17:51:10 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 7AA765C00CE; Mon, 25 Jul 2022 20:51:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 25 Jul 2022 20:51:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-id:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1658796667; x=1658883067; bh=M/WDU4tI4EEY0 hnCnjZh/nF+JXQXLA4WTQdigik0Ic4=; b=kz4Nos2R91H+Y/HSHwa3fK0mriSIg yOQSPi66heTQsTc8F/Ssi0nc7cGKYQa1SFewibQM6AcOvbH42XPqDjoruYgJeh8c k+cn7kyQ8bDX5tbnLqcPyMEKISbA3Nis7jN/r2Wo2OnXap+ssqqT53dSOD1xyIlP 8Cz5FRgAkY8kPdjB3juC8NlJlSmpRvDUiNzeKcPCxPR6SY26O9VvkaRJUYkMj6LI h9JEYRZPoLMXJqBu1xsqtV7el+vBlsYdu2HcwIYGnsiv9DtPVGxkYWzb9Pcf3DHl nF+LDxqz9zYhEPazTZ6x026Cx18hDUR9/IIueSXkxuuoTXlNkcVHzt79A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtledgfeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevufgjkfhfgggtsehmtderredttdejnecuhfhrohhmpefhihhnnhcu vfhhrghinhcuoehfthhhrghinheslhhinhhugidqmheikehkrdhorhhgqeenucggtffrrg htthgvrhhnpeelfeeklefggfetkedukeevfffgvdeuheetffekledtfeejteelieejteeh geelieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hfthhhrghinheslhhinhhugidqmheikehkrdhorhhg X-ME-Proxy: Feedback-ID: i58a146ae:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Jul 2022 20:51:03 -0400 (EDT) Date: Tue, 26 Jul 2022 10:50:56 +1000 (AEST) From: Finn Thain To: Bart Van Assche cc: peter.wang@mediatek.com, stanley.chu@mediatek.com, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, avri.altman@wdc.com, alim.akhtar@samsung.com, jejb@linux.ibm.com, wsd_upstream@mediatek.com, linux-mediatek@lists.infradead.org, chun-hung.wu@mediatek.com, alice.chao@mediatek.com, cc.chou@mediatek.com, chaotian.jing@mediatek.com, jiajie.hao@mediatek.com, powen.kao@mediatek.com, qilin.tan@mediatek.com, lin.gui@mediatek.com Subject: Re: [PATCH v1] ufs: core: change comment message to popular format In-Reply-To: Message-ID: References: <20220725131558.13219-1-peter.wang@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="-1463811774-132907978-1658795837=:30080" Content-ID: Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463811774-132907978-1658795837=:30080 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Content-ID: <90cc7f52-fc8e-aee1-574c-ae11d18adb8b@nippy.intranet> On Mon, 25 Jul 2022, Bart Van Assche wrote: > On 7/25/22 06:15, peter.wang@mediatek.com wrote: > > From: Peter Wang > >=20 > > Some editor cannot display =E2=80=980=E2=80=99 =E2=80=981=E2=80=99 in c= orrect format. > > Change it to '0' '1' for most editor can display. >=20 > As far as I know checkpatch accepts non-ASCII UTF-8 characters. Using=20 > this encoding is essential to spell non-English names correctly in=20 > source files.=20 The only foreign language that's relevant in the context of this=20 particular comment is C. Writing '0' to indicate a char value would be=20 fine but this is not a char value. Quoted and unquoted zeros are used inconsistently in this comment, though= =20 the patch does not address this unfortunately. > I don't think it's feasible nor desirable to eliminate all non-ASCII=20 > UTF-8 from kernel source code files. That's neither here nor there -- I don't think it's feasible or desirable= =20 to eliminate all bugs from the kernel source code files. One man's bug is= =20 another man's feature e.g. bloat, choice of programming language,=20 interpretation of license terms. > Maybe this means that it's time to switch to another editor? >=20 It's not hard to find more tooling that is impacted by misplaced unicode.= =20 The security vulnerabilities stemming from the use of Unicode in source=20 files are telling. Unicode doesn't help here so it shouldn't have been used here IMO. ---1463811774-132907978-1658795837=:30080--