From: Maarten Lankhorst Subject: Re: [PATCH 2/3] drm/i915/icl: Add icl pipe degamma and gamma support Date: Wed, 24 Oct 2018 15:33:39 +0200 Message-ID: References: <1540327255-25639-1-git-send-email-uma.shankar@intel.com> <1540327255-25639-3-git-send-email-uma.shankar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 19B846E15D for ; Wed, 24 Oct 2018 13:33:42 +0000 (UTC) In-Reply-To: <1540327255-25639-3-git-send-email-uma.shankar@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Uma Shankar , intel-gfx@lists.freedesktop.org Cc: ville.syrjala@intel.com, maarten.lankhorst@intel.com List-Id: intel-gfx@lists.freedesktop.org T3AgMjMtMTAtMTggb20gMjI6NDAgc2NocmVlZiBVbWEgU2hhbmthcjoKPiBBZGQgc3VwcG9ydCBm b3IgaWNsIHBpcGUgZGVnYW1tYSBhbmQgZ2FtbWEuCj4KPiBTaWduZWQtb2ZmLWJ5OiBVbWEgU2hh bmthciA8dW1hLnNoYW5rYXJAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X3JlZy5oICAgIHwgIDMgKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY29s b3IuYyB8IDc1ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIDIgZmls ZXMgY2hhbmdlZCwgNzggaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfcmVnLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4g aW5kZXggOGJkNjFmOS4uZGQwNTE0ZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X3JlZy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+IEBA IC02OTY1LDYgKzY5NjUsOSBAQCBlbnVtIHsKPiAgI2RlZmluZSBHQU1NQV9NT0RFX01PREVfMTJC SVQJKDIgPDwgMCkKPiAgI2RlZmluZSBHQU1NQV9NT0RFX01PREVfU1BMSVQJKDMgPDwgMCkKPiAg Cj4gKyNkZWZpbmUgUFJFX0NTQ19HQU1NQV9FTkFCTEUJKDEgPDwgMzEpCj4gKyNkZWZpbmUgUE9T VF9DU0NfR0FNTUFfRU5BQkxFCSgxIDw8IDMxKQo/IFRoaXMgY2FuJ3QgYmUgcmlnaHQuCj4gIC8q IERNQy9DU1IgKi8KPiAgI2RlZmluZSBDU1JfUFJPR1JBTShpKQkJX01NSU8oMHg4MDAwMCArIChp KSAqIDQpCj4gICNkZWZpbmUgQ1NSX1NTUF9CQVNFX0FERFJfR0VOOQkweDAwMDAyRkMwCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbG9yLmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jCj4gaW5kZXggNTEyN2RhMi4uNzg2MDI0NCAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfY29sb3IuYwo+IEBAIC00MjQsNiArNDI0LDcgQEAgc3RhdGlj IHZvaWQgYmR3X2xvYWRfZ2FtbWFfbHV0KHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqc3RhdGUsIHUz MiBvZmZzZXQpCj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1 KHN0YXRlLT5jcnRjLT5kZXYpOwo+ICAJZW51bSBwaXBlIHBpcGUgPSB0b19pbnRlbF9jcnRjKHN0 YXRlLT5jcnRjKS0+cGlwZTsKPiAgCXVpbnQzMl90IGksIGx1dF9zaXplID0gSU5URUxfSU5GTyhk ZXZfcHJpdiktPmNvbG9yLmdhbW1hX2x1dF9zaXplOwo+ICsJdWludDMyX3QgdG1wOwo+ICAKPiAg CVdBUk5fT04ob2Zmc2V0ICYgflBBTF9QUkVDX0lOREVYX1ZBTFVFX01BU0spOwo+ICAKPiBAQCAt NDY0LDYgKzQ2NSwxMSBAQCBzdGF0aWMgdm9pZCBiZHdfbG9hZF9nYW1tYV9sdXQoc3RydWN0IGRy bV9jcnRjX3N0YXRlICpzdGF0ZSwgdTMyIG9mZnNldCkKPiAgCQlJOTE1X1dSSVRFKFBSRUNfUEFM X0dDX01BWChwaXBlLCAxKSwgKDEgPDwgMTYpIC0gMSk7Cj4gIAkJSTkxNV9XUklURShQUkVDX1BB TF9HQ19NQVgocGlwZSwgMiksICgxIDw8IDE2KSAtIDEpOwo+ICAJfQo+ICsKPiArCWlmIChJU19J Q0VMQUtFKGRldl9wcml2KSkgewo+ICsJCXRtcCA9IEk5MTVfUkVBRChHQU1NQV9NT0RFKHBpcGUp KTsKPiArCQlJOTE1X1dSSVRFKEdBTU1BX01PREUocGlwZSksIHRtcCB8IFBPU1RfQ1NDX0dBTU1B X0VOQUJMRSk7Cj4gKwl9CkNvdWxkIHdlIGp1c3QgcHJvZ3JhbSB0aGUgYml0cyB3ZSBjYXJlIGFi b3V0LCBpbnN0ZWFkIG9mIGRvaW5nIHRoaXMgcmVhZD8KPiAgfQo+ICAKPiAgLyogTG9hZHMgdGhl IHBhbGV0dGUvZ2FtbWEgdW5pdCBmb3IgdGhlIENSVEMgb24gQnJvYWR3ZWxsKy4gKi8KPiBAQCAt NTIzLDYgKzUyOSw1MCBAQCBzdGF0aWMgdm9pZCBnbGtfbG9hZF9kZWdhbW1hX2x1dChzdHJ1Y3Qg ZHJtX2NydGNfc3RhdGUgKnN0YXRlKQo+ICAJCUk5MTVfV1JJVEUoUFJFX0NTQ19HQU1DX0RBVEEo cGlwZSksICgxIDw8IDE2KSk7Cj4gIH0KPiAgCj4gK3N0YXRpYyB2b2lkIGljbF9sb2FkX2RlZ2Ft bWFfbHV0KHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqc3RhdGUpCj4gK3sKPiArCXN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoc3RhdGUtPmNydGMtPmRldik7Cj4gKwll bnVtIHBpcGUgcGlwZSA9IHRvX2ludGVsX2NydGMoc3RhdGUtPmNydGMpLT5waXBlOwo+ICsJY29u c3QgdWludDMyX3QgbHV0X3NpemUgPSAzMzsKPiArCXVpbnQzMl90IHRtcCwgaTsKPiArCj4gKwkv Kgo+ICsJICogV2hlbiBzZXR0aW5nIHRoZSBhdXRvLWluY3JlbWVudCBiaXQsIHRoZSBoYXJkd2Fy ZSBzZWVtcyB0bwo+ICsJICogaWdub3JlIHRoZSBpbmRleCBiaXRzLCBzbyB3ZSBuZWVkIHRvIHJl c2V0IGl0IHRvIGluZGV4IDAKPiArCSAqIHNlcGFyYXRlbHkuCj4gKwkgKi8KPiArCUk5MTVfV1JJ VEUoUFJFX0NTQ19HQU1DX0lOREVYKHBpcGUpLCAwKTsKPiArCUk5MTVfV1JJVEUoUFJFX0NTQ19H QU1DX0lOREVYKHBpcGUpLCBQUkVfQ1NDX0dBTUNfQVVUT19JTkNSRU1FTlQpOwo+ICsKPiArCWlm IChzdGF0ZS0+ZGVnYW1tYV9sdXQpIHsKPiArCQlzdHJ1Y3QgZHJtX2NvbG9yX2x1dCAqbHV0ID0K PiArCQkJKHN0cnVjdCBkcm1fY29sb3JfbHV0ICopIHN0YXRlLT5kZWdhbW1hX2x1dC0+ZGF0YTsK PiArCQlmb3IgKGkgPSAwOyBpIDwgbHV0X3NpemU7IGkrKykgewo+ICsJCQkvKgo+ICsJCQkgKiBD dXJyZW50bHkgQ2xhbXAgaW5wdXQgdG8gMS4wLgo+ICsJCQkgKiBUb0RvOiBFeHRlbmQgdG8gbWF4 IDcuMC4KPiArCQkJICovCj4gKwkJCXVpbnQzMl90IHdvcmQgPQo+ICsJCQkJZHJtX2NvbG9yX2x1 dF9leHRyYWN0KGx1dFtpXS5yZWQsIDE2KTsKPiArCQkJSTkxNV9XUklURShQUkVfQ1NDX0dBTUNf REFUQShwaXBlKSwgd29yZCk7Cj4gKwkJfQo+ICsJfSBlbHNlIHsKPiArCQkvKiBsb2FkIGEgbGlu ZWFyIHRhYmxlLiAqLwo+ICsJCWZvciAoaSA9IDA7IGkgPCBsdXRfc2l6ZTsgaSsrKSB7Cj4gKwkJ CXVpbnQzMl90IHYgPSAoaSAqICgxIDw8IDE2KSkgLyAobHV0X3NpemUgLSAxKTsKPiArCj4gKwkJ CUk5MTVfV1JJVEUoUFJFX0NTQ19HQU1DX0RBVEEocGlwZSksIHYpOwo+ICsJCX0KPiArCX0KPiAr Cj4gKwl0bXAgPSBJOTE1X1JFQUQoR0FNTUFfTU9ERShwaXBlKSk7Cj4gKwlJOTE1X1dSSVRFKEdB TU1BX01PREUocGlwZSksIHRtcCB8IFBSRV9DU0NfR0FNTUFfRU5BQkxFKTsKU2FtZSBoZXJlLi4g d2Uga25vdyB3aGF0IGdhbW1hIG1vZGUgc2hvdWxkIGJlLgo+ICsKPiArCS8qIENsYW1wIHZhbHVl cyA+IDEuMC4gKi8KPiArCXdoaWxlIChpKysgPCAzNSkKPiArCQlJOTE1X1dSSVRFKFBSRV9DU0Nf R0FNQ19EQVRBKHBpcGUpLCAoMSA8PCAxNikpOwo+ICt9Cj4gKwo+ICBzdGF0aWMgdm9pZCBnbGtf bG9hZF9sdXRzKHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqc3RhdGUpCj4gIHsKPiAgCXN0cnVjdCBk cm1fY3J0YyAqY3J0YyA9IHN0YXRlLT5jcnRjOwo+IEBAIC02MDYsNiArNjU2LDI5IEBAIHN0YXRp YyB2b2lkIGNoZXJyeXZpZXdfbG9hZF9sdXRzKHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqc3RhdGUp Cj4gIAlpOXh4X2xvYWRfbHV0c19pbnRlcm5hbChjcnRjLCBOVUxMLCB0b19pbnRlbF9jcnRjX3N0 YXRlKHN0YXRlKSk7Cj4gIH0KPiAgCj4gK3N0YXRpYyB2b2lkIGljbF9sb2FkX2x1dHMoc3RydWN0 IGRybV9jcnRjX3N0YXRlICpzdGF0ZSkKPiArewo+ICsJc3RydWN0IGRybV9jcnRjICpjcnRjID0g c3RhdGUtPmNydGM7Cj4gKwlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gY3J0Yy0+ZGV2Owo+ICsJ c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShkZXYpOwo+ICsJc3Ry dWN0IGludGVsX2NydGNfc3RhdGUgKmludGVsX3N0YXRlID0gdG9faW50ZWxfY3J0Y19zdGF0ZShz dGF0ZSk7Cj4gKwllbnVtIHBpcGUgcGlwZSA9IHRvX2ludGVsX2NydGMoY3J0YyktPnBpcGU7Cj4g Kwo+ICsJaWNsX2xvYWRfZGVnYW1tYV9sdXQoc3RhdGUpOwo+ICsKPiArCWlmIChjcnRjX3N0YXRl X2lzX2xlZ2FjeV9nYW1tYShzdGF0ZSkpIHsKPiArCQloYXN3ZWxsX2xvYWRfbHV0cyhzdGF0ZSk7 Cj4gKwkJcmV0dXJuOwo+ICsJfQo+ICsKPiArCWJkd19sb2FkX2dhbW1hX2x1dChzdGF0ZSwgMCk7 Cj4gKwlpbnRlbF9zdGF0ZS0+Z2FtbWFfbW9kZSA9IEdBTU1BX01PREVfTU9ERV8xMEJJVDsKPiAr Cj4gKwlJOTE1X1dSSVRFKEdBTU1BX01PREUocGlwZSksIEk5MTVfUkVBRChHQU1NQV9NT0RFKHBp cGUpKSB8Cj4gKwkJCWludGVsX3N0YXRlLT5nYW1tYV9tb2RlKTsKPiArCVBPU1RJTkdfUkVBRChH QU1NQV9NT0RFKHBpcGUpKTsKUG9zdGluZyByZWFkIGNhbiBiZSByZW1vdmVkLgo+ICt9Cj4gKwo+ ICB2b2lkIGludGVsX2NvbG9yX2xvYWRfbHV0cyhzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNf c3RhdGUpCj4gIHsKPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjcnRjX3N0YXRlLT5jcnRj LT5kZXY7Cj4gQEAgLTY2Miw2ICs3MzUsOCBAQCB2b2lkIGludGVsX2NvbG9yX2luaXQoc3RydWN0 IGRybV9jcnRjICpjcnRjKQo+ICAJfSBlbHNlIGlmIChJU19HRU1JTklMQUtFKGRldl9wcml2KSB8 fCBJU19DQU5OT05MQUtFKGRldl9wcml2KSkgewo+ICAJCWRldl9wcml2LT5kaXNwbGF5LmxvYWRf Y3NjX21hdHJpeCA9IGlsa19sb2FkX2NzY19tYXRyaXg7Cj4gIAkJZGV2X3ByaXYtPmRpc3BsYXku bG9hZF9sdXRzID0gZ2xrX2xvYWRfbHV0czsKPiArCX0gZWxzZSBpZiAoSVNfSUNFTEFLRShkZXZf cHJpdikpIHsKPiArCQlkZXZfcHJpdi0+ZGlzcGxheS5sb2FkX2x1dHMgPSBpY2xfbG9hZF9sdXRz Owo+ICAJfSBlbHNlIHsKPiAgCQlkZXZfcHJpdi0+ZGlzcGxheS5sb2FkX2x1dHMgPSBpOXh4X2xv YWRfbHV0czsKPiAgCX0KCkp1c3QgY3VyaW91cywgaG93IHdhcyB0aGlzIHRlc3RlZCBpZiB3ZSB3 cm9uZ2x5IGRlZmluZWQgdGhlIFBvc3QgQ1NDIGdhbW1hIGJpdD8KCn5NYWFydGVuCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK