Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFCD6C4338F for ; Wed, 28 Jul 2021 23:37:20 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D16966101B for ; Wed, 28 Jul 2021 23:37:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D16966101B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4246582D73; Thu, 29 Jul 2021 01:37:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="AcmZ2PNY"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 85C0F82CDA; Thu, 29 Jul 2021 01:37:15 +0200 (CEST) Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 79BE582CDA for ; Thu, 29 Jul 2021 01:37:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=panfilov.artyom@gmail.com Received: by mail-lf1-x134.google.com with SMTP id m13so7118645lfg.13 for ; Wed, 28 Jul 2021 16:37:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=XyRjl2VsbTbH1Ic86TbxoY1Y5YvDPlCiMb+Gnwkv6rQ=; b=AcmZ2PNY1Wexwb2ZawJQkSmYkGktA8hIYnu1LlUU/cHXwWtMO/0d/F/46IEX67K34b lpWYf+FnJfvzV/Ev7sh5yylwcc1VEc3KD/09q4XSwJtNRMigOFUn3wh9eLDQ9Ntj3xjc oZzjIoDdcQGEPECKiuR46ygOG+yP5SXRUiARVruG/1APPX1t3g4jU9U67crorJwjRlop qA2ky3fPR/cRHr/jI1FNxO0oZCeI672ZTcl7XGT4p/d8jBIm3oEzdBC/0P0lBJHGoM/v 9LNTcPQ+uSKgmUpdGlM3G0KTLotgQ5AfnlL1NZBrj30AJzH/XzHp0KRaNxx3RmRKVtgE DN0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=XyRjl2VsbTbH1Ic86TbxoY1Y5YvDPlCiMb+Gnwkv6rQ=; b=sVdqWGYdBHn11xo3iXeZSwmiM+ZpF0OSnv/MugZf3UqWdOqR6DZbAX91p383kcLU4H ThMvY0sth5ZlwZP2RcyxlGSubBpuWbBSo37lXPrlk38Zkw/33Bp6viO2pNwwcmloWI/m 05XVCbFqB35Mg449jpSpSWliX4GYs0BDQbJtam7l63x5U0meCJpSnxZt9MmcFjZRdubX 4/Uvd1KH59GQ1YVeAU9lMldWoapF5qbqJY9QxaZxzsU0y3nnZpyWwCYLYRIcvG64o5hK CeKz7Qkkq4GNWeyAKeYbW109JQ6Za2NjAwiIKHQqKoZgR5kf/NyzaTT+P/wrT/4n90M5 w3lA== X-Gm-Message-State: AOAM531iYSm/FCdS7vMg8X/eloOYgQa1/k4uyeYNePYksNrOGjeM9eQN JHoLnoRwR2ty1dZocuM2USV6eXmYsc27kRC5OJuODQ== X-Google-Smtp-Source: ABdhPJz5sdTAnOcW93FQMpUCz6EK38ODXuvKYyh66sNlw1z5V4+W+ZhekSO+mGCsBNVqYuRM1qkyxA== X-Received: by 2002:ac2:5990:: with SMTP id w16mr1615053lfn.44.1627515431575; Wed, 28 Jul 2021 16:37:11 -0700 (PDT) Received: from [192.168.1.124] ([31.134.188.128]) by smtp.gmail.com with ESMTPSA id y20sm129354lfh.202.2021.07.28.16.37.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jul 2021 16:37:11 -0700 (PDT) Subject: Re: [PATCH 1/1] lib/ecdsa: Fix LibreSSL before v2.7.0 To: Tom Rini Cc: "Alex G." , "u-boot@lists.denx.de" References: <20210728181023.25067-1-panfilov.artyom@gmail.com> <21fa035a-7ab5-7045-dd47-90670eb8be14@gmail.com> <20210728200701.GY9379@bill-the-cat> <34cdf0ed-c97d-e5ec-31ff-24e4ca085c4d@gmail.com> <20210728225619.GB9379@bill-the-cat> From: Artem Panfilov Message-ID: Date: Thu, 29 Jul 2021 02:37:10 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210728225619.GB9379@bill-the-cat> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 29.07.2021 01:56, Tom Rini wrote: > Part of the question is then, were you enabling the SSL-related parts > before this change? Or did the way the code is now being > enabled/disabled trigger this now being enabled when it wasn't before? > This commit broke the build: https://gitlab.com/u-boot/u-boot/-/commit/cb9faa6f98ae56d70d59505dad290dd3d381cb7b Our testing board defconfig: https://gitlab.com/u-boot/u-boot/-/blob/master/configs/hsdk_defconfig I also found this patch that was committed 4 months ago. It includes OpenSSL compatibility for old versions: https://gitlab.com/u-boot/u-boot/-/commit/fbc777429fa35312a9ea5f106692172d3153e659 --- Artem