Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A177F94CDE for ; Wed, 22 Apr 2026 08:17:11 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4g0sX60MXmz2yqs; Wed, 22 Apr 2026 18:17:10 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=115.124.30.101 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776845829; cv=none; b=Lhxp/9s/dm31CTXbwbgFoFw/e5cpxTFoLsT8oNaY3OQ6jMGNtHTEPLICoh/eRtjAYtyhiCmgJs0t9Bfk0+p1VAHSwsF1eF0Jltrm4NQoy/uA8PJnYlqNCG+2zPUj4OTFX7h0WRtzuO4UOQ/hM0l8rXiUGGzE86q//AaGQtXQZBnK8b9lsGEPcFn7V74s8t/Q5qT+18bXeCvNuIFhZuPGC3wtLQxU5y96puUut4wG57rpS4iKFMXS0+tZ8VAhK0D6pk6sAG0qbGWw031N7di7Ve/mbcTbMNKah4a7w1l6+81zPjSINWmM8+XFvwzLNF0b5j32734T9k3/5q1ZygMcVw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776845829; c=relaxed/relaxed; bh=sAStO4AfbcXAUNshJlf/AW0N7xM44pGATmdN/1AKQaM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NHBf0GUS/q3O2y2f64fhK7W7ozsYMXVUMzx6yAEZHlOGeRZwnWEErNdO+2I8E03bO45knQiTAqf4AkrByu77QKZgIOkfyeqxTejvEr2Um4wRg6BHhD01T+TgFhapSLlKxckzcuUfhUYgLqvkFkaP8izNCgycTzkHQEH+/wQ3JcZGfo51ymrNL6MckCAdk0kQEdPUqr0lRCN7YgTjotr2NGl+d3yaiplmm7zbPEirMnUB4vyCzjSPUPXZYY6u0AXG9xTpsny5UZE/6wa4WN5tHpSrbfARm4TKT1LgEEkyx7U2STQxonOcBTlrXTTxtJ2/+zMzuTzoH95h1h2BB/9T0A== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; dkim=pass (1024-bit key; unprotected) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.a=rsa-sha256 header.s=default header.b=OI01qilu; dkim-atps=neutral; spf=pass (client-ip=115.124.30.101; helo=out30-101.freemail.mail.aliyun.com; envelope-from=hsiangkao@linux.alibaba.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.alibaba.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.a=rsa-sha256 header.s=default header.b=OI01qilu; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.alibaba.com (client-ip=115.124.30.101; helo=out30-101.freemail.mail.aliyun.com; envelope-from=hsiangkao@linux.alibaba.com; receiver=lists.ozlabs.org) Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4g0sX33ZKNz2yql for ; Wed, 22 Apr 2026 18:17:05 +1000 (AEST) DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1776845821; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=sAStO4AfbcXAUNshJlf/AW0N7xM44pGATmdN/1AKQaM=; b=OI01qiluwUAt5/dg9mEYINwSOjbJjc+gaULv8LR5OV6O9Repj92mdrXcxEmxActdX2Het2Ybi/D0MZ2b/SeobOsFa0Hf4KepYs2RBB+OG3T+FI5UnR/GYLA9iHEpnda2QHaCCEZdegMnSvibI0V8hkyF3Yco46HQw/SYh9UslYw= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037026112;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0X1VbIYe_1776845819; Received: from 30.221.129.120(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0X1VbIYe_1776845819 cluster:ay36) by smtp.aliyun-inc.com; Wed, 22 Apr 2026 16:16:59 +0800 Message-ID: Date: Wed, 22 Apr 2026 16:16:58 +0800 X-Mailing-List: linux-erofs@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] erofs-utils: mkfs: support set fingerprint for tar sort=none mode To: Yuezhang Mo , linux-erofs@lists.ozlabs.org Cc: Friendy Su , Daniel Palmer References: <20260422073705.1828301-2-Yuezhang.Mo@sony.com> From: Gao Xiang In-Reply-To: <20260422073705.1828301-2-Yuezhang.Mo@sony.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026/4/22 15:37, Yuezhang Mo wrote: > If "--tar=f" and "--sort=none" are enabled, ->datasource will be set > to "EROFS_INODE_DATA_SOURCE_NONE". > > In erofs_mkfs_begin_nondirectory(), erofs_set_inode_fingerprint() is > only be called if ->datasource is EROFS_INODE_DATA_SOURCE_LOCALPATH > or EROFS_INODE_DATA_SOURCE_DISKBUF. > > EROFS_INODE_DATA_SOURCE_NONE means that metadata is done and mkfs > dump will change nothing, so use erofs_setxattr() to set fingerprint > at settings ->datasource to EROFS_INODE_DATA_SOURCE_NONE. > > Signed-off-by: Yuezhang Mo > Reviewed-by: Friendy Su > Reviewed-by: Daniel Palmer Thanks, will apply. Thanks, Gao Xiang