From: "selvanair (Code Review)" Date: Tue, 9 Jul 2024 13:22:02 +0000 In-Reply-To: References: Reply-To: selva.nair@...277..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="H8JTqD17RQU="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Static-challenge concatenation option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: flichtenheld , plaisthos , openvpn-devel --H8JTqD17RQU= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. selvanair has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/665?usp=3Demail ) Change subject: Static-challenge concatenation option ...................................................................... Patch Set 2: (3 comments) Patchset: PS2: Thanks for the review. File doc/management-notes.txt: http://gerrit.openvpn.net/c/openvpn/+/665/comment/16c4a9ba_0d8e0e6a : PS2, Line 1333: FORMAT =3D bit 2 =3D 1 if response should be conca= tenated with password > Honestly it is not clear to me from this documentation on how these flags= combine. [=E2=80=A6] v2 is coming. File src/openvpn/misc.h: http://gerrit.openvpn.net/c/openvpn/+/665/comment/25e712cb_3f39cbc9 : PS2, Line 121: #define GET_USER_PASS_STATIC_CHALLENGE_CONCAT (1<<11) /* in= dicates password and response should be concatenated */ > Please add a test to the UT suite test_get_user_pass_static_challenge Test was submitted along with: see https://gerrit.openvpn.net/c/openvpn/+/6= 66 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/665?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I59a90446bfe73d8856516025a58a6f62cc98ab0d Gerrit-Change-Number: 665 Gerrit-PatchSet: 2 Gerrit-Owner: selvanair Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Tue, 09 Jul 2024 13:22:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment --H8JTqD17RQU= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

View C= hange

3 comments:

    =
  • Patchset:

  • File doc/management-notes.txt:

    • Patch Set #2, Line 1333: FORMAT =3D bit 2 =3D= 1 if response should be concatenated with password

      H= onestly it is not clear to me from this documentation on how these flags co= mbine. [=E2=80=A6]

      v2 is coming.

  • File src/openvpn/misc.h:

    • Patch Set #2, Line 121: #define GET_USER_PASS_STATIC_CHALLENGE_CONCAT (1<= <11) /* indicates password and response should be concatenated */

      Please add a test to the UT suite test_get_user_pass_stati= c_challenge

      Test was submitted along with: see https://gerrit.openvpn.net/c= /openvpn/+/666

To view, visit change 665. To unsubscri= be, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I59a90446bfe73d8856516025a58= a6f62cc98ab0d
Gerrit-Change-Number: 665
Gerrit-PatchSet: 2
Gerrit-Owner: selvanair <selva.nair@...1354...= ..>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Tue, 09 Jul 2024 13:22:02= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
Gerrit-MessageType: comment
--H8JTqD17RQU=--