Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA2937F for ; Tue, 26 Sep 2023 03:15:27 +0000 (UTC) Received: from out30-99.freemail.mail.aliyun.com (out30-99.freemail.mail.aliyun.com [115.124.30.99]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19AB59F; Mon, 25 Sep 2023 20:15:24 -0700 (PDT) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=renyu.zj@linux.alibaba.com;NM=1;PH=DS;RN=20;SR=0;TI=SMTPD_---0VsvBD6V_1695698120; Received: from 30.221.149.38(mailfrom:renyu.zj@linux.alibaba.com fp:SMTPD_---0VsvBD6V_1695698120) by smtp.aliyun-inc.com; Tue, 26 Sep 2023 11:15:22 +0800 Message-ID: Date: Tue, 26 Sep 2023 11:15:19 +0800 Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v10 0/7] Add metrics for Arm CMN To: Ian Rogers Cc: John Garry , Will Deacon , James Clark , Arnaldo Carvalho de Melo , Mark Rutland , Mike Leach , Leo Yan , Namhyung Kim , Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Jiri Olsa , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-doc@vger.kernel.org, Zhuo Song , Shuai Xue References: <1695621444-56530-1-git-send-email-renyu.zj@linux.alibaba.com> From: Jing Zhang In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net 在 2023/9/26 上午12:37, Ian Rogers 写道: > On Sun, Sep 24, 2023 at 10:58 PM Jing Zhang wrote: >> >> Changes since v8: >> - Add fully match identifier check as suggested by Ian. >> - Link: https://lore.kernel.org/lkml/1695037955-107983-1-git-send-email-renyu.zj@linux.alibaba.com/ >> >> Jing Zhang (7): >> perf pmu: "Compat" supports regular expression matching identifiers >> perf metric: "Compat" supports regular expression matching identifiers >> perf jevents: Support EventidCode and NodeType >> perf test: Make matching_pmu effective >> perf test: Add pmu-event test for "Compat" and new event_field. >> perf jevents: Add support for Arm CMN PMU aliasing >> perf vendor events: Add JSON metrics for Arm CMN > > Thanks for the patience with all the to and fro. I was able to test > the series with "git am -3" to get around a merge issue on > perf-tools-next. > > Reviewed-by: Ian Rogers > Tested-by: Ian Rogers > Thank you for following this series and providing many valuable suggestions. Thanks, Jing > Thanks, > Ian > >> .../pmu-events/arch/arm64/arm/cmn/sys/cmn.json | 266 +++++++++++++++++++++ >> .../pmu-events/arch/arm64/arm/cmn/sys/metric.json | 74 ++++++ >> .../pmu-events/arch/test/test_soc/sys/uncore.json | 8 + >> tools/perf/pmu-events/empty-pmu-events.c | 8 + >> tools/perf/pmu-events/jevents.py | 11 +- >> tools/perf/tests/pmu-events.c | 65 ++++- >> tools/perf/util/metricgroup.c | 2 +- >> tools/perf/util/pmu.c | 27 ++- >> tools/perf/util/pmu.h | 1 + >> 9 files changed, 456 insertions(+), 6 deletions(-) >> create mode 100644 tools/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json >> create mode 100644 tools/perf/pmu-events/arch/arm64/arm/cmn/sys/metric.json >> >> -- >> 1.8.3.1 >>