From: "Koenig, Christian" Subject: Re: [PATCH] drm: fix call_kern.cocci warnings v3 Date: Thu, 25 Oct 2018 11:12:18 +0000 Message-ID: References: <20181025102105.15412-1-david1.zhou@amd.com> <860e509a-1bff-a2b5-2934-6a2125e8fa40@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <860e509a-1bff-a2b5-2934-6a2125e8fa40@linux.intel.com> Content-Language: en-US Content-ID: <0EE01BA0A1E9B240A7B899F0AD232965@namprd12.prod.outlook.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst , "Zhou, David(ChunMing)" , "dri-devel@lists.freedesktop.org" Cc: "intel-gfx@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org QW0gMjUuMTAuMTggdW0gMTI6MzYgc2NocmllYiBNYWFydGVuIExhbmtob3JzdDoNCj4gT3AgMjUt MTAtMTggb20gMTI6MjEgc2NocmVlZiBDaHVubWluZyBaaG91Og0KPj4gZHJpdmVycy9ncHUvZHJt L2RybV9zeW5jb2JqLmM6MjAyOjQtMTQ6IEVSUk9SOiBmdW5jdGlvbiBkcm1fc3luY29ial9maW5k X3NpZ25hbF9wdF9mb3JfcG9pbnQgY2FsbGVkIG9uIGxpbmUgMzkwIGluc2lkZSBsb2NrIG9uIGxp bmUgMzg5IGJ1dCB1c2VzIEdGUF9LRVJORUwNCj4+DQo+PiAgICBGaW5kIGZ1bmN0aW9ucyB0aGF0 IHJlZmVyIHRvIEdGUF9LRVJORUwgYnV0IGFyZSBjYWxsZWQgd2l0aCBsb2NrcyBoZWxkLg0KPj4N Cj4+IEdlbmVyYXRlZCBieTogc2NyaXB0cy9jb2NjaW5lbGxlL2xvY2tzL2NhbGxfa2Vybi5jb2Nj aQ0KPj4NCj4+IHYyOg0KPj4gc3luY29iai0+dGltZWxpbmUgc3RpbGwgbmVlZHMgcHJvdGVjdC4N Cj4+DQo+PiB2MzoNCj4+IHVzZSBhIGdsb2JhbCBzaWduYWxlZCBmZW5jZSBpbnN0ZWFkIG9mIHJl LWFsbG9jYXRpb24uDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTogQ2h1bm1pbmcgWmhvdSA8ZGF2aWQx Lnpob3VAYW1kLmNvbT4NCj4+IENjOiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9y c3RAbGludXguaW50ZWwuY29tPg0KPj4gQ2M6IGludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcNCj4+IENjOiBDaHJpc3RpYW4gS8O2bmlnIDxlYXN5MnJlbWVtYmVyLmNoa0Bnb29nbGVtYWls LmNvbT4NCj4+IC0tLQ0KPj4gICBkcml2ZXJzL2dwdS9kcm0vZHJtX2Rydi5jICAgICB8ICAyICsr DQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9kcm1fc3luY29iai5jIHwgNTIgKysrKysrKysrKysrKysr KysrKysrLS0tLS0tLS0tLS0tLS0NCj4+ICAgaW5jbHVkZS9kcm0vZHJtX3N5bmNvYmouaCAgICAg fCAgMSArDQo+PiAgIDMgZmlsZXMgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygrKSwgMjEgZGVsZXRp b25zKC0pDQo+Pg0KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHJ2LmMgYi9k cml2ZXJzL2dwdS9kcm0vZHJtX2Rydi5jDQo+PiBpbmRleCAzNmU4ZTljYmVjNTIuLjBhNmYxMDIz ZDZjMyAxMDA2NDQNCj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHJ2LmMNCj4+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9kcm1fZHJ2LmMNCj4+IEBAIC0zNyw2ICszNyw3IEBADQo+PiAgICNp bmNsdWRlIDxkcm0vZHJtX2NsaWVudC5oPg0KPj4gICAjaW5jbHVkZSA8ZHJtL2RybV9kcnYuaD4N Cj4+ICAgI2luY2x1ZGUgPGRybS9kcm1QLmg+DQo+PiArI2luY2x1ZGUgPGRybS9kcm1fc3luY29i ai5oPg0KPj4gICANCj4+ICAgI2luY2x1ZGUgImRybV9jcnRjX2ludGVybmFsLmgiDQo+PiAgICNp bmNsdWRlICJkcm1fbGVnYWN5LmgiDQo+PiBAQCAtMTAwMyw2ICsxMDA0LDcgQEAgc3RhdGljIGlu dCBfX2luaXQgZHJtX2NvcmVfaW5pdCh2b2lkKQ0KPj4gICAJaWYgKHJldCA8IDApDQo+PiAgIAkJ Z290byBlcnJvcjsNCj4+ICAgDQo+PiArCWRybV9zeW5jb2JqX3N0dWJfZmVuY2VfaW5pdCgpOw0K Pj4gICAJZHJtX2NvcmVfaW5pdF9jb21wbGV0ZSA9IHRydWU7DQo+PiAgIA0KPj4gICAJRFJNX0RF QlVHKCJJbml0aWFsaXplZFxuIik7DQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2Ry bV9zeW5jb2JqLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3N5bmNvYmouYw0KPj4gaW5kZXggYjdl YWE2MDNmMzY4Li42YjNmNWEwNmU0ZDMgMTAwNjQ0DQo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v ZHJtX3N5bmNvYmouYw0KPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9zeW5jb2JqLmMNCj4+ IEBAIC04MCw2ICs4MCwyNyBAQCBzdHJ1Y3QgZHJtX3N5bmNvYmpfc2lnbmFsX3B0IHsNCj4+ICAg CXN0cnVjdCBsaXN0X2hlYWQgbGlzdDsNCj4+ICAgfTsNCj4+ICAgDQo+PiArc3RhdGljIHN0cnVj dCBkcm1fc3luY29ial9zdHViX2ZlbmNlIHN0dWJfc2lnbmFsZWRfZmVuY2U7DQo+PiArc3RhdGlj IHZvaWQgZ2xvYmFsX3N0dWJfZmVuY2VfcmVsZWFzZShzdHJ1Y3QgZG1hX2ZlbmNlICpmZW5jZSkN Cj4+ICt7DQo+PiArCS8qIGl0IGlzIGltcG9zc2libGUgdG8gY29tZSBoZXJlICovDQo+PiArCUJV RygpOw0KPj4gK30NCj4gV0FSTl9PTl9PTkNFKDEpPyBObyBuZWVkIHRvIGhhbHQgdGhlIG1hY2hp bmUuDQo+DQo+PiArc3RhdGljIGNvbnN0IHN0cnVjdCBkbWFfZmVuY2Vfb3BzIGdsb2JhbF9zdHVi X2ZlbmNlX29wcyA9IHsNCj4+ICsJLmdldF9kcml2ZXJfbmFtZSA9IGRybV9zeW5jb2JqX3N0dWJf ZmVuY2VfZ2V0X25hbWUsDQo+PiArCS5nZXRfdGltZWxpbmVfbmFtZSA9IGRybV9zeW5jb2JqX3N0 dWJfZmVuY2VfZ2V0X25hbWUsDQo+PiArCS5yZWxlYXNlID0gZ2xvYmFsX3N0dWJfZmVuY2VfcmVs ZWFzZSwNCj4+ICt9Ow0KPj4gKw0KPj4gK3ZvaWQgZHJtX3N5bmNvYmpfc3R1Yl9mZW5jZV9pbml0 KHZvaWQpDQo+PiArew0KPj4gKwlzcGluX2xvY2tfaW5pdCgmc3R1Yl9zaWduYWxlZF9mZW5jZS5s b2NrKTsNCj4+ICsJZG1hX2ZlbmNlX2luaXQoJnN0dWJfc2lnbmFsZWRfZmVuY2UuYmFzZSwNCj4+ ICsJCSAgICAgICAmZ2xvYmFsX3N0dWJfZmVuY2Vfb3BzLA0KPj4gKwkJICAgICAgICZzdHViX3Np Z25hbGVkX2ZlbmNlLmxvY2ssDQo+PiArCQkgICAgICAgMCwgMCk7DQo+PiArCWRtYV9mZW5jZV9z aWduYWwoJnN0dWJfc2lnbmFsZWRfZmVuY2UuYmFzZSk7DQo+PiArfQ0KPj4gICAvKioNCj4+ICAg ICogZHJtX3N5bmNvYmpfZmluZCAtIGxvb2t1cCBhbmQgcmVmZXJlbmNlIGEgc3luYyBvYmplY3Qu DQo+PiAgICAqIEBmaWxlX3ByaXZhdGU6IGRybSBmaWxlIHByaXZhdGUgcG9pbnRlcg0KPj4gQEAg LTExMSwyNCArMTMyLDE0IEBAIHN0YXRpYyBzdHJ1Y3QgZG1hX2ZlbmNlDQo+PiAgIAkJCQkgICAg ICB1aW50NjRfdCBwb2ludCkNCj4+ICAgew0KPj4gICAJc3RydWN0IGRybV9zeW5jb2JqX3NpZ25h bF9wdCAqc2lnbmFsX3B0Ow0KPj4gKwlzdHJ1Y3QgZG1hX2ZlbmNlICpmID0gTlVMTDsNCj4+ICAg DQo+PiArCXNwaW5fbG9jaygmc3luY29iai0+cHRfbG9jayk7DQo+PiAgIAlpZiAoKHN5bmNvYmot PnR5cGUgPT0gRFJNX1NZTkNPQkpfVFlQRV9USU1FTElORSkgJiYNCj4+ICAgCSAgICAocG9pbnQg PD0gc3luY29iai0+dGltZWxpbmUpKSB7DQo+PiAtCQlzdHJ1Y3QgZHJtX3N5bmNvYmpfc3R1Yl9m ZW5jZSAqZmVuY2UgPQ0KPj4gLQkJCWt6YWxsb2Moc2l6ZW9mKHN0cnVjdCBkcm1fc3luY29ial9z dHViX2ZlbmNlKSwNCj4+IC0JCQkJR0ZQX0tFUk5FTCk7DQo+PiAtDQo+PiAtCQlpZiAoIWZlbmNl KQ0KPj4gLQkJCXJldHVybiBOVUxMOw0KPj4gLQkJc3Bpbl9sb2NrX2luaXQoJmZlbmNlLT5sb2Nr KTsNCj4+IC0JCWRtYV9mZW5jZV9pbml0KCZmZW5jZS0+YmFzZSwNCj4+IC0JCQkgICAgICAgJmRy bV9zeW5jb2JqX3N0dWJfZmVuY2Vfb3BzLA0KPj4gLQkJCSAgICAgICAmZmVuY2UtPmxvY2ssDQo+ PiAtCQkJICAgICAgIHN5bmNvYmotPnRpbWVsaW5lX2NvbnRleHQsDQo+PiAtCQkJICAgICAgIHBv aW50KTsNCj4+IC0NCj4+IC0JCWRtYV9mZW5jZV9zaWduYWwoJmZlbmNlLT5iYXNlKTsNCj4+IC0J CXJldHVybiAmZmVuY2UtPmJhc2U7DQo+PiArCQlkbWFfZmVuY2VfZ2V0KCZzdHViX3NpZ25hbGVk X2ZlbmNlLmJhc2UpOw0KPj4gKwkJc3Bpbl91bmxvY2soJnN5bmNvYmotPnB0X2xvY2spOw0KPj4g KwkJcmV0dXJuICZzdHViX3NpZ25hbGVkX2ZlbmNlLmJhc2U7DQo+PiAgIAl9DQo+PiAgIA0KPj4g ICAJbGlzdF9mb3JfZWFjaF9lbnRyeShzaWduYWxfcHQsICZzeW5jb2JqLT5zaWduYWxfcHRfbGlz dCwgbGlzdCkgew0KPj4gQEAgLTEzNyw5ICsxNDgsMTIgQEAgc3RhdGljIHN0cnVjdCBkbWFfZmVu Y2UNCj4+ICAgCQlpZiAoKHN5bmNvYmotPnR5cGUgPT0gRFJNX1NZTkNPQkpfVFlQRV9CSU5BUlkp ICYmDQo+PiAgIAkJICAgIChwb2ludCAhPSBzaWduYWxfcHQtPnZhbHVlKSkNCj4+ICAgCQkJY29u dGludWU7DQo+PiAtCQlyZXR1cm4gZG1hX2ZlbmNlX2dldCgmc2lnbmFsX3B0LT5mZW5jZV9hcnJh eS0+YmFzZSk7DQo+PiArCQlmID0gZG1hX2ZlbmNlX2dldCgmc2lnbmFsX3B0LT5mZW5jZV9hcnJh eS0+YmFzZSk7DQo+PiArCQlicmVhazsNCj4+ICAgCX0NCj4+IC0JcmV0dXJuIE5VTEw7DQo+PiAr CXNwaW5fdW5sb2NrKCZzeW5jb2JqLT5wdF9sb2NrKTsNCj4+ICsNCj4+ICsJcmV0dXJuIGY7DQo+ PiAgIH0NCj4+ICAgDQo+PiAgIHN0YXRpYyB2b2lkIGRybV9zeW5jb2JqX2FkZF9jYWxsYmFja19s b2NrZWQoc3RydWN0IGRybV9zeW5jb2JqICpzeW5jb2JqLA0KPj4gQEAgLTE2Niw5ICsxODAsNyBA QCBzdGF0aWMgdm9pZCBkcm1fc3luY29ial9mZW5jZV9nZXRfb3JfYWRkX2NhbGxiYWNrKHN0cnVj dCBkcm1fc3luY29iaiAqc3luY29iaiwNCj4+ICAgCX0NCj4+ICAgDQo+PiAgIAltdXRleF9sb2Nr KCZzeW5jb2JqLT5jYl9tdXRleCk7DQo+PiAtCXNwaW5fbG9jaygmc3luY29iai0+cHRfbG9jayk7 DQo+PiAgIAkqZmVuY2UgPSBkcm1fc3luY29ial9maW5kX3NpZ25hbF9wdF9mb3JfcG9pbnQoc3lu Y29iaiwgcHRfdmFsdWUpOw0KPj4gLQlzcGluX3VubG9jaygmc3luY29iai0+cHRfbG9jayk7DQo+ PiAgIAlpZiAoISpmZW5jZSkNCj4+ICAgCQlkcm1fc3luY29ial9hZGRfY2FsbGJhY2tfbG9ja2Vk KHN5bmNvYmosIGNiLCBmdW5jKTsNCj4+ICAgCW11dGV4X3VubG9jaygmc3luY29iai0+Y2JfbXV0 ZXgpOw0KPj4gQEAgLTM3OSwxMSArMzkxLDkgQEAgZHJtX3N5bmNvYmpfcG9pbnRfZ2V0KHN0cnVj dCBkcm1fc3luY29iaiAqc3luY29iaiwgdTY0IHBvaW50LCB1NjQgZmxhZ3MsDQo+PiAgIAkJaWYg KHJldCA8IDApDQo+PiAgIAkJCXJldHVybiByZXQ7DQo+PiAgIAl9DQo+PiAtCXNwaW5fbG9jaygm c3luY29iai0+cHRfbG9jayk7DQo+PiAgIAkqZmVuY2UgPSBkcm1fc3luY29ial9maW5kX3NpZ25h bF9wdF9mb3JfcG9pbnQoc3luY29iaiwgcG9pbnQpOw0KPj4gICAJaWYgKCEqZmVuY2UpDQo+PiAg IAkJcmV0ID0gLUVJTlZBTDsNCj4+IC0Jc3Bpbl91bmxvY2soJnN5bmNvYmotPnB0X2xvY2spOw0K Pj4gICAJcmV0dXJuIHJldDsNCj4+ICAgfQ0KPj4gICANCj4+IGRpZmYgLS1naXQgYS9pbmNsdWRl L2RybS9kcm1fc3luY29iai5oIGIvaW5jbHVkZS9kcm0vZHJtX3N5bmNvYmouaA0KPj4gaW5kZXgg MjkyNDRjYmNkMDVlLi42M2NmZDE1NDAyNDEgMTAwNjQ0DQo+PiAtLS0gYS9pbmNsdWRlL2RybS9k cm1fc3luY29iai5oDQo+PiArKysgYi9pbmNsdWRlL2RybS9kcm1fc3luY29iai5oDQo+PiBAQCAt MTQ4LDQgKzE0OCw1IEBAIGludCBkcm1fc3luY29ial9nZXRfZmQoc3RydWN0IGRybV9zeW5jb2Jq ICpzeW5jb2JqLCBpbnQgKnBfZmQpOw0KPj4gICBpbnQgZHJtX3N5bmNvYmpfc2VhcmNoX2ZlbmNl KHN0cnVjdCBkcm1fc3luY29iaiAqc3luY29iaiwgdTY0IHBvaW50LCB1NjQgZmxhZ3MsDQo+PiAg IAkJCSAgICAgc3RydWN0IGRtYV9mZW5jZSAqKmZlbmNlKTsNCj4+ICAgDQo+PiArdm9pZCBkcm1f c3luY29ial9zdHViX2ZlbmNlX2luaXQodm9pZCk7DQo+PiAgICNlbmRpZg0KPiBNb3ZlIGl0IHRv IGRybV9pbnRlcm5hbC5oID8gVGhpcyBpcyBub3QgZm9yIGRyaXZlciBjb25zdW1wdGlvbi4gOikN Cj4NCj4gaSB3b3VsZCBzcGxpdCB1cCB0aGUgY2hhbmdlcyBhdCB0aGlzIHBvaW50Og0KPg0KPiAx LiBSZXBsYWNlIG1lbW9yeSBhbGxvY2F0aW9uIHdpdGggYSBzdGF0aWMgZmVuY2UsIG5vdCBuZWNl c3NhcmlseSBjaGFuZ2luZyBhbnkgbG9ja2luZywgYWRkIGEgZml4ZXMgdGFnIHRvIHRoaXMgY29t bWl0Lg0KPg0KPiAyLiBNb3ZlIGxvY2tpbmcuDQo+DQo+IDMuIEZpeCBkcm1fc3luY29ial9mZW5j ZV9nZXRfb3JfYWRkX2NhbGxiYWNrIHRvIHJldHVybiBhbiBlcnJvci4NCg0KQWN0dWFsbHkgd2Ug ZG9uJ3QgbmVlZCB0byBtb3ZlIHRoZSBsb2NraW5nIG9yIGNoYW5nZSBpbnRvIHJldHVybmluZyBh biANCmVycm9yIGNvZGUgYW55IG1vcmUuDQoNCldpdGhvdXQgYW55IGFsbG9jYXRpb24gd2UgZG9u J3QgaGF2ZSBhbnl0aGluZyB0aGF0IGNvdWxkIGZhaWwuDQoNCkNocmlzdGlhbi4NCg0KPg0KPiBU aGF0IHdheSBpdCBzaG91bGQgYmUgbmljZWx5IGJpc2VjdGFibGUuDQo+DQo+IH5NYWFydGVuDQo+ DQoNCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=