Message-ID: Date: Wed, 27 Apr 2022 10:04:58 +0200 MIME-Version: 1.0 Content-Language: en-US References: <20220427074828.6283-1-kprovost@...2661...> <20220427074828.6283-2-kprovost@...2661...> <761e5640-6d43-d25b-4845-25698d2e0688@...2181...> From: Antonio Quartulli In-Reply-To: Subject: Re: [Openvpn-devel] [PATCH] Handle (DCO) timeouts in client mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Gert Doering Cc: Kristof Provost , openvpn-devel , Lev Stipakov Hi, On 27/04/2022 09:59, Gert Doering wrote: > Hi, > > On Wed, Apr 27, 2022 at 09:55:24AM +0200, Antonio Quartulli wrote: >>> --- a/src/openvpn/forward.c >>> +++ b/src/openvpn/forward.c >>> @@ -1111,6 +1111,12 @@ process_incoming_dco(struct context *c) >>> >>> dco_do_read(dco); >>> >>> + if (dco->dco_message_type == OVPN_NOTIF_DEL_PEER) >> >> Not sure where this constant is coming from, but on ovpn_dco_linux.h we >> have OVPN_CMD_DEL_PEER (similar format as the following OVPN_CMD_PACKET). > > For "notifications coming from kernel", _NOTIF_ feels more logical > than _CMD_ ("commands going into kernel"). No? It's just the same message that can go both directions. This is the same that the WiFi stack in the Linux kernel does with messages such as NEW_STA and DEL_STA. So we're just re-using the same accepted pattern. Regards, -- Antonio Quartulli