From: Stefan Agner Subject: Re: [PATCH v4 2/5] drm/mxsfb: Fix initial corrupt frame when activating display Date: Wed, 08 Aug 2018 20:58:10 +0200 Message-ID: References: <056bd70ef7bf4d66d636cf7869a489e8c743aaf3.1533743954.git.leonard.crestez@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.kmu-office.ch (mail.kmu-office.ch [IPv6:2a02:418:6a02::a2]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9EFF9898F0 for ; Wed, 8 Aug 2018 18:58:11 +0000 (UTC) In-Reply-To: <056bd70ef7bf4d66d636cf7869a489e8c743aaf3.1533743954.git.leonard.crestez@nxp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Leonard Crestez Cc: Marek Vasut , Dong Aisheng , kernel@pengutronix.de, Anson Huang , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Fabio Estevam , linux-imx@nxp.com, Robert Chiras , Shawn Guo List-Id: dri-devel@lists.freedesktop.org T24gMDguMDguMjAxOCAxODowOCwgTGVvbmFyZCBDcmVzdGV6IHdyb3RlOgo+IExDRElGIHdpbGwg cmVwZWF0ZWRseSBkaXNwbGF5IGRhdGEgZnJvbSBDVVJfQlVGIGFuZCBzZXQgQ1VSX0JVRiB0bwo+ IE5FWFRfQlVGIHdoZW4gZG9uZS4gU2luY2Ugd2UgYXJlIG9ubHkgZXZlciB3cml0aW5nIHRvIE5F WFRfQlVGIHRoZQo+IGRpc3BsYXkgd2lsbCBzaG93IGFuIGluaXRpYWwgY29ycnVwdCBmcmFtZS4K PiAKPiBGaXggYnkgd3JpdGluZyB0aGUgRkIgcGFkZHIgdG8gYm90aCBDVVJfQlVGIGFuZCBORVhU X0JVRiB3aGVuCj4gYWN0aXZhdGluZyB0aGUgQ1JUQy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBMZW9u YXJkIENyZXN0ZXogPGxlb25hcmQuY3Jlc3RlekBueHAuY29tPgo+IFRlc3RlZC1ieTogUGhpbGlw cCBaYWJlbCA8cC56YWJlbEBwZW5ndXRyb25peC5kZT4KClJldmlld2VkLWJ5OiBTdGVmYW4gQWdu ZXIgPHN0ZWZhbkBhZ25lci5jaD4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9teHNmYi9teHNm Yl9jcnRjLmMgfCA0NSArKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0KPiAgMSBmaWxlIGNo YW5nZWQsIDMyIGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vbXhzZmIvbXhzZmJfY3J0Yy5jCj4gYi9kcml2ZXJzL2dwdS9kcm0v bXhzZmIvbXhzZmJfY3J0Yy5jCj4gaW5kZXggZTRmY2JiNjViOTY5Li4yNGIxZjBjMTQzMmUgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL214c2ZiL214c2ZiX2NydGMuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9teHNmYi9teHNmYl9jcnRjLmMKPiBAQCAtMTkxLDEwICsxOTEsMjUgQEAg c3RhdGljIGludCBteHNmYl9yZXNldF9ibG9jayh2b2lkIF9faW9tZW0gKnJlc2V0X2FkZHIpCj4g IAkJcmV0dXJuIHJldDsKPiAgCj4gIAlyZXR1cm4gY2xlYXJfcG9sbF9iaXQocmVzZXRfYWRkciwg TU9EVUxFX0NMS0dBVEUpOwo+ICB9Cj4gIAo+ICtzdGF0aWMgZG1hX2FkZHJfdCBteHNmYl9nZXRf ZmJfcGFkZHIoc3RydWN0IG14c2ZiX2RybV9wcml2YXRlICpteHNmYikKPiArewo+ICsJc3RydWN0 IGRybV9mcmFtZWJ1ZmZlciAqZmIgPSBteHNmYi0+cGlwZS5wbGFuZS5zdGF0ZS0+ZmI7Cj4gKwlz dHJ1Y3QgZHJtX2dlbV9jbWFfb2JqZWN0ICpnZW07Cj4gKwo+ICsJaWYgKCFmYikKPiArCQlyZXR1 cm4gMDsKPiArCj4gKwlnZW0gPSBkcm1fZmJfY21hX2dldF9nZW1fb2JqKGZiLCAwKTsKPiArCWlm ICghZ2VtKQo+ICsJCXJldHVybiAwOwo+ICsKPiArCXJldHVybiBnZW0tPnBhZGRyOwo+ICt9Cj4g Kwo+ICBzdGF0aWMgdm9pZCBteHNmYl9jcnRjX21vZGVfc2V0X25vZmIoc3RydWN0IG14c2ZiX2Ry bV9wcml2YXRlICpteHNmYikKPiAgewo+ICAJc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm0gPSAm bXhzZmItPnBpcGUuY3J0Yy5zdGF0ZS0+YWRqdXN0ZWRfbW9kZTsKPiAgCWNvbnN0IHUzMiBidXNf ZmxhZ3MgPSBteHNmYi0+Y29ubmVjdG9yLmRpc3BsYXlfaW5mby5idXNfZmxhZ3M7Cj4gIAl1MzIg dmRjdHJsMCwgdnN5bmNfcHVsc2VfbGVuLCBoc3luY19wdWxzZV9sZW47Cj4gQEAgLTI2NywxMiAr MjgyLDIyIEBAIHN0YXRpYyB2b2lkIG14c2ZiX2NydGNfbW9kZV9zZXRfbm9mYihzdHJ1Y3QKPiBt eHNmYl9kcm1fcHJpdmF0ZSAqbXhzZmIpCj4gIAkgICAgICAgbXhzZmItPmJhc2UgKyBMQ0RDX1ZE Q1RSTDQpOwo+ICB9Cj4gIAo+ICB2b2lkIG14c2ZiX2NydGNfZW5hYmxlKHN0cnVjdCBteHNmYl9k cm1fcHJpdmF0ZSAqbXhzZmIpCj4gIHsKPiArCWRtYV9hZGRyX3QgcGFkZHI7Cj4gKwo+ICAJbXhz ZmJfZW5hYmxlX2F4aV9jbGsobXhzZmIpOwo+ICAJbXhzZmJfY3J0Y19tb2RlX3NldF9ub2ZiKG14 c2ZiKTsKPiArCj4gKwkvKiBXcml0ZSBjdXJfYnVmIGFzIHdlbGwgdG8gYXZvaWQgYW4gaW5pdGlh bCBjb3JydXB0IGZyYW1lICovCj4gKwlwYWRkciA9IG14c2ZiX2dldF9mYl9wYWRkcihteHNmYik7 Cj4gKwlpZiAocGFkZHIpIHsKPiArCQl3cml0ZWwocGFkZHIsIG14c2ZiLT5iYXNlICsgbXhzZmIt PmRldmRhdGEtPmN1cl9idWYpOwo+ICsJCXdyaXRlbChwYWRkciwgbXhzZmItPmJhc2UgKyBteHNm Yi0+ZGV2ZGF0YS0+bmV4dF9idWYpOwo+ICsJfQo+ICsKPiAgCW14c2ZiX2VuYWJsZV9jb250cm9s bGVyKG14c2ZiKTsKPiAgfQo+ICAKPiAgdm9pZCBteHNmYl9jcnRjX2Rpc2FibGUoc3RydWN0IG14 c2ZiX2RybV9wcml2YXRlICpteHNmYikKPiAgewo+IEBAIC0yODMsMTYgKzMwOCwxMiBAQCB2b2lk IG14c2ZiX2NydGNfZGlzYWJsZShzdHJ1Y3QgbXhzZmJfZHJtX3ByaXZhdGUgKm14c2ZiKQo+ICB2 b2lkIG14c2ZiX3BsYW5lX2F0b21pY191cGRhdGUoc3RydWN0IG14c2ZiX2RybV9wcml2YXRlICpt eHNmYiwKPiAgCQkJICAgICAgIHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnN0YXRlKQo+ICB7Cj4g IAlzdHJ1Y3QgZHJtX3NpbXBsZV9kaXNwbGF5X3BpcGUgKnBpcGUgPSAmbXhzZmItPnBpcGU7Cj4g IAlzdHJ1Y3QgZHJtX2NydGMgKmNydGMgPSAmcGlwZS0+Y3J0YzsKPiAtCXN0cnVjdCBkcm1fZnJh bWVidWZmZXIgKmZiID0gcGlwZS0+cGxhbmUuc3RhdGUtPmZiOwo+ICAJc3RydWN0IGRybV9wZW5k aW5nX3ZibGFua19ldmVudCAqZXZlbnQ7Cj4gLQlzdHJ1Y3QgZHJtX2dlbV9jbWFfb2JqZWN0ICpn ZW07Cj4gLQo+IC0JaWYgKCFjcnRjKQo+IC0JCXJldHVybjsKPiArCWRtYV9hZGRyX3QgcGFkZHI7 Cj4gIAo+ICAJc3Bpbl9sb2NrX2lycSgmY3J0Yy0+ZGV2LT5ldmVudF9sb2NrKTsKPiAgCWV2ZW50 ID0gY3J0Yy0+c3RhdGUtPmV2ZW50Owo+ICAJaWYgKGV2ZW50KSB7Cj4gIAkJY3J0Yy0+c3RhdGUt PmV2ZW50ID0gTlVMTDsKPiBAQCAtMzAzLDE0ICszMjQsMTIgQEAgdm9pZCBteHNmYl9wbGFuZV9h dG9taWNfdXBkYXRlKHN0cnVjdAo+IG14c2ZiX2RybV9wcml2YXRlICpteHNmYiwKPiAgCQkJZHJt X2NydGNfc2VuZF92YmxhbmtfZXZlbnQoY3J0YywgZXZlbnQpOwo+ICAJCX0KPiAgCX0KPiAgCXNw aW5fdW5sb2NrX2lycSgmY3J0Yy0+ZGV2LT5ldmVudF9sb2NrKTsKPiAgCj4gLQlpZiAoIWZiKQo+ IC0JCXJldHVybjsKPiAtCj4gLQlnZW0gPSBkcm1fZmJfY21hX2dldF9nZW1fb2JqKGZiLCAwKTsK PiAtCj4gLQlteHNmYl9lbmFibGVfYXhpX2NsayhteHNmYik7Cj4gLQl3cml0ZWwoZ2VtLT5wYWRk ciwgbXhzZmItPmJhc2UgKyBteHNmYi0+ZGV2ZGF0YS0+bmV4dF9idWYpOwo+IC0JbXhzZmJfZGlz YWJsZV9heGlfY2xrKG14c2ZiKTsKPiArCXBhZGRyID0gbXhzZmJfZ2V0X2ZiX3BhZGRyKG14c2Zi KTsKPiArCWlmIChwYWRkcikgewo+ICsJCW14c2ZiX2VuYWJsZV9heGlfY2xrKG14c2ZiKTsKPiAr CQl3cml0ZWwocGFkZHIsIG14c2ZiLT5iYXNlICsgbXhzZmItPmRldmRhdGEtPm5leHRfYnVmKTsK PiArCQlteHNmYl9kaXNhYmxlX2F4aV9jbGsobXhzZmIpOwo+ICsJfQo+ICB9Cl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=