From: Maarten Lankhorst Subject: Re: [PATCH 1/3] drm/i915: Convert intel_tv connector properties to atomic. Date: Mon, 13 Mar 2017 10:22:51 +0100 Message-ID: References: <1489064777-5460-1-git-send-email-maarten.lankhorst@linux.intel.com> <1489064777-5460-2-git-send-email-maarten.lankhorst@linux.intel.com> <20170309173602.GU31595@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2200A6E3C4 for ; Mon, 13 Mar 2017 09:22:54 +0000 (UTC) In-Reply-To: <20170309173602.GU31595@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMDktMDMtMTcgb20gMTg6MzYgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6Cj4gT24gVGh1LCBN YXIgMDksIDIwMTcgYXQgMDI6MDY6MTVQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6 Cj4+IEFzIGEgcHJvb2Ygb2YgY29uY2VwdCwgZmlyc3QgdHJ5IHRvIGNvbnZlcnQgaW50ZWxfdHYs IHdoaWNoIGlzIGEgcmFyZWx5Cj4+IHVzZWQgY29ubmVjdG9yLiBJdCBoYXMgNSBwcm9wZXJ0aWVz LCB0diBmb3JtYXQgYW5kIDQgbWFyZ2lucy4KPiBTaW5jZSBpdCdzIHNvIHJhcmUsIGlmIHlvdSB3 YW50IHNvbWVvbmUgdG8gYWN0dWFsbHkgdGVzdCB0aGUgY29kZQo+IGl0J2xsIHByb2JhYmx5IG1h a2Ugc2Vuc2UgdG8gcGljayBhbm90aGVyIGNvbm5lY3RvciA7KQpZZWFoIGJ1dCB0aGUgcHJvcGVy dGllcyBhcmUgYW1vbmcgdGhlIG1vc3QgYW5ub3lpbmcsIHdpdGggdGhlIHNlbGYgbW9kaWZ5aW5n IGNvZGUgYW5kIHVzaW5nIHN0YXRlIGluIG1vZGVfZGV0ZWN0KCkuCj4+IEknbSBsZXNzIGNlcnRh aW4gYWJvdXQgdGhlIHN0YXRlIGJlaGF2aW9yIGl0c2VsZiwgc2hvdWxkIHdlIHBhc3MgYSBzaXpl Cj4+IHBhcmFtZXRlciB0byBpbnRlbF9jb25uZWN0b3JfYWxsb2MgaW5zdGVhZCwgc28gZHVwbGlj YXRlX3N0YXRlCj4+IGNhbiBiZSBkb25lIGdsb2JhbGx5IGlmIGl0IGNhbiBiZSBibGluZGx5IGNv cGllZD8KPj4KPj4gQ2FuIHdlIGFsc28gaGF2ZSBhIGF0b21pY19jaGVjayBmdW5jdGlvbiBmb3Ig Y29ubmVjdG9ycywgc28gdGhlCj4+IGNydGNfc3RhdGUtPmNvbm5lY3RvcnNfY2hhbmdlZCBjYW4g YmUgc2V0IHRoZXJlPyBJdCB3b3VsZCBiZSBjbGVhbmVyCj4+IGFuZCBtb3JlIGF0b21pYy1saWtl Lgo+IEhtbS4gSSB0aGluayBpdCBtaWd0aCBiZSByZWFsbHkgdXNlZnVsIG9ubHkgaWYgd2UgaGF2 ZSBzb21lCj4gaW50ZXJhY3Rpb25zIGJldHdlZW4gbXVsdGlwbGUgcHJvcGVydGllcyB0aGF0IHJl YWxseSBuZWVkIHRvIGJlCj4gY2hlY2tlZC4gV2UgbWlnaHQgaGF2ZSB0aG9zZSBhbHJlYWR5IEkg c3VwcG9zZSBidXQgd2UgZG9uJ3Qgc2VlbQo+IHRvIGNoZWNrIGFueSBvZiBpdCBjdXJyZW50bHku IFNvIGFzIGEgZmlyc3Qgc3RlcCBJIGd1ZXNzIHdlIGNhbgo+IGp1c3Qga2VlcCBpZ25vcmluZyBh bnkgc3VjaCBpc3N1ZXMuCldlbGwgaXQgbWlnaHQgYmUsIGZvciBleGFtcGxlIG5vdCBhbGwgcHJv cGVydGllcyBtYXkgYmUgc2V0IHlldCBzbyB5b3UgY2FuIG9ubHkgZG8gYSBzYW5lIGNoZWNrIGlu IGEgc2VwYXJhdGUgc3RlcC4KPj4gVG8gbWF0Y2ggdGhlIGxlZ2FjeSBiZWhhdmlvciwgZm9ybWF0 IGNhbiBiZSBjaGFuZ2VkIGJ5IHByb2JpbmcganVzdCBsaWtlCj4+IGluIGxlZ2FjeSBtb2RlLgo+ IFNlbGYgbW9kaWZ5aW5nIHN0YXRlIGlya3MgbWUsIGJ1dCBpdCdzIHdoYXQgd2UndmUgYmVlbiBk b2luZyBzbyBJIGd1ZXNzCj4gd2Ugc2hvdWxkIGtlZXAgaXQuClllYWgsIEkgaGF0ZSBpdCB0b28u Cj4+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBs aW51eC5pbnRlbC5jb20+Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdHYu YyB8IDIzOCArKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tCj4+ICAxIGZp bGUgY2hhbmdlZCwgMTM2IGluc2VydGlvbnMoKyksIDEwMiBkZWxldGlvbnMoLSkKPj4KPj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3R2LmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF90di5jCj4+IGluZGV4IDZlZDFhM2NlNDdiNy4uMGZiMWQ4NjIxZmU4IDEw MDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF90di5jCj4+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3R2LmMKPj4gQEAgLTQ4LDggKzQ4LDYgQEAgc3RydWN0 IGludGVsX3R2IHsKPj4gIAlzdHJ1Y3QgaW50ZWxfZW5jb2RlciBiYXNlOwo+PiAgCj4+ICAJaW50 IHR5cGU7Cj4+IC0JY29uc3QgY2hhciAqdHZfZm9ybWF0Owo+PiAtCWludCBtYXJnaW5bNF07Cj4+ ICAJdTMyIHNhdmVfVFZfSF9DVExfMTsKPj4gIAl1MzIgc2F2ZV9UVl9IX0NUTF8yOwo+PiAgCXUz MiBzYXZlX1RWX0hfQ1RMXzM7Cj4+IEBAIC04NSw2ICs4MywxNiBAQCBzdHJ1Y3QgaW50ZWxfdHYg ewo+PiAgCXUzMiBzYXZlX1RWX0NUTDsKPj4gIH07Cj4+ICAKPj4gK3N0cnVjdCBpbnRlbF90dl9j b25uZWN0b3Jfc3RhdGUgewo+PiArCXN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlIGJhc2U7Cj4+ ICsKPj4gKwlpbnQgZm9ybWF0Owo+PiArCWludCBtYXJnaW5bNF07Cj4+ICt9Owo+PiArCj4+ICsj ZGVmaW5lIHRvX2ludGVsX3R2X2Nvbm5lY3Rvcl9zdGF0ZShzdGF0ZSkgXAo+PiArCWNvbnRhaW5l cl9vZigoc3RhdGUpLCBzdHJ1Y3QgaW50ZWxfdHZfY29ubmVjdG9yX3N0YXRlLCBiYXNlKQo+PiAr Cj4+ICBzdHJ1Y3QgdmlkZW9fbGV2ZWxzIHsKPj4gIAl1MTYgYmxhbmssIGJsYWNrOwo+PiAgCXU4 IGJ1cnN0Owo+PiBAQCAtODczLDMyICs4ODEsMTggQEAgaW50ZWxfZGlzYWJsZV90dihzdHJ1Y3Qg aW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPj4gIAlJOTE1X1dSSVRFKFRWX0NUTCwgSTkxNV9SRUFE KFRWX0NUTCkgJiB+VFZfRU5DX0VOQUJMRSk7Cj4+ICB9Cj4+ICAKPj4gLXN0YXRpYyBjb25zdCBz dHJ1Y3QgdHZfbW9kZSAqCj4+IC1pbnRlbF90dl9tb2RlX2xvb2t1cChjb25zdCBjaGFyICp0dl9m b3JtYXQpCj4+ICtzdGF0aWMgY29uc3Qgc3RydWN0IHR2X21vZGUgKmludGVsX3R2X21vZGVfZmlu ZChzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqY29ubl9zdGF0ZSkKPj4gIHsKPj4gLQlpbnQg aTsKPj4gKwlpbnQgZm9ybWF0ID0gdG9faW50ZWxfdHZfY29ubmVjdG9yX3N0YXRlKGNvbm5fc3Rh dGUpLT5mb3JtYXQ7Cj4+ICAKPj4gLQlmb3IgKGkgPSAwOyBpIDwgQVJSQVlfU0laRSh0dl9tb2Rl cyk7IGkrKykgewo+PiAtCQljb25zdCBzdHJ1Y3QgdHZfbW9kZSAqdHZfbW9kZSA9ICZ0dl9tb2Rl c1tpXTsKPj4gLQo+PiAtCQlpZiAoIXN0cmNtcCh0dl9mb3JtYXQsIHR2X21vZGUtPm5hbWUpKQo+ PiAtCQkJcmV0dXJuIHR2X21vZGU7Cj4+IC0JfQo+PiAtCXJldHVybiBOVUxMOwo+PiAtfQo+PiAt Cj4+IC1zdGF0aWMgY29uc3Qgc3RydWN0IHR2X21vZGUgKgo+PiAtaW50ZWxfdHZfbW9kZV9maW5k KHN0cnVjdCBpbnRlbF90diAqaW50ZWxfdHYpCj4+IC17Cj4+IC0JcmV0dXJuIGludGVsX3R2X21v ZGVfbG9va3VwKGludGVsX3R2LT50dl9mb3JtYXQpOwo+PiArCXJldHVybiAmdHZfbW9kZXNbZm9y bWF0XTsKPj4gIH0KPj4gIAo+PiAgc3RhdGljIGVudW0gZHJtX21vZGVfc3RhdHVzCj4+ICBpbnRl bF90dl9tb2RlX3ZhbGlkKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4+ICAJCSAg ICBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSkKPj4gIHsKPj4gLQlzdHJ1Y3QgaW50ZWxf dHYgKmludGVsX3R2ID0gaW50ZWxfYXR0YWNoZWRfdHYoY29ubmVjdG9yKTsKPj4gLQljb25zdCBz dHJ1Y3QgdHZfbW9kZSAqdHZfbW9kZSA9IGludGVsX3R2X21vZGVfZmluZChpbnRlbF90dik7Cj4+ ICsJY29uc3Qgc3RydWN0IHR2X21vZGUgKnR2X21vZGUgPSBpbnRlbF90dl9tb2RlX2ZpbmQoY29u bmVjdG9yLT5zdGF0ZSk7Cj4gSXQgZmVlbHMgYSBiaXQgZmlzaHkgdG8gdXNlIHRoZSBzdGF0ZSBo ZXJlLiBHZW5lcmFsbHkgdGhhdCdzIGEgbm8tbm8uCj4gQnV0IGluIHRoaXMgY2FzZSBJIHdvbmRl ciBpZiBpdCdzIHRoZSByaWdodCBjaG9pY2UgYWZ0ZXIgYWxsLiAKPgo+IE5vdCBzdXJlIGlmIHNv bWUga2luZCBvZiAiYXV0b21hdGljIiBlbnVtIHZhbHVlIG1pZ2h0IGFsc28gd29yay4gSXQKPiB3 b3VsZCBhdCBsZWFzdCBhdm9pZCB0aGUgc2VsZiBtb2RpZnlpbmcgcHJvcGVydHkgcHJvYmxlbS4g QWx0aG91Z2ggSQo+IHdvbmRlciBpZiB0aGUgdXNlciB3b3VsZCBzdGlsbCBsaWtlIHRvIGtub3cg d2hhdCB3YXMgYWN0dWFsbHkgdXNlZAo+IGlmIHRoZXkgY2hvc2UgdGhleSBhdXRvbWF0aWMgbW9k ZSwgc28gd2UgbWlnaHQgbmVlZCBhIHNlbGYgbW9kaWZ5aW5nCj4gUk8gcHJvcGVydHkgZm9yIHRo ZSBjdXJyZW50IG1vZGUgYW55d2F5Lgo+Cj4gQnV0IHRoYXQgc3RpbGwgbGVhdmVzIHRoZSBwcm9i bGVtIG9mIGhvdyB0aGUgdXNlciB3b3VsZCBrbm93IHdoaWNoIG1vZGVzCj4gdGhleSBzaG91bGQg YmUgYWJsZSB0byB1c2UgaWYgLmdldF9tb2RlcygpLy5tb2RlX3ZhbGlkKCkgZG9lc24ndCByZXNw ZWN0Cj4gdGhlIHVzZXJzIGNob2ljZSBvZiB0aGUgdHYgZm9ybWF0LiBIbW0sIHRyaWNreS4gTWln aHQgYmUgdGhlIHNlbGYKPiBtb2RpZnlpbmcgcHJvcGVydHkgaXMgdGhlIG9ubHkgZ29vZCBjaG9p Y2UuCj4KPiBCdXQgaWYgd2Ugd291bGQgdXNlIHRoZSBzdGF0ZSBoZXJlLCB3aGF0J3MgdGhlIHN0 b3J5IHdpdGggbG9ja2luZyBnb2luZwo+IHRvIGJlPyBjb25uZWN0aW9uX211dGV4IGlzIHdoYXQg cHJvdGVjdHMgdGhpcyBzdHVmZiwgYnV0IHdlJ3JlIG5vdAo+IGhvbGRpbmcgdGhhdCBkdXJpbmcg bW9kZSBlbnVtZXJhdGlvbi4KWWVhaCBsb2NraW5nIGlzIHRyaWNreSwgaG9uZXN0bHkgSSBoYXZl IG5vIGlkZWEgd2hhdCB3b3VsZCBiZSB0aGUgcmlnaHQgdGhpbmcgdG8gZG8gaGVyZS4uCgpJIGRv bid0IHJlYWxseSBzZWUgYSBnb29kIHNvbHV0aW9uLCBvciBhdCBsZWFzdCBvbmUgdGhhdCB3b3Vs ZCB3b3JrIGNvcnJlY3RseSB3aXRoIGF0b21pYyBwcm9wZXJ0aWVzLgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK