From: "flichtenheld (Code Review)"
Date: Tue, 22 Jul 2025 14:59:07 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="FNPH4z/9s5k="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: Check message
id/acked ids too when doing sessionid cookie checks
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: plaisthos
Cc: openvpn-devel
--FNPH4z/9s5k=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne=
t/c/openvpn/+/1067?usp=3Demail )
Change subject: Check message id/acked ids too when doing sessionid cookie =
checks
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
File tests/unit_tests/openvpn/test_pkt.c:
http://gerrit.openvpn.net/c/openvpn/+/1067/comment/69758acd_c7222844 :
PS3, Line 533:
Looking at the LeakSanitizer failure and the other test cases I think there=
is a `free_tls_pre_decrypt_state(&state);` missing here.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1067?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6752dcd5aff3e5cea2b439366479e86751a1c403
Gerrit-Change-Number: 1067
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos
Gerrit-Reviewer: flichtenheld
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Comment-Date: Tue, 22 Jul 2025 14:59:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--FNPH4z/9s5k=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos.
Patch set 3:Code-Review -1=
V=
iew Change
1 comment:
<=
p>To view, visit change 1067. To unsubscribe, or for help writing mail filters=
, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6752dcd5aff3e5cea2b43936647=
9e86751a1c403
Gerrit-Change-Number: 1067
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <arne-openvpn@...1711...=
27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Comment-Date: Tue, 22 Jul 2025 14:59:07=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--FNPH4z/9s5k=--