From: "flichtenheld (Code Review)"
Date: Wed, 16 Apr 2025 13:55:23 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, antonio@...2726...
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="6LxCP4oxOMM="; charset=UTF-8
Subject: [Openvpn-devel] [XL] Change in openvpn[master]: Reformat the whole
project with clang-format
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: plaisthos , openvpn-devel
--6LxCP4oxOMM=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: ordex, plaisthos.
flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne=
t/c/openvpn/+/791?usp=3Demail )
Change subject: Reformat the whole project with clang-format
......................................................................
Patch Set 16:
(1 comment)
File sample/sample-plugins/defer/multi-auth.c:
http://gerrit.openvpn.net/c/openvpn/+/791/comment/d4a601b3_b1efe856 :
PS14, Line 294: const char *envp[])
> I think we should. [=E2=80=A6]
I disagree. Note that when setting BinPackParameters to true this will appl=
y to all functions and all parameters. I think in general if the parameters=
to do fit on one line, it is better to put them one per line. Let's see wh=
at others think.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/791?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2566ad493629e1f5fdfa6f6483b8973463404e3e
Gerrit-Change-Number: 791
Gerrit-PatchSet: 16
Gerrit-Owner: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-CC: ordex
Gerrit-Attention: plaisthos
Gerrit-Attention: ordex
Gerrit-Comment-Date: Wed, 16 Apr 2025 13:55:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld
Comment-In-Reply-To: ordex
Gerrit-MessageType: comment
--6LxCP4oxOMM=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: ordex, plaisthos.
View C=
hange
1 comment:
I disagree. Note that when setting BinPackParameters to true =
this will apply to all functions and all parameters. I think in general if =
the parameters to do fit on one line, it is better to put them one per line=
. Let's see what others think.
To view, visit=
change 7=
91. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2566ad493629e1f5fdfa6f6483b=
8973463404e3e
Gerrit-Change-Number: 791
Gerrit-PatchSet: 16
Gerrit-Owner: flichtenheld <frank@...2723...=
.>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-CC: ordex <antonio@...2726...> =
div>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: ordex <antonio@...2726...=
>
Gerrit-Comment-Date: Wed, 16 Apr 2025 13:55:23=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
Comment-In-Reply-To: ordex <antonio@...2787...=
...>
Gerrit-MessageType: comment
--6LxCP4oxOMM=--