From: "cron2 (Code Review)"
Date: Wed, 23 Jul 2025 18:13:35 +0000
In-Reply-To:
References:
Reply-To: gert@...1296..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...,
antonio@...2726...
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="CPu+3HV88So="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: dco_linux: fix async
message reception
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: plaisthos , flichtenheld , openvpn-devel
--CPu+3HV88So=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, ordex, plaisthos.
cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/1100?usp=3Demail )
Change subject: dco_linux: fix async message reception
......................................................................
Patch Set 4: Code-Review-1
(7 comments)
Patchset:
PS4:
more polish needed
File src/openvpn/dco_linux.c:
http://gerrit.openvpn.net/c/openvpn/+/1100/comment/24854dbd_add7b22c :
PS4, Line 170: * Send a prepared netlink message and registers cb as callb=
ack if non-null.
this comment needs changing, though... "and registers cb"
http://gerrit.openvpn.net/c/openvpn/+/1100/comment/6281b84e_49f7ecd7 :
PS4, Line 903: msg(M_WARN, "%s: no peer-id provided in reply", __fu=
nc__);
maybe change the "reply" to "whatever this message type is", similar to the=
other "no peer-id provided" things?
http://gerrit.openvpn.net/c/openvpn/+/1100/comment/94873fa3_d40d8bb4 :
PS4, Line 938: msg(M_WARN, "%s: no peer-id provided in reply", __fu=
nc__);
as well
http://gerrit.openvpn.net/c/openvpn/+/1100/comment/41388847_81aa443f :
PS4, Line 951: struct multi_instance *mi =3D dco->c->multi->instanc=
es[peer_id];
how can we ever end here?
http://gerrit.openvpn.net/c/openvpn/+/1100/comment/5c6b04ae_b5f56bc3 :
PS4, Line 1182: if (nlh->nlmsg_flags & NLM_F_MULTI)
I'm not sure I understand this. p2mp peer messages are sent multicast, and=
p2p messages not? Or what does `NLM_F_MULTI` signal?
http://gerrit.openvpn.net/c/openvpn/+/1100/comment/a876ff1f_882629d9 :
PS4, Line 1189: }
I do wonder if this `if()` shouldn't just look at p->mode? Since `multi` d=
oes not want to deal with MODE_P2P, and _peer() now has extra code to deal =
with !MODE_P"P, just check beforehand?
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1100?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I23ad79e14844aefde9ece34dadef0b75ff267201
Gerrit-Change-Number: 1100
Gerrit-PatchSet: 4
Gerrit-Owner: ordex
Gerrit-Reviewer: cron2
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
Gerrit-Attention: ordex
Gerrit-Comment-Date: Wed, 23 Jul 2025 18:13:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--CPu+3HV88So=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, ordex, plaisthos. <=
/p>
Patch set 4:Code-Review -1=
V=
iew Change
7 comments:
<=
li style=3D"margin: 0; padding: 0 0 0 16px;">Patch Set #4, Line 951: struct multi_instance *mi =3D dco->c->multi->ins=
tances[peer_id];
how can we ever end here?
Patch Set #4, Line 1=
182: if (nl=
h->nlmsg_flags & NLM_F_MULTI)
I'm not sure I understand this. p2mp pe=
er messages are sent multicast, and p2p messages not? Or what does `NLM_F_=
MULTI` signal?
Patch Set #4, Line 1189: }
I do wonder if this `if()` sho=
uldn't just look at p->mode? Since `multi` does not want to deal wi=
th MODE_P2P, and _peer() now has extra code to deal with !MODE_P"P, ju=
st check beforehand?
To view, visit change 1100. To u=
nsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I23ad79e14844aefde9ece34dade=
f0b75ff267201
Gerrit-Change-Number: 1100
Gerrit-PatchSet: 4
Gerrit-Owner: ordex <antonio@...2726...>=
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Attention: ordex <antonio@...2726...=
>
Gerrit-Comment-Date: Wed, 23 Jul 2025 18:13:35=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--CPu+3HV88So=--