Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by mx.groups.io with SMTP id smtpd.web10.56215.1595858258049218130 for ; Mon, 27 Jul 2020 06:57:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=bS5eXp4N; spf=pass (domain: gmail.com, ip: 209.85.214.194, mailfrom: akuster808@gmail.com) Received: by mail-pl1-f194.google.com with SMTP id p1so8030012pls.4 for ; Mon, 27 Jul 2020 06:57:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=1yGFDZDCKdR3YzjlsZIQTNPsx+MR7Oz8f0NmpolH/R0=; b=bS5eXp4N/HSngNkTo2A9tvhVddYwVxaLxtW9zjllMUXTylhVlmKakYHISgkZsCCoF3 o/nE3k4kS3f4uisqJLTyz6Kud/2V+FDqV4RwtAUCT8eryivQpQJJdTj/nnEUG1TPbtMl en+hSdB4ytAwAfWhs109Gvoz5Kfx3QkG/6lC0v2H8h5WvJnCijC1oP/43iaxsVesr+7i PivPREGpEShQ6uuR1gxGOBakqGg37m8lb/nJ//a9NzJNvB08/UqyivZuWQggxayNYk+Y r1OzbOPwu6sq6yVXr+cG5BbtpOFl9XEEebSSuiLr4L92ternFiNs8LUyRF1GscNZZYlP AG1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=1yGFDZDCKdR3YzjlsZIQTNPsx+MR7Oz8f0NmpolH/R0=; b=YxZmF++6Uhu/j8A9rgt1zJNKiigNv/0cnjWGQU6mba+1TteN+lrN7Rh9JrNR9CEHUE yoHVcetFWWcJuwasiYCeY3W0moCX6OqFTz0cRuHR6IQ7veljMuV4wZ6Sykta42e8JYN7 tTJ3jV7U1YbWDeytAI7R9xe9KLQ+nOs3C1qTTQ6Et0XKaKZ5dAZytrGhNnQWchHbLBMV JP+eCgWxl0qSKkpeOf48Xj3xsgc1AdI9CiSIhFcrzrrCSOJgqzVBz1Gh8v3NR1cFUR0t FJQYNM+44f9PqDAxFYx0Bli4pvQSOi0N57enF0RYjOpCgFszGn6b6CQjRp/F+usN/JpV ZYRw== X-Gm-Message-State: AOAM530UDfOYGOPkppFvfa8YCoOfDQ4m/ol/FSxZ4xZE5enEKI9RX2+k ixqiArJWrfuOo3Aidy3toHtA2X63LIM= X-Google-Smtp-Source: ABdhPJzGI3NSlQESYCqC6RSilQ30hN2NFdelDA3/e7nXgOJsPlQ35CApC6k2jHxCEV7qxcWzlNYw8Q== X-Received: by 2002:a17:90a:df11:: with SMTP id gp17mr17391239pjb.188.1595858257433; Mon, 27 Jul 2020 06:57:37 -0700 (PDT) Return-Path: Received: from ?IPv6:2601:202:4180:a5c0:8df1:f28:d14a:8296? ([2601:202:4180:a5c0:8df1:f28:d14a:8296]) by smtp.gmail.com with ESMTPSA id k12sm5065169pjp.38.2020.07.27.06.57.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jul 2020 06:57:36 -0700 (PDT) Subject: Re: [OE-core] [v2][PATCH] cve-check: print warning if file is missing To: Richard Purdie , openembedded-core@lists.openembedded.org References: <20200727025231.24418-1-akuster808@gmail.com> From: "akuster" Autocrypt: addr=akuster808@gmail.com; prefer-encrypt=mutual; keydata= xsFNBFnlUP4BEADpKf+FQdLykenQXKk8i6xJNxDow+ypFeVAy8iFJp7Dsev+BtwUFo8VG7hx Jmd71vHMw+coBetWC3lk+IKjX815Ox0puYXQVRRtI+yMCgd6ib3oGxoQ8tCMwhf9c9/aKjaz mP97lWgGHbiEVsDpjzmMZGlJ6pDVZzxykkJExKaosE46AcA8KvfhRQg5zRyYBtinzs8Zu8AP aquZVHNXxPwjKPaSEEYqQjFeiNgFTavV+AhM2dmPmGUWCX9RZisrqA4slGwEB0srMdFf12Zg mD35Y9jZ80qpu5LPtJCFcsaAlebqR+dg36pIpiRR+olhN1wmC6LYP1vw6uMEYBjkTa2Rnb6+ C4FDzCJD4UCrUvLMNeTW810DY0bjMMj3SfmSGSfQUssaaaTXCVlLGuGxyCr/kza1rHaXMKum Ek4EFj1fyn7AfkSLEHfJfY4sO1tpgigvs4eD/4ZSQEXSu/TjVvyKx4EvUbhlGMRyH2CPwD/H 7DFF8tcVtJvCwUUW+zKtjxjSSLrhniNMXAOQJZ6CdaqCe4OyJQT5aRdr+FWbBRjpaRCCf5nf dTc88NMU9PrBT3vu0QJ5WNPO6MJpnb+d8iMNLZAz8tv8JMm2l+sMcNKSJ6lhX8peoBsfMVqc FgiykEO0fUt7DCbUYR5tLjM/3E5tHvTjMooVJyOxoufVLYtTtQARAQABzSFha3VzdGVyODA4 IDxha3VzdGVyODA4QGdtYWlsLmNvbT7CwX0EEwEIACcFAlnlUP4CGyMFCQlmAYAFCwkIBwIG FQgJCgsCBBYCAwECHgECF4AACgkQ7ou0mfRW5/kuhRAAlR2FTq5572jrX5nnPR7AqI2bvSVb vqGLlvv739WhghvagbC+tu05QguopAhWW1/DcHK2+QtfIoC9UZrSW4RaO0CCo5sPjqK7l1KT ngWX/rGjF6xTF2QN0U/btcpMyVN2CNtVLwsDF9e+GHKoUcnFkP+JP8vHGokN9k6E/c97hLaL IJPeKl8LZXc2Efk+MaW1NXkfDJdcp/p+voajbihSQO6OZ/o+x9d2I3ZybKfTZ71+ek5Hxzjz g6KkMOI7KJjlmBlrQFAtVbS+CFAKrwkYznE6ggkcmGv3N7DeUBTUR78hf+EZEAM+ajeLMtrG rXE00pIb+gLGYPZxba5pCdQ+qWUW38qi9UnIRPm6fq7Ypx1r6XwJvbgCOkhbxo3D4YUdyC0b FE9lgrg8htbc9in4j2+hVI6ALswNjLprzXdzdKrd+T3Egx36o3Z/qrYsW2o5/A5sVvvASVKi wRPuEKhEhfmiHUPLvuKqhMoymHaz3fg5D2Q8G0gSDkLgeEpAjiWqf4+AGLx+MSDai7DSOsmI t61kWxs7cFTB32UrB/TDoVNn3Fm88ZFQpA/bngikE9jgEm045mSY86fNlbFj2mcCd0Ha1i1n aYc97RpgfjNMWyHDVHOGrNg/hJjkGa5RsAXkfyBwltHRw0Hj4urUQ3rr8um8PLe43SezPwXA oRoyDxDOwU0EWeVQ/gEQALNHwj5VSPdnvXy1RXUuH+rclMx4x8zaqDyY0YqHfA7b/d8Y0VAt Y6YpzDeFTwD8A0Wfb7kZ2mlDIE6ODCB71uT/E3C6b+FiiN+lgzslznjUW+9l8ddDhRrC8HMG 37vrXF5h++PTXUKEKUlkDib1w093tu3mlJXUvIAzl8CEHkptF6Br0L9XxFwuWoNUfjT9IorQ 0SVIhvq5PhVAITXUD5fD7/N8B4TYegmHFRo1UaaKSnSHwlJJkzKpeWOH8QTYrP0RHxX86Obv IZuwbAo3F3oojcvLJt9NxWnbEmEALkleklLZnukgu7q5Wp1VDwhUbMFTLb6qmnBa/Xi30uOk 0l1TMHDbeQswvQDOZBAMukSRqyBetKxQ3iTfZ/3z1ubQRcVDbVlMDScSHQq0LK3F9yMOMM/6 0QPqJjl13xn/+Bn7WJiAIXXwzAV7uo6i0khFfjDtCDQ40aeffqOLxp1yMLkc3EKJGcQ5F6O2 ycEf4QXCYUbMXjxB0EJB8y7z+xOi5Mmd/pPlVmZ2gQK84NAL90p7n7jRlyf3gOUY+JOl4c5e UFiIhOzmuqNrvPOiZ02GXh6SGUU5y7IgSoIKvXSFgHAn2OG/tcspBmkyv6IuNVpmbmEgYn4I Rnt40UXVQkxTh0dENFhk2cjunMYozV/OqYCgmZLFSeJd8kAo4yn+yOtNABEBAAHCwWUEGAEI AA8FAlnlUP4CGwwFCQlmAYAACgkQ7ou0mfRW5/nNcg//R63cbOS6zLtvdnPub3Ssp1Ft8Wmv mni+kccuNApuDV7d63QckYxjAfUv2zYMLpbh87gVbLyCq9ASn552EbfRhTvHdk44CgbHBVcI ZBEdZWgRR5ViJakQSYHpP2e5AGNFnx9gSIuRTaa5rvZM+4xeoZ2vJiq93TtaYPr7UFNfK+c4 vv4C66lkt9l95/I10eSc3RqbOKZW47emlg4X3ygEoB9k2lPrpspyf6sUuSEi0WrlSxoLAr6p JG8rTUErYNeXe6JCdL31odDx1Dh5sdKIj2RicUYZNilxu9f1M7jZwf2ra1FGAlKj2ybqmgpZ EFteaiCinEYsvDyZyOiWHjAFI+RZIPQQL3AnVp4l7wYD3r9hnqYPww0slyMDcb9262RoFkHq dDwxPYarrNjWUpOzxB6bFxOgNRdCTgvQl8Ftk8a/yXB6vHeUSm1vPFCBxQPZytyfOLhEWm0J /mkVL0Z6iRK3p1LKnpLYCS4/esL2u7RrhPyCs2SsL58YcQF/g+PpeT9geZ+oyZ/4IQ+TWJoU PNHndk8VBTpzrmOaJxrebNL/W6C8JCmbLM11TAUMmHYi9JDytN8Au78hWpDbIdKwg1LeSxpw ZZD/OqOc0DBvHOpQhzkSrtR1lVlDV/+9E8J1T4uDhrGmZwYV+4xQetypHax8aAHisYbjXdVa 8CS2NxU= Message-ID: Date: Mon, 27 Jul 2020 06:57:35 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US On 7/27/20 2:39 AM, Richard Purdie wrote: > On Sun, 2020-07-26 at 19:52 -0700, akuster wrote: >> If the "tmp/cve_check" file was not create as in the case for -c >> populate_sdk, just print a >> warning instead of dumping a trace back >> >> --- >> v2] lets include the missing part of the patch >> >> Signed-off-by: Armin Kuster >> --- >> meta/classes/cve-check.bbclass | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/meta/classes/cve-check.bbclass b/meta/classes/cve- >> check.bbclass >> index 0889e7544aa..b16da9890af 100644 >> --- a/meta/classes/cve-check.bbclass >> +++ b/meta/classes/cve-check.bbclass >> @@ -55,6 +55,10 @@ python cve_save_summary_handler () { >> =20 >> cve_tmp_file =3D d.getVar("CVE_CHECK_TMP_FILE") >> =20 >> + if not os.path.isfile(cve_tmp_file): >> + bb.warn("File Not found: %s" % cve_tmp_file) >> + return >> + > A warning is something the user really needs to fix or take some action= > about. Is this a warning? Its actually an error in certail conditions. Do we want this to be silent or fail on 'populate_sdk'? > > Cheers, > > Richard > > >