References: <1514540857-19290-1-git-send-email-steffan.karger@...1435...> From: Steffan Karger Message-ID: Date: Fri, 29 Dec 2017 11:23:01 +0100 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Subject: Re: [Openvpn-devel] --with-mem-check, what to do with it? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: =?UTF-8?B?0JjQu9GM0Y8g0KjQuNC/0LjRhtC40L0=?= Cc: openvpn-devel@lists.sourceforge.net Hi, On 29-12-17 11:11, Илья Шипицин wrote: > thank for the patch. > > not directly related to the patch itself, but openvpn is shipped with > several memory debugging options > > --with-mem-check=TYPE   build with debug memory checking > > > should we get rid of them (in favour of sanitizers) ? or, maybe add to > tests instead ? I've tried to use those in the past, but found them hard to use. I think they're a remnant of the past. I would personally prefer to get rid of them and use the (nowadays much better) fully external memory checking tools instead (sanitizers, valgrind, etc). -Steffan