Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CA7DC433E0 for ; Mon, 25 Jan 2021 17:42:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C522122583 for ; Mon, 25 Jan 2021 17:42:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C522122583 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D+8UkmpghrZzmzhiGlFMmvXPMtDtoQSJ7KHyiC/4ZMs=; b=mKAeYovJLxMsr6w3lRmQvuO1Q ABoZTpnJAHOIj4S86xyec4ADiYHwEMXJAiXHKiyNf7DoYQkiEIZWOUPUOYCv4vQaObuSCSfgtXtRY t8/BoMr0pXz2wANIkcWbF68mQjnxldKYr2hA8o+n68MR4wT5WsVIkDAz8YXt6YXODAvy4L0335ujb OlLvRzviMoxPjuxHbweZhqe7mASz2jQIFwx1AILAIWb85MWcjYKqpwD4ZfcxFm9CCU2uBhyhm/fIj rLksDWJEU0GR7SH4ZwsVTp4Bs48LZVWWII1XncbXIvJuMEDryzd6dmyn1scuJz1UQ4QTz2QU6BL2T O/C3b9iBA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l45qk-0000ss-Pz; Mon, 25 Jan 2021 17:40:26 +0000 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l45qi-0000sA-3L for linux-arm-kernel@lists.infradead.org; Mon, 25 Jan 2021 17:40:25 +0000 Received: by mail-pf1-x434.google.com with SMTP id t29so8794340pfg.11 for ; Mon, 25 Jan 2021 09:40:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Ll5CPSA8oXAVF+ATpu54RVy1Dmm80vxtyP/rheTo5bY=; b=TrPHo+IIlhYXEIUGZnvVvy0gZqdTpRW2zdvLckAXnziMr3wC+urBR+OmQS8W73nnb0 N0vxhZJ8/8h99P+aZTdkqPzGQoVGVnDTGGoAs2tnSGyPtQOQ6naUqLpCyfOQLDQ3U7/S Afcy9kRlkwOaVGteCaBQ7XKmTp5sTPwkXkzaFu62CivM4nKEJN0l6aBwf+zzA3ZNkUxX Wj6Gpi0KSHnPDgqDGdITrbPhONGqTLpaZO8ilrZnPxTaabHzp8ivl6w9laSqsNPyOLPz 1I5D0O+xlBEOlorR1+7UfVaAxC6ZZcvj2q+KhRGt5e1gU1O3zpdmsCceM7ob5Rn7rEub 0Zlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ll5CPSA8oXAVF+ATpu54RVy1Dmm80vxtyP/rheTo5bY=; b=dyysqVtj2hgO+XXUFzA8cPN0J7vfjCPF+1P2is47C2n0zQn62k/9nTlertlslcuYw3 JcEYzybq3TJSTXXJrLl8X1IFi4kzTWFLMF/sBM7BQ31YS1PIsAHvm/E4XIfoDJAX0goo KPXmFPZEljARw3yv6AkC1sjrPqUpx4xTU6PWAzHqXg52giedCEWvg2qvzifn+OBbG/Vo UVb7peystJ4B6WHdBSfuewSw0dgMbYBTVo72tqojG0QwFKS2jPVLuKrnlagqy9pc4PF3 PL5/HeOyWiDqVMxFcoqZPkyttfdIJ/KLRuMJgPUNXKwT9+YdTIPpsO7c7+6uQm37qm+F OyZQ== X-Gm-Message-State: AOAM532z3T0tiLtOSvtS5ajHyoTWEy7tS7CE6hqrutuZ06FH6poJWRWp lXlMtmqFB7JVZN2wHtqVdhY= X-Google-Smtp-Source: ABdhPJx/x1gICR2eqXW4n+pOoamjEIIYYGojiydYeWPyZhXE0r9WcMnr2TwUrRP7Nat2R+vlDUpYzg== X-Received: by 2002:a63:6d2:: with SMTP id 201mr1614834pgg.270.1611596420007; Mon, 25 Jan 2021 09:40:20 -0800 (PST) Received: from [10.230.29.30] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id c5sm17764227pgt.73.2021.01.25.09.40.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Jan 2021 09:40:19 -0800 (PST) Subject: Re: [PATCH] mmc: brcmstb: Fix sdhci_pltfm_suspend link error To: Arnd Bergmann , Al Cooper , Adrian Hunter , Ulf Hansson , bcm-kernel-feedback-list@broadcom.com, Nicolas Schichan References: <20210125125050.102605-1-arnd@kernel.org> From: Florian Fainelli Message-ID: Date: Mon, 25 Jan 2021 09:40:16 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210125125050.102605-1-arnd@kernel.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210125_124024_149158_4D2F2B5A X-CRM114-Status: GOOD ( 17.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , linux-mmc@vger.kernel.org, Douglas Anderson , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org +Nicolas, On 1/25/2021 4:50 AM, Arnd Bergmann wrote: > From: Arnd Bergmann > > sdhci_pltfm_suspend() is only available when CONFIG_PM_SLEEP > support is built into the kernel, which caused a regression > in a recent bugfix: > > ld.lld: error: undefined symbol: sdhci_pltfm_suspend >>>> referenced by sdhci-brcmstb.c >>>> mmc/host/sdhci-brcmstb.o:(sdhci_brcmstb_shutdown) in archive drivers/built-in.a > > Making the call conditional on the symbol fixes the link > error. > > Fixes: 5b191dcba719 ("mmc: sdhci-brcmstb: Fix mmc timeout errors on S5 suspend") > Fixes: e7b5d63a82fe ("mmc: sdhci-brcmstb: Add shutdown callback") > Cc: stable@vger.kernel.org > Signed-off-by: Arnd Bergmann > --- > It would be helpful if someone could test this to ensure that the > driver works correctly even when CONFIG_PM_SLEEP is disabled Why not create stubs for sdhci_pltfm_suspend() when CONFIG_PM_SLEEP=n? I don't think this is going to be a functional issue given that the purpose of having the .shutdown() function is to save power if we cannot that is fine, too. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel